보안이 강화된 JWT 비밀키 발급, 비밀키로 서명로직 변경 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
min-0
reviewed
Aug 26, 2024
| this.accessTokenExpiredTime = accessTokenExpiredTime; | ||
| this.refreshTokenExpiredTime = refreshTokenExpiredTime; | ||
| this.secretKey = Keys.hmacShaKeyFor(Decoders.BASE64URL.decode(secretKeyString)); |
There was a problem hiding this comment.
SecretKey라는 인터페이스를 사용해 해당 코드로 아래 수정된 코드들을 간편하게 된 것인가요
아니면 SecretKey 인터페이스 사용으로 보안이 더 강화된 것인가요 ?!
또는 둘 다..?
There was a problem hiding this comment.
제가 이부분은 문제맥락을 뚜렷하게 설명 안드린것같네요
기존에 주셨던 JWT 비밀키가 보안문제가 있어 아예 토큰이 안만들어졌습니다. 그래서 길이를 좀더 늘려서 비밀키를 새로 생성해서 변경했어요.
https://green-bin.tistory.com/49
There was a problem hiding this comment.
코드 변경점이랑은 크게 상관이 없다고 볼수있습니다 JWT 비밀키만 임의로 생성해서 환경변수값을 변경했어요
min-0
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.