인증객체 ,ArgumentResolver추가 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* spring security에 비해 익숙하고 간단한 ArgumentResolver로 구현
Closed
min-0
reviewed
Aug 26, 2024
Comment on lines
+25
to
+28
| @Override | ||
| public boolean supportsParameter(MethodParameter parameter) { | ||
| return parameter.getParameterType().equals(AuthenticationMember.class); | ||
| } |
There was a problem hiding this comment.
이 메소드는 해당 파라미터가 컨트롤러에서 처리할 수 있는 파라미터 타입인지 확인하는 거 맞나요 ?!
min-0
reviewed
Aug 26, 2024
min-0
reviewed
Aug 26, 2024
Comment on lines
+21
to
+24
| @Override | ||
| public void addArgumentResolvers(List<HandlerMethodArgumentResolver> resolvers) { | ||
| resolvers.add(new AuthResolver(memberRepository, jwtProvider)); | ||
| } |
There was a problem hiding this comment.
이 메소드는 어떤 일을 하는건가용
AuthResolver를 생성하면서 memberRepository와 jwtProvider를 주입하게 되면 어떻게 되는지 궁금합니다!
There was a problem hiding this comment.
단순하게 생성자 주입이라고 생각하시면 될것같습니다 AuthResolver에서 memberRepository와 jwtProvider를 사용할수있게됩니다~~~
|
고생하셨숩니다 ~결국 spring security 안쓰시는 방향으로 하셨군요! |
|
일정때문에 빨리 선택하게되었어요 나중에 경험으로 개선포인트 욕심이 있긴합니다~~ |
min-0
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Screenshot 📷
위와같이 컨트롤러 parameter에 resolver에 등록한 객체(AuthenticationMember)가 있는경우 해당 메서드 실행전에 resolver가 실행되고 Member에대한 정보를 컨트롤러로 반환