-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat-15] 애플로그인 API 변경, refresh token 발급 메커니즘 변경 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 매개변수와 객체 생성에 final은 안붙히기로 결정
Closed
우선 바로 approve 할게요 |
min-0
approved these changes
Aug 22, 2024
This reverts commit 65f64d450891abb7beb7e3cc49ba419caad72d1b.
This reverts commit 3db2311.
* 인텔리제이 auto import때문에 계속 충돌한게 원인
* } 하나 빠트림
* RegionDto 변경 누락
* MapRepository 제거
* 당장은 테스트코드가 중요한것이 아니므로, 나중에 테스트 코드할때 추가해서 배포한다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
애플로그인 API 변경, refresh token 발급 메커니즘 변경
주의
진행하지 못하고 급하게 PR 올렸지만 클라이언트에게 유효한 apple authorization code를 받아 실제 API를 호출하는 테스트 필요함.