Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #68

Merged
merged 30 commits into from
Feb 21, 2024
Merged

dev -> main #68

merged 30 commits into from
Feb 21, 2024

Conversation

Starlight258
Copy link
Collaborator

๐Ÿ”— Linked Issue

resolved #59
resolved #60
resolved #62
resolved #65



๐Ÿ“‹ Code Review Priority Guideline

  • ๐Ÿšจ P1: Request Change
    • ํ•„์ˆ˜ ๋ฐ˜์˜: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์‹œ๊ณ , ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (์ˆ˜์šฉ ํ˜น์€ ํ† ๋ก ).
  • ๐Ÿ’ฌ P2: Comment
    • ๊ถŒ์žฅ ๋ฐ˜์˜: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š”.
  • ๐Ÿ‘ P3: Approve
    • ์„ ํƒ ๋ฐ˜์˜: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค. ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค.

FacerAin and others added 30 commits February 20, 2024 15:22
[Feat#-] Production์„ ์œ„ํ•œ Docker compose ์—…๋ฐ์ดํŠธ
[Feat/#59] ํšŒ์˜์‹ค ๋‚˜๊ฐ€๊ธฐ ๊ธฐ๋Šฅ ๋ฐ ์•ˆ๊ฑด ์ˆ˜์ • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ, ๊ธฐํš ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•œ ์ฝ”๋“œ ์ˆ˜์ •
[Feat#65] ์•ˆ๊ฑด ์ˆœ์„œ ์ˆ˜์ • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
[Feat/#-] ๊ธฐํš ์‚ฌํ•ญ์„ ๊ณ ๋ คํ•˜์—ฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๋ฐ ๋ฆฌํŒฉํ† ๋ง
Copy link
Collaborator

@FacerAin FacerAin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) ๐Ÿ‘

@Starlight258 Starlight258 merged commit e530bcd into main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment