-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#59] 회의실 나가기 기능 및 안건 수정 기능 개발, 기획 변경으로 인한 코드 수정 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight258
changed the title
Feat/meeting agenda updates
[Feat/#59] 회의실 나가기 기능 및 안건 수정 기능 개발
Feb 20, 2024
Starlight258
changed the title
[Feat/#59] 회의실 나가기 기능 및 안건 수정 기능 개발
[Feat/#59] 회의실 나가기 기능 및 안건 수정 기능 개발, 기획 변경으로 인한 코드 수정
Feb 20, 2024
FacerAin
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
FacerAin
reviewed
Feb 21, 2024
|
||
public AgendaPatchResponse patchAgenda(Long meetingId, Long agendaId, AgendaPatchRequest patchRequest) { | ||
// 회의 존재 여부만 확인 | ||
boolean meetingExists = meetingRepository.existsById(meetingId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existsById 활용하여 컬럼 존재 여부 확인 좋습니다. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
resolved: #59 #60
🛠 개발 기능
기획 변경으로 인한 코드 수정
🧩 해결 방법
미팅 나가기 기능
: 방장이 회의를 떠날 경우 회의에 남은 사람을 랜덤으로 방장으로 설정하도록 구현했습니다.방장이 아닐 경우에는 회의에 떠나는 작업만 수행됩니다.
안건 수정 기능
: 안건 이름과 할당 시간을 수정하는 기능을 구현했습니다.참가자 조회 기능
개선 : 참가자 조회 API에방장 정보
를 추가회의 시작 프로세스
: 안건 시작시 자동으로 회의 시작되도록 기능 구현🔍 리뷰 포인트
📋 Code Review Priority Guideline