Do not attempt to enable ProtocoLib on untested versions #2719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of users report issues in which they use an outdated version of ProtocolLib together with a recent version of Minecraft.
In this case, ProtocolLib only prints a single-line warning and proceeds as usual. However, this usually causes during the enabling of the plugin or runtime.
This PR changes this to disable ProtocolLib when the version of Minecraft is not supported.
Users a directed to the GitHub releases page and Jenkins in this case.
If the version is explicitly whitelisted in the
config.yml
, a warning is printed to the log and ProtocolLib enables as usual.What do you think about this? @dmulloy2