Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup4 #2482

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Cleanup4 #2482

wants to merge 30 commits into from

Conversation

Photon-GitHub
Copy link

@Photon-GitHub Photon-GitHub commented Jul 14, 2023 •
edited
Loading

Another cleanup pull request :)

Main features:

  • Replaced a string equalsIgnoreCase chain with a switch lookup
  • Made some cache lookups faster by querying only once
  • Replaced the weird command init in the main class and removed its private enum
  • Faster RangeParser with BitSet (maybe a test for this might be a good idea?)
  • Replaced some manual mappings with streams
  • Use ImmutableSet for the report filter
  • Replace old BiFunction from pre-java 8 times with the new java equivalent.

@Photon-GitHub
Remove ProtocolCommand enum.
d15fa97
@Photon-GitHub
Lazy init of filteredReporter, use ImmutableSet.
1709b62
@Photon-GitHub
Rename parameter to not be the "record" keyword.
1fe43f7
@Photon-GitHub
Simple cleanup.
1abb0d0
@Photon-GitHub
Faster getFirst lookup.
5b702ce
@Photon-GitHub
Simple cleanup.
3ea61b0
@Photon-GitHub
switch case instead of equalsIgnoreCase chain.
a30e1dd
@Photon-GitHub
Simple cleanup.
994ec37
@Photon-GitHub
Simple cleanup.
1525536
@Photon-GitHub
Use streams for mapping.
58f311e
@Photon-GitHub
Reduce nesting.
0d6ac32
@Photon-GitHub
Faster cache lookup.
edd2e42
@Photon-GitHub
Reduce nesting.
ba73098
@Photon-GitHub
Faster mapping with streams.
8acbede
@Photon-GitHub
Simple cleanup.
f5f2b5c
@Photon-GitHub
Faster temporaryPlayer method lookup.
384e61d
@Photon-GitHub
Make final.
129aa5d
@Photon-GitHub
Fast range parsing.
c4375b8
@Photon-GitHub
Default command "?"
39174d2
@Photon-GitHub
Bugfix.
3230c5a
@Photon-GitHub
Actually limit the range.
9f787c6
@Photon-GitHub
Improve RangeParser.
73aa45f
@Photon-GitHub
Improve documentation.
8a98382
@Photon-GitHub
Make enum field final.
73d29ca
@Photon-GitHub
Simple cleanup.
96fd3f0
@Photon-GitHub
Simple cleanup.
e7cf2b5
@Photon-GitHub
Simplify return value.
1b860f7
@Photon-GitHub
Make some values final.
b234c6d
@Photon-GitHub
Use Java's BiFunction.
3a30fe9
@Photon-GitHub
Simple cleanup.
700012c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Photon-GitHub