Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacy and Transformers Dependency Upgrade #97

Closed
wants to merge 3 commits into from

Conversation

igorbrigadir
Copy link

Use spacy 3 model and sentencizer. This seems to be all that is needed to use Spacy 3. Thanks to #95 (comment) pointers.

I also want to upgrade transformers version too but just going to double check it doesn't break anything.

@igorbrigadir igorbrigadir changed the title Dependency upgrade Spacy and Transformers Dependency Upgrade Feb 11, 2021
@igorbrigadir
Copy link
Author

https://github.com/huggingface/neuralcoref requires some pretty substantial changes to work with Spacy 3.0.0 huggingface/neuralcoref#295 so it may be faster to either disable the coref part when using spacy 3.0.0 or replace it with an alternative.

@dmmiller612
Copy link
Owner

yep, I recently made updates over the weekend in master to get it to work with both space 2 and 3. I'll update neuralcoref once they make the necessary changes.

@igorbrigadir
Copy link
Author

Great!

Since I only needed a stopgap to not break my own pipeline, my solution was to rip it out entirely - so i'm gonna close this and update again when there's a new neuralcoref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants