Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend configuration platform-independent #12137

Closed
wants to merge 5 commits into from
Closed

Make backend configuration platform-independent #12137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
430081e
Backend: Remove dead util_set16 function
Geod24 Jan 19, 2021
521493d
Backend: Pass the target OS to the backend
Geod24 Jan 19, 2021
d73e6f8
Backend: Use runtime condition for configuration
Geod24 Jan 19, 2021
87dfda4
Backend: Merge util_set32 and util_set64
Geod24 Jan 19, 2021
e3be078
Backend: Remove static conditions in util_set
Geod24 Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/dmd/backend/backconfig.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,21 +360,6 @@ void out_config_debug(

}

/*************************************
*/

void util_set16()
{
// The default is 16 bits
_tysize[TYldouble] = 10;
_tysize[TYildouble] = 10;
_tysize[TYcldouble] = 20;

_tyalignsize[TYldouble] = 2;
_tyalignsize[TYildouble] = 2;
_tyalignsize[TYcldouble] = 2;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if dmc still uses this function? If so, it would be worth mentioning in the commit message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way to check this, so I wanted to get @WalterBright 's opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMC is open sourced on the digitalmars github org IIRC, so it can be checked.


/*******************************
* Redo tables from 8086/286 to 386/486.
*/
Expand Down Expand Up @@ -557,4 +542,3 @@ else
_tyalignsize[TYrestrictPtr] = _tyalignsize[TYnptr];
_tyalignsize[TYfgPtr] = _tyalignsize[TYnptr];
}

1 change: 0 additions & 1 deletion src/dmd/backend/global.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ void util_assert(const(char)*, int);
//#endif

void util_progress();
void util_set16();
void util_set32();
void util_set64();
int ispow2(uint64_t);
Expand Down