#118: Added missing "disabled" attribute to select template #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carltongibson As promised, I started fixing bugs 🙃 |
…-for-selects # Conflicts: # docs/requirements.txt
|
@carltongibson Fixed the pipeline here as well. Would be happy to get a quick review. |
|
@GitRon LGTM. Press on! 😅 I might have to review in batch if you're too quick 😜 — But we can always fix things/nothing really will break 🥰 |
|
That's true! I think having a release and then go through the open issues and PRs should take some time but then we should have a clean slate again. |
|
Sounds like a plan. If you can line up a release (or as close as possible) and we'll see if we can't push it out the door. (He says, noting to himself, that likely @smithdc1 is on the hook for it 😜) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue #118 and supersedes PR #120.