Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove field_class from div-wrapper in FormActions #196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SnejPro
Copy link

@SnejPro SnejPro commented Dec 31, 2024

Problem:

  • When using helper.form_class="form-horizontal" and FormActions the submit-button is misaligned
  • I suspect this is due to an incorrectly placed {{ field_class }} in the div-wrapper in FormActions

Current state:
grafik

With my fix:
grafik

@SnejPro
Copy link
Author

SnejPro commented Dec 31, 2024

The failed test is not because of my changes when my interpretation of the test results is correct?

@smithdc1
Copy link
Member

The failed test is not because of my changes when my interpretation of the test results is correct?

I'm not at my desk but looking seeing that the failing test is to do with formactions I would say that it is related.

@SnejPro
Copy link
Author

SnejPro commented Dec 31, 2024

The failed test is not because of my changes when my interpretation of the test results is correct?

I'm not at my desk but looking seeing that the failing test is to do with formactions I would say that it is related.

I think i got the testing right now :)

@SnejPro
Copy link
Author

SnejPro commented Jan 4, 2025

The failed test is not because of my changes when my interpretation of the test results is correct?

I'm not at my desk but looking seeing that the failing test is to do with formactions I would say that it is related.

I think i got the testing right now :)

@smithdc1 Was the test successful? Sry, I'm not that familiar with github testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants