Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic serializer fields #109

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Add support for dynamic serializer fields #109

merged 4 commits into from
Dec 23, 2024

Conversation

melvinkcx
Copy link
Contributor

@melvinkcx melvinkcx commented Dec 20, 2024 •
edited by browniebroke
Loading

Replace serializer.get_field() with serializer.fields to support dynamic fields.

fix #108

@browniebroke
Copy link
Member

Do you think you could write a test to cover the dynamic fields case? Thanks!

@melvinkcx
Copy link
Contributor Author

sure, I added a test case. Please check again :)

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
drf_excel/renderers.py 86.74% <100.00%> (ø)

@browniebroke browniebroke changed the title replace serializer.get_field() with serializer.fields Add support for dynamic serializer fields Dec 23, 2024
@browniebroke browniebroke merged commit d58604f into django-commons:main Dec 23, 2024
7 checks passed
@browniebroke
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic serializer fields are not supported
2 participants
@melvinkcx @browniebroke