Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize a bit the codebase with Ruff #101

Merged

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Oct 16, 2024

Enable more Ruff rules and fix issues raised

@browniebroke browniebroke changed the title Enable more Ruff rules Modernize a bit the codebase with Ruff Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4a01c06). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage        ?   92.89%           
=======================================
  Files           ?        4           
  Lines           ?      352           
  Branches        ?        0           
=======================================
  Hits            ?      327           
  Misses          ?       25           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drf_excel/mixins.py Outdated Show resolved Hide resolved
@browniebroke browniebroke force-pushed the lint/enable-more-ruff-rules branch from 58046a2 to c9ca309 Compare October 16, 2024 18:22
@FlipperPA
Copy link
Member

LGTM, whenever you're confident!

@browniebroke browniebroke merged commit cefa815 into django-commons:main Oct 16, 2024
6 checks passed
@browniebroke browniebroke deleted the lint/enable-more-ruff-rules branch October 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants