Enhance nested serializer handling by skipping write_only fields. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage ? 93.18%
=======================================
Files ? 4
Lines ? 352
Branches ? 0
=======================================
Hits ? 328
Misses ? 24
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Nice one, do you think you could try to update our test suite accordingly? Thanks |
|
@browniebroke Done. Bizarre behavior from ruff :) |
Yes, that's the isort rule I believe |
browniebroke
approved these changes
Oct 18, 2024
|
@CorneiZeR Thank you! We'll get this pressed in our next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my
write_onlyfields were trying to render in the final excel. This fix should solve that problem. Also couldn't resist leaving the docstring.