-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix tests running #85
base: master
Are you sure you want to change the base?
Conversation
@vinitkumar It seems the compiled test requirements do not contain a pinned version of django CMS and the tests always install the latest django CMS 4. I guess the @marksweb I am not sure it is a good idea to pin the installed versions for tests. We miss incompatibilities from changes in libraries after the compile time. What do you think? |
@fsbraun do you specifically mean pinning cms? |
@marksweb The I've added But my question was a different one: I would prefer not to compile the requirements for tests to always run against the latest dependencies. Otherwise, we will not notice incompatibilities introduced in new releases of dependencies after the compile time. Am I missing something? |
@fsbraun you're probably not missing anything but this was a pattern I picked up from Adam Johnson. And I quite like how easy it makes updating and maintaining requirements. I get the point about missing new releases. But maybe we can script /automate the updating of requirements a bit like how dependant can. Or maybe the requirements themselves can be more broad and just be greater than a given version. |
Description
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.