-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented HLS stream source as new plugin type. #84
base: master
Are you sure you want to change the base?
Changes from 1 commit
b83f60b
56d8fe4
a0bc25f
77cca1f
144bc18
2142235
7766e66
d4d797b
de44dc1
580335c
65e1a88
369a50b
c71680e
abf5863
63dd3b5
5fc0b66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Generated by Django 5.0.9 on 2024-11-30 13:11 | ||
|
||
import django.db.models.deletion | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('cms', '0035_auto_20230822_2208_squashed_0036_auto_20240311_1028'), | ||
('djangocms_video', '0011_alter_videoplayer_cmsplugin_ptr_and_more'), | ||
] | ||
|
||
operations = [ | ||
migrations.CreateModel( | ||
name='HlsStreamSource', | ||
fields=[ | ||
('cmsplugin_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, related_name='%(app_label)s_%(class)s', serialize=False, to='cms.cmsplugin')), | ||
('hls_source_url', models.CharField(max_length=1024, verbose_name='HLS Source URL')), | ||
], | ||
bases=('cms.cmsplugin',), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Generated by Django 5.0.9 on 2024-11-30 14:56 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('djangocms_video', '0012_hlsstreamsource'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='videoplayer', | ||
name='autoplay', | ||
field=models.BooleanField(default=False, help_text='If enabled, the video will automatically play once the page is loaded. This might not work depending on how the user has configured their browser.', verbose_name='Autoplay'), | ||
), | ||
migrations.AddField( | ||
model_name='videoplayer', | ||
name='show_controls', | ||
field=models.BooleanField(default=True, help_text='If enabled, the video will be shown with Play, Pause and Seek elements that allow the user to control playback.', verbose_name='Show controls'), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,64 @@ | ||||
{% load i18n cms_tags sekizai_tags %} | ||||
|
||||
{% if not disabled %} | ||||
{% with instance.hls_source_url as url %} | ||||
<source id="{{ source_id }}" src="{{ url }}" type="application/x-mpegURL" {{ instance.attributes_str }}> | ||||
{% endwith %} | ||||
{% endif %} | ||||
|
||||
{% addtoblock "js" %} | ||||
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/hls.min.js "></script> | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an extra space here after the hls.min.js. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could that source be configurable and default to the cdn? Alternatively, please add a comment to the README on how to overwrite this template. |
||||
<script> | ||||
// Find first source ending in a .m3u8 path and return its url | ||||
function getHlsUrl(videoElement) { | ||||
const sources = videoElement.querySelectorAll("source"); | ||||
for (source of sources) { | ||||
if (source.src.endsWith("m3u8")) { | ||||
return source.src; | ||||
} | ||||
} | ||||
return null; | ||||
} | ||||
|
||||
function attachHlsStream(sourceElement) { | ||||
if (Hls.isSupported()) { | ||||
let video = sourceElement.parentElement; | ||||
let hls = new Hls(); | ||||
let hlsUrl = getHlsUrl(video); | ||||
hls.loadSource(hlsUrl); | ||||
hls.attachMedia(video); | ||||
hls.on(Hls.Events.MANIFEST_PARSED, function (event, data) { | ||||
console.log('manifest loaded, found ' + data.levels.length + ' quality level',); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Is this left over from debugging? |
||||
video.play(); | ||||
}); | ||||
|
||||
hls.on(Hls.Events.ERROR, function (event, data) { | ||||
if (data.fatal) { | ||||
switch (data.type) { | ||||
case Hls.ErrorTypes.MEDIA_ERROR: | ||||
console.error('fatal media error encountered, try to recover'); | ||||
hls.recoverMediaError(); | ||||
break; | ||||
case Hls.ErrorTypes.NETWORK_ERROR: | ||||
console.error('fatal network error encountered', data); | ||||
break; | ||||
default: | ||||
hls.destroy(); | ||||
break; | ||||
} | ||||
} | ||||
}); | ||||
} else if (video.canPlayType('application/vnd.apple.mpegurl')) { | ||||
video.src = hlsUrl; | ||||
video.addEventListener('loadedmetadata', () => { | ||||
video.play(); | ||||
}); | ||||
} else { | ||||
console.error('HLS is not supported on this browser.'); | ||||
} | ||||
} | ||||
|
||||
attachHlsStream(document.getElementById('{{ source_id }}')); | ||||
|
||||
</script> | ||||
{% endaddtoblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a
URLField
? Can themax_length
fall back to Django's default?