-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.2 #252
base: master
Are you sure you want to change the base?
Release 2.0.2 #252
Conversation
@joshyu Right, we should get this out! |
@joshyu Do you want to add anything to this PR? |
Reviewer's Guide by SourceryThis pull request addresses a bug fix for the 'get_absolute_url' method not found issue when creating new alias and category from the wizard button. It also introduces a new feature by adding search capability in the AliasContent admin, which was migrated from a previous version. Additionally, the version number is updated to 2.0.2, and the changelog is updated accordingly. Sequence diagram for creating new alias and category with wizard buttonsequenceDiagram
actor User
participant WizardButton
participant AliasCreation
participant CategoryCreation
participant URLResolver
User->>WizardButton: Click wizard button
WizardButton->>AliasCreation: Initialize creation
AliasCreation->>URLResolver: get_absolute_url()
Note right of URLResolver: Fixed method resolution
URLResolver-->>AliasCreation: Return URL
AliasCreation-->>User: Display creation form
User->>CategoryCreation: Create category
CategoryCreation->>URLResolver: get_absolute_url()
URLResolver-->>CategoryCreation: Return URL
CategoryCreation-->>User: Display category form
Class diagram for AliasContent admin with search capabilityclassDiagram
class AliasContentAdmin {
+search_fields: list
+list_display: list
+get_search_results()
+get_queryset()
}
class AliasContent {
+name: str
+category: Category
+get_absolute_url()
}
class Category {
+name: str
+get_absolute_url()
}
AliasContentAdmin ..> AliasContent : manages
AliasContent --> Category : belongs to
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joshyu - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add tests for the get_absolute_url bug fix to prevent future regressions. Testing is especially important for bug fixes to ensure the issue doesn't resurface.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
get_absolute_url
method not found while creating new alias and category from wizard button.Checklist
Summary by Sourcery
Release version 2.0.2 with a bug fix for the 'get_absolute_url' method issue and introduce a new search capability in the AliasContent admin.
New Features:
Bug Fixes: