Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.2 #252

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Release 2.0.2 #252

wants to merge 3 commits into from

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Nov 7, 2024

Description

Checklist

Summary by Sourcery

Release version 2.0.2 with a bug fix for the 'get_absolute_url' method issue and introduce a new search capability in the AliasContent admin.

New Features:

  • Added search capability in AliasContent admin, migrating the feature from version 4.0.x.

Bug Fixes:

  • Fixed the 'get_absolute_url' method not found issue when creating new alias and category from the wizard button.

@fsbraun
Copy link
Member

fsbraun commented Nov 7, 2024

@joshyu Right, we should get this out!

@fsbraun
Copy link
Member

fsbraun commented Nov 20, 2024

@joshyu Do you want to add anything to this PR?

@fsbraun fsbraun marked this pull request as ready for review January 7, 2025 07:29
Copy link

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request addresses a bug fix for the 'get_absolute_url' method not found issue when creating new alias and category from the wizard button. It also introduces a new feature by adding search capability in the AliasContent admin, which was migrated from a previous version. Additionally, the version number is updated to 2.0.2, and the changelog is updated accordingly.

Sequence diagram for creating new alias and category with wizard button

sequenceDiagram
    actor User
    participant WizardButton
    participant AliasCreation
    participant CategoryCreation
    participant URLResolver

    User->>WizardButton: Click wizard button
    WizardButton->>AliasCreation: Initialize creation
    AliasCreation->>URLResolver: get_absolute_url()
    Note right of URLResolver: Fixed method resolution
    URLResolver-->>AliasCreation: Return URL
    AliasCreation-->>User: Display creation form

    User->>CategoryCreation: Create category
    CategoryCreation->>URLResolver: get_absolute_url()
    URLResolver-->>CategoryCreation: Return URL
    CategoryCreation-->>User: Display category form
Loading

Class diagram for AliasContent admin with search capability

classDiagram
    class AliasContentAdmin {
        +search_fields: list
        +list_display: list
        +get_search_results()
        +get_queryset()
    }
    class AliasContent {
        +name: str
        +category: Category
        +get_absolute_url()
    }
    class Category {
        +name: str
        +get_absolute_url()
    }

    AliasContentAdmin ..> AliasContent : manages
    AliasContent --> Category : belongs to
Loading

File-Level Changes

Change Details Files
Fixed the 'get_absolute_url' method not found issue when creating new alias and category from the wizard button.
  • Resolved the missing method error during alias creation.
  • Ensured category creation from wizard button works without errors.
djangocms_alias/__init__.py
Added search capability in AliasContent admin, migrating a feature from version 4.0.x. djangocms_alias/__init__.py
Updated version number to 2.0.2 and added changelog entry.
  • Bumped version number from 2.0.1 to 2.0.2.
  • Updated CHANGELOG.rst with new changes.
djangocms_alias/__init__.py
CHANGELOG.rst

Possibly linked issues

  • #0: The PR fixes the error described in the issue by addressing the missing get_absolute_url method during alias/category creation.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joshyu - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add tests for the get_absolute_url bug fix to prevent future regressions. Testing is especially important for bug fixes to ensure the issue doesn't resurface.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants