Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Lots of AST and checker upgrades ⚡ #207

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Lots of AST and checker upgrades ⚡ #207

wants to merge 21 commits into from

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Feb 26, 2023

image

@jmackie jmackie changed the title Lots of AST and checker upgrades Lots of AST and checker upgrades ⚡ Feb 26, 2023
@jmackie jmackie linked an issue Feb 26, 2023 that may be closed by this pull request
Use more compact types #143
Open
4 tasks
@jmackie jmackie force-pushed the checker-upgrades branch 2 times, most recently from 285df97 to cadab23 Compare February 26, 2023 16:20
Jordan Mackie added 19 commits March 11, 2023 20:20
Use smol_str for CST tokens
e22d870
Add a standalone pattern parser
6ac393f
Implement into miette::SourceSpan for our Span type
6a1ecb4
Use smol_str in the AST
db5c939
Use nonempty crate instead of non-empty-vec in ditto-ast
2d98f31
Drop the Argument enum from the AST
5cedf5a 
I added this originally in anticipation of doing some Scala-style
partial application syntax. But I don't think I wanna do that now.
Move AST patterns to their own module
eb794df
Split out AST utils module
91e573c
Track source location where AST variables were introduced
a6d15d9
Add an ast::RecordFields type alias
66157a9
Drop ast::Type::set_type and have get_type return a reference
95c739e
Add is_rigid field to type variables for better unification logic
2b94977
Move review comment out of doc comment
77bc9ca
Make ast::Type::unalias move self
3e2cfa1
Drop ast::Type::anonymize function
9ae9a80 
Cos it was a hack.
Drop AST type rendering tests as that's being covered plenty
5d76544
Note to self: use something smaller than usize for Var?
7bd5e1e
Add get_span method to ast::Pattern
d720f0d
Remove unalias method from ast::Type in favour of ad-hoc methods
3569d1d
@jmackie jmackie force-pushed the checker-upgrades branch 2 times, most recently from 633c875 to 5a799d0 Compare March 14, 2023 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use more compact types
1 participant
@jmackie