-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kwargs patching #313
Fix kwargs patching #313
Conversation
Also it looks like in Ruby 3.2/3.3 prepend works with the same speed as alias
|
I think I am fine with this ... crazy that 2.7 was EOL a year ago! CI is failing though, can you have a look? |
Thank you for review! Looks like CI is failing for a long time, it is connected with
Also ar_70.gemfile actually didn't test 7.0, but 6.0. Fixed this as well
|
@@ -0,0 +1 @@ | |||
--ignore-unrecognized-cops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for compatibility with older versions of rubocop-discourse
This is certainly a radical change (deliberately breaking releases prior to Ruby 3.0) , but I am going to accept it @tgxworld / @davidtaylorhq it is more correct and probably something we should pull into method profiler on Discourse. I guess at the end of the day people that need Ruby 2 support can just install earlier gems. Thanks @simpl1g |
Fixes #312