Refactor unpacker #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow, my repository is a bit messed up... I will wait for other PRs (#5 and #6) to be merged first, before cloning a fresh copy and re-submit this PR for refactoring the Unpacker. What's wrong here is that somehow the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the Unpacker class: by adding a
__del__method instances can ensure that the temporary folder gets deleted without the need to explicitly call thedeletemethod. Note that it is my intention to remove thedeletemethod in a later PR. For the time being, thedeletemethod is however kept, as thedfu.pycommand line tool currently still uses it (see #5 for the refactoring ofdfu.py).