mark multimedia export as location safe #35378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Ticket: https://dimagi.atlassian.net/browse/SAAS-12925
Location-restricted user is not able to export multimedia because the view to export multimedia doesn't have @location_safe decorator. The view to export multimedia will use ExpandedMobileWorkerFilter to limit its access only to the assigned locations.
Context about
@location_safedecorator here.This ticket is similar to https://dimagi.atlassian.net/browse/HI-208
Feature Flag
No
Safety Assurance
Safety story
Test on staging: setting up a location restricted web user who is able to download multimedia, and the multimedia is only restricted to the location that he have access to.
Automated test coverage
QA Plan
Rollback instructions
Labels & Review