Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webpack] Migrated translations app #35374

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[webpack] Migrated translations app #35374

merged 2 commits into from
Nov 15, 2024

Conversation

orangejenny
Copy link
Contributor

Technical Summary

This one is trivial.

Feature Flag

Transifex integration

Safety Assurance

Safety story

Tested locally. This app doesn't have. many dependencies and is barely used.

Automated test coverage

doubt it

QA Plan

no

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Nov 15, 2024
@orangejenny orangejenny merged commit 6cc33a4 into master Nov 15, 2024
12 checks passed
@orangejenny orangejenny deleted the jls/webpack-translations-app branch November 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

@gherceg gherceg Awaiting requested review from gherceg

@biyeun biyeun Awaiting requested review from biyeun biyeun is a code owner

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangejenny @millerdev