Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B5] Bootstrap 5 support for datatables #33815

Merged
merged 4 commits into from
Nov 30, 2023
Merged

[B5] Bootstrap 5 support for datatables #33815

merged 4 commits into from
Nov 30, 2023

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented Nov 30, 2023

Technical Summary

This PR introduces two bootstrap5 related datatables javscript dependencies

  • datatables.net-b5, which is the bootstrap5 related styling for datatables
  • datatables.net-fixedcolumns-b5, which is the bootstrap 5 version of the fixedColumns datatables extension that we use in reports

An overview of this is included in the styleguide work

This PR also introduces style changes to datatables.scss needed for bootstrap 5 upgrade and updates to paths in the bootstrap 5 version of requirejs_config.js

Safety Assurance

Safety story

isolated only to bootstrap 5 changes. none of which is being used in production on critical user workflows at this time. changes can be previewed in the styleguide which is on staging

Automated test coverage

diffs are covered

QA Plan

not needed

Rollback instructions

leaving unchecked due to bootstrap 5 diffs adding rollback complications. it's generally fine to rollback if done immediately, but if a long time has passed only the non-diff commits can be rolled back without causing conflicts.

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@biyeun biyeun added product/invisible Change has no end-user visible impact dependencies/javascript Change in javascript dependency. labels Nov 30, 2023
@biyeun biyeun requested review from a team and orangejenny as code owners November 30, 2023 11:13
@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Nov 30, 2023
@biyeun biyeun changed the title Bmb/b5 datatables [B5] Bootstrap 5 support for datatables Nov 30, 2023
@biyeun biyeun merged commit 340fd62 into master Nov 30, 2023
10 of 12 checks passed
@biyeun biyeun deleted the bmb/b5-datatables branch November 30, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies/javascript Change in javascript dependency. dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants