[B5] Bootstrap 5 support for datatables #33815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This PR introduces two bootstrap5 related datatables javscript dependencies
datatables.net-b5
, which is the bootstrap5 related styling for datatablesdatatables.net-fixedcolumns-b5
, which is the bootstrap 5 version of thefixedColumns
datatables extension that we use in reportsAn overview of this is included in the styleguide work
This PR also introduces style changes to
datatables.scss
needed for bootstrap 5 upgrade and updates to paths in the bootstrap 5 version ofrequirejs_config.js
Safety Assurance
Safety story
isolated only to bootstrap 5 changes. none of which is being used in production on critical user workflows at this time. changes can be previewed in the styleguide which is on staging
Automated test coverage
diffs are covered
QA Plan
not needed
Rollback instructions
leaving unchecked due to bootstrap 5 diffs adding rollback complications. it's generally fine to rollback if done immediately, but if a long time has passed only the non-diff commits can be rolled back without causing conflicts.
Labels & Review