Move deduplication pillow from xform to case processor #33808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Deduplication processing was triggered through the xform pillow. Unfortunately, this creates race condition headaches, as detecting duplicates relies on inspecting the elasticsearch case index -- and that index is only updated by the case pillow. Moving the logic avoids this headache.
Associated ticket: https://dimagi-dev.atlassian.net/browse/SAAS-15054
Safety Assurance
Safety story
I've run the case processor locally to ensure that the deduplication processor is picking up case submissions.
Automated test coverage
A few new tests suites were added or expanded to verify that we can filter case changes to only a specific affected case.
QA Plan
No QA planned.
Rollback instructions
Labels & Review