Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deduplication pillow from xform to case processor #33808

Merged

Conversation

mjriley
Copy link
Contributor

@mjriley mjriley commented Nov 29, 2023

Technical Summary

Deduplication processing was triggered through the xform pillow. Unfortunately, this creates race condition headaches, as detecting duplicates relies on inspecting the elasticsearch case index -- and that index is only updated by the case pillow. Moving the logic avoids this headache.

Associated ticket: https://dimagi-dev.atlassian.net/browse/SAAS-15054

Safety Assurance

Safety story

I've run the case processor locally to ensure that the deduplication processor is picking up case submissions.

Automated test coverage

A few new tests suites were added or expanded to verify that we can filter case changes to only a specific affected case.

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@mjriley mjriley added the product/invisible Change has no end-user visible impact label Nov 29, 2023
@mjriley mjriley merged commit 2f6871b into mjr/add-change-meta-context Dec 5, 2023
9 checks passed
@mjriley mjriley deleted the mjr/move-dedupe-processor-to-case branch December 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants