Skip to content

Commit

Permalink
Merge pull request #33515 from dimagi/bmb/b5-migration-spec-update
Browse files Browse the repository at this point in the history
[B5] Update migration script spec for bootstrap 5 migraiton
  • Loading branch information
biyeun authored Sep 22, 2023
2 parents 49c1142 + 2d8590c commit f62561d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
`form-group` has been dropped. Use grid utilities instead.

- note that `<label>` elements now require `form-label` class
Since we are opting for vertical forms (where the label is directly above the field),
the replacement for `form-group` is most likely just `mb-3` and the child `div` with a column
class surrounding the `form-control` element can be removed, along with the column class that
appears with the `<label>` `class` attribute. Most often, the `<label>` `class` only needs to
contain the `form-label` class now.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
"btn-danger": "btn-outline-danger",
"btn-xs": "btn-sm",
"navbar-default": "navbar-light",
"inline-block": "d-inline-block"
"inline-block": "d-inline-block",
"control-label": "form-label"
},
"numbered_css_renames": {
"col-xl-<num>": "col-xxl-<num>",
Expand Down

0 comments on commit f62561d

Please sign in to comment.