-
-
Notifications
You must be signed in to change notification settings - Fork 217
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #33515 from dimagi/bmb/b5-migration-spec-update
[B5] Update migration script spec for bootstrap 5 migraiton
- Loading branch information
Showing
2 changed files
with
7 additions
and
2 deletions.
There are no files selected for viewing
6 changes: 5 additions & 1 deletion
6
corehq/apps/hqwebapp/utils/bootstrap/changes_guide/form-group.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
`form-group` has been dropped. Use grid utilities instead. | ||
|
||
- note that `<label>` elements now require `form-label` class | ||
Since we are opting for vertical forms (where the label is directly above the field), | ||
the replacement for `form-group` is most likely just `mb-3` and the child `div` with a column | ||
class surrounding the `form-control` element can be removed, along with the column class that | ||
appears with the `<label>` `class` attribute. Most often, the `<label>` `class` only needs to | ||
contain the `form-label` class now. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters