-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCCT-533- ui icon changes as per the new figma #2892
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes looks fine.
- Is it possible to add screenshots in the PR on how it looks in the app ?
- Is it possible to use vector drawables insted of png to take into account different screen densities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-dimagi can you include a screenshot of the full Home screen, with the Incomplete
and Saved
buttons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. It's a good idea to add a release note to any big changes like this and also tick the safety checklist in PR template.
@damagatchi retest this please |
@pm-dimagi I'm seeing a different design (different icons, different icon sizes) on the final assets provided to SaaS here: https://www.figma.com/design/UWjp1wRNAO0o9q2llwDKMc/CommCare-Cosmetic-Changes-Post-Nov-'22Rebrand?node-id=111-2&node-type=canvas Can you confirm where you got these icons and icon sizes? I want to make sure we are working on off of the same assets. |
https://dimagi.atlassian.net/browse/CCCT-533
The ui changes
-- Icon update
-- commcare logo update
Safety Assurance
Automated test coverage
Safety story
Release Note: Updated Iconography and Logo