Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environments #850

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Environments #850

merged 10 commits into from
Dec 18, 2024

Conversation

andreasphil
Copy link
Member

@andreasphil andreasphil commented Dec 17, 2024

This PR makes several changes to our frontend build setup:

  • Moved Vitest related config to its own file to keep the Vite configuration more compact
  • Run E2E tests against the production application rather than the dev server
  • Add a function to infer the environment during runtime so it doesn't need to be statically defined during build*
  • Conditionally initialize Sentry reporting only for permanent environments (production, staging, UAT)
  • Replace the hardcoded staging environment in the Sentry config with the inferred environment
  • Use the Sentry Vite plugin only for production builds and only if it is properly configured
  • Along with some minor cleanup.

Todo: Double check the Sentry setup for the backend too. That's probably already fine though (59a4d2b)

(*) This is currently just a bunch of heuristics and not super pretty, but I encapsulated it in a function so we can easily replace that once we have a better solution.

@andreasphil andreasphil marked this pull request as ready for review December 18, 2024 07:29
@andreasphil andreasphil merged commit 3e9fe3d into main Dec 18, 2024
26 checks passed
@andreasphil andreasphil deleted the envs branch December 18, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant