Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOV feat: change anrede text field to a dropdown #1592

Merged
merged 7 commits into from
Jan 10, 2025
Merged

ZOV feat: change anrede text field to a dropdown #1592

merged 7 commits into from
Jan 10, 2025

Conversation

m0dh4x
Copy link
Contributor

@m0dh4x m0dh4x commented Jan 10, 2025 •
edited
Loading

we changed the current textfield for "Anrede" to a dropdown with the following options

  • keine Angabe -> default -> results in display empty string
  • Herr
  • Frau

@m0dh4x m0dh4x added the ZOV label Jan 10, 2025
@m0dh4x m0dh4x marked this pull request as draft January 10, 2025 08:36
chohner
chohner approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@chohner chohner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm?

app/domains/geldEinklagen/formular/context.ts Outdated Show resolved Hide resolved
app/domains/beratungshilfe/formular/persoenlicheDaten/context.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@m0dh4x m0dh4x marked this pull request as ready for review January 10, 2025 13:08
@m0dh4x m0dh4x merged commit 9546f3d into main Jan 10, 2025
21 checks passed
@m0dh4x m0dh4x deleted the feat/select-for-salutation branch January 10, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chohner chohner chohner approved these changes

Assignees
No one assigned
Labels
ZOV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0dh4x @chohner