fix: only add attachments in pkh wertsachen when needed (#1344)

digitalservicebund · Oct 24, 2024 · d8aa765 · d8aa765
1 parent 31394cf
commit d8aa765
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/app/services/pdf/prozesskostenhilfe/G_eigentum.ts b/app/services/pdf/prozesskostenhilfe/G_eigentum.ts
@@ -119,7 +119,11 @@ export const fillBargeldOderWertgegenstaende: PkhPdfFillFunction = ({
     : [];
   const hasBargeldOderWertgegenstaende =
     hasWertsache === "yes" || hasGeldanlage === "yes";
-  pdfValues.nein_43.value = !hasBargeldOderWertgegenstaende;
+  if (!hasBargeldOderWertgegenstaende) {
+    pdfValues.nein_43.value = true;
+    return { pdfValues };
+  }
+
   pdfValues.ja_39.value = hasBargeldOderWertgegenstaende;
   if (bargeld.length + (wertsachen?.length ?? 0) === 1) {
     const singleBargeld = bargeld[0];

diff --git a/app/services/pdf/prozesskostenhilfe/__test__/G_eigentum.test.ts b/app/services/pdf/prozesskostenhilfe/__test__/G_eigentum.test.ts
@@ -246,6 +246,18 @@ describe("G_eigentum", () => {
   });
 
   describe("fillBargeldOderWertgegenstaende", () => {
+    it("should not mention attachments when none exist", () => {
+      const { pdfValues, attachment } = fillBargeldOderWertgegenstaende({
+        userData: {
+          hasBankkonto: "yes",
+        },
+        pdfValues: pdfParams,
+      });
+      expect(
+        pdfValues.artdesKontosKontoinhaberKreditinstitut.value,
+      ).toBeUndefined();
+      expect(attachment?.length).toBeUndefined();
+    });
     it("should indicate if the user has bargeld or wertgegenstaende", () => {
       let { pdfValues } = fillBargeldOderWertgegenstaende({
         userData: {