Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-print css class so that elements can be discluded from printed reports #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Sep 30, 2024

Features:

  • Adds the ability to hide error pop ups from printed reports.
  • The should help to ensure the report conforms to w3c report guidelines

@aljones15 aljones15 self-assigned this Sep 30, 2024
@aljones15 aljones15 requested a review from davidlehn September 30, 2024 19:30
@aljones15 aljones15 marked this pull request as ready for review September 30, 2024 19:37
@@ -37,4 +37,9 @@
outline: thin #c45e0a solid;
}

@media print {
.no-print, .no-print * {
Copy link
Member

@davidlehn davidlehn Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do .no-print and .no-print * do something different in this case? I would have thought .no-print alone would cover descendants too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlehn do not currently have cycles to deal with this. I believe the * is there to cover cases where descendants of an element get outside of the normal dom flow such as with a z-index or static position. The important also kind of worries me, but I believe I have seen things go to display: none with descendants go to display: block and the important would cover that case. This PR is not urgent.

Adding a To Do:

  • @aljones15 needs to test what happens on hover with permutations of display prop in descendants with z-indexes outside the normal doc flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants