Do not include matrices without rows. #50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljones15
force-pushed
the
do-not-show-empty-results
branch
from
2eb0e77 to
4f529c2
Compare
BigBlueHat
requested changes
Oct 7, 2024
There was a problem hiding this comment.
I liked your suggestion of showing a "no results" message when there's an empty matrix. That said, we should think through the currently known situations of empty matrices to be sure that "no results" is the right text to display in all cases--it should be...but not sure when/where this appears currently.
|
@BigBlueHat changed this to draft until I can show the is empty notification inside the matrix template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: