Student details table #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etailsTable component in MainCard of students/index. Pagination and sort states included but not being used as api is not developed yet.
kssampson
had a problem deploying
to
production
GitHub Actions
Failure
…to null in api/cePlanService and api/ceSessionService
|
Visit the preview URL for this PR (updated for commit 71e7cb0): https://culturous-exchange--pr1-studentdetailstable-1rdiqcys.web.app (expires Tue, 24 Dec 2024 00:03:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: adcc28caa9b7c1d3b1670a080fce5f1f054a3a92 |
jnakaso
reviewed
Dec 16, 2024
src/pages/students/index.tsx
Outdated
| @@ -13,6 +14,7 @@ const StudentsPage: React.FC = () => { | |||
| <Typography>List/Table of students enrolled in the program.</Typography> | |||
There was a problem hiding this comment.
Let's remove pseudo code as features are implemented.
jnakaso
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This a basic data table component with name, age, and country. I used the existing Student type and service and added a hard coded age property to the two examples. The component is rendered in the MainCard of student/index.tsx
I used the pages/sessions/SessionsTable.tsx as guide for style and the implementation is basically that minus the refresh.
The pagination and sorting are kept as 'server' though it's not set up yet of course -- just following suit with that model for tables.
What type of PR is this? (check all applicable)
Related Tickets & Documents
https://das-culturousexchange-team.atlassian.net/browse/SCRUM-11
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well as any relevant images for UI changes.