Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pool size and max overflow for timeout issue #338

Merged
merged 9 commits into from
Jan 6, 2025

Conversation

ssadhu-sl
Copy link
Contributor

@ssadhu-sl ssadhu-sl commented Dec 17, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

We are getting a lot of TimeoutError errors due to 'QueuePool limit of size 5 overflow 10 reached'. For this, we have increased the pool size and the max_overflow size.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: just some config changes
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@cpcundill
Copy link
Contributor

Looks good - will try applying in Staging and let you know.

Copy link
Contributor

@cpcundill cpcundill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our Slack conversation, we'll need more work on this to handle the sessions created via Fast API

@ssadhu-sl ssadhu-sl marked this pull request as draft December 19, 2024 13:57
@ssadhu-sl ssadhu-sl changed the title Adding pool size and max overflow for timeout issue [DO NOT MERGE] Adding pool size and max overflow for timeout issue Dec 19, 2024
Copy link
Contributor

@cpcundill cpcundill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to proceed having seen it successfully deployed in the dev environment

@ssadhu-sl ssadhu-sl marked this pull request as ready for review January 3, 2025 15:17
@ssadhu-sl ssadhu-sl changed the title [DO NOT MERGE] Adding pool size and max overflow for timeout issue Adding pool size and max overflow for timeout issue Jan 6, 2025
@ssadhu-sl ssadhu-sl merged commit 7cd04f1 into main Jan 6, 2025
4 checks passed
@ssadhu-sl ssadhu-sl deleted the fix/timeout_issue branch January 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants