Switch from pkg_resources to packaging for parsing versions #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after conda-forge/morfeus-ml-feedstock#7 I was still getting a CI failure and realized I've seen this problem before. See mu-editor/mu#2485 for a summary. It seems like adding
setuptools
to the recipe should have worked, but it is simply safer to switch topackaging
. I think it has something to do withsetuptools
only being present in the build phase, not the run phase, but if you're just doing things locally in a venv,setuptools
will still be present.It makes more sense to me to add
packaging
as a runtime dependency thansetuptools
. After this, there would need to be a new release and the feedstock updated for both the new version and runtime dependency.