Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pkg_resources to packaging for parsing versions #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berquist
Copy link

@berquist berquist commented Jan 1, 2025

Even after conda-forge/morfeus-ml-feedstock#7 I was still getting a CI failure and realized I've seen this problem before. See mu-editor/mu#2485 for a summary. It seems like adding setuptools to the recipe should have worked, but it is simply safer to switch to packaging. I think it has something to do with setuptools only being present in the build phase, not the run phase, but if you're just doing things locally in a venv, setuptools will still be present.

It makes more sense to me to add packaging as a runtime dependency than setuptools. After this, there would need to be a new release and the feedstock updated for both the new version and runtime dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant