README.md improvement for Open3D library installation #4
Conversation
README.md
Outdated
| Expand-Archive -DestinationPath 'C:\Users\<Your user name>\Downloads' -LiteralPath "C:\Users\<Your user name>\Downloads\open3d-devel-windows-amd64-0.18.0.zip" | ||
| Move-Item -LiteralPath 'C:\Users\<Your user name>\Downloads\open3d-devel-windows-amd64-0.18.0\*' -Destination 'C:\Program Files\Open3D\' | ||
| rmdir 'C:\Users\<Your user name>\Downloads\open3d-devel-windows-amd64-0.18.0\' |
There was a problem hiding this comment.
With what you propose it will work with the current CMakeLists.txt file of DiffCheck because you probably already compiled everything before for Open3d (I remember you told me that you compiled). In this way we are using precompiled binaries and not compiled from source. It's safer for now to keep the compiled from source. But well spotted for the error in the link.
There was a problem hiding this comment.
Ok ! I probably made an error when compiling from source, then. For me unzipping the prebuilt binaries was the only way to make it work, that's why I made this PR. Thanks for the review !
There was a problem hiding this comment.
No thanks for letting me know. You made me think now that we should do this better.. I am opening a PR for refactoring the cmake project.
The thing is that you should erase all the Open3D install files of your previous build before recompiling from source.
I'll keep you posted for the refactoring of the CMake project.
|
I am merging but do not hesitate to open new branches to propose changes for the installation @DamienGilliard ! |
| @@ -72,7 +72,7 @@ To build and test the project, follow the following steps: | |||
| ```terminal | |||
| cmake/config.bat | |||
| cmake/build.bat | |||
| ./build/bin/diffCheckApp.exe <-- for prototyping | |||
| ./build/bin/Release/diffCheckApp.exe <-- for prototyping | |||
Hi @9and3 , I tried to install Open3D following the instructions on the README.md but the files behind the link contains pre-built binaries and thus no CMakeLists.txt and cannot be built from source (and after building from source from the latest release I got linker issues ). With the changes proposed, the pre-built binaries are placed at the right place and link properly.