Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing signed distance for cloud-to-cloud #32

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

9and3
Copy link
Contributor

@9and3 9and3 commented Jun 19, 2024

As suggested by @eleniv3d in #31 I removed the signed distance from cloud-to-cloud distance since it only makes sense for mesh-cloud computation (water tight and distinction between inside/outside). The use case is changed as such:

#! python3

import diffCheck
from diffCheck import diffcheck_bindings
import diffCheck.df_cvt_bindings
import diffCheck.df_geometries


df_mesh = diffCheck.df_cvt_bindings.cvt_rhmesh_2_dfmesh(i_rh_mesh)
df_cloud = diffCheck.df_cvt_bindings.cvt_rhcloud_2_dfcloud(i_rh_cloud)

mesh_to_cloud_distances = df_mesh.compute_distance(target_cloud=df_cloud, is_abs=True)
print(f"Max distance mesh-to-cloud: {max(mesh_to_cloud_distances)}")
print(f"Min distance mesh-to-cloud: {min(mesh_to_cloud_distances)}")

cloud_to_cloud_distances = df_cloud.compute_distance(target_cloud=df_cloud)
print(f"Max distance cloud-to-cloud: {max(cloud_to_cloud_distances)}")
print(f"Min distance cloud-to-cloud: {min(cloud_to_cloud_distances)}")

@9and3 9and3 added the bug Something isn't working label Jun 19, 2024
@9and3 9and3 requested a review from eleniv3d June 19, 2024 21:20
@mariklad mariklad merged commit 1f316fc into distance_calculation_visualisation Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants