-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend segmentation components #23
Merged
Merged
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
ac0211d
WIP-ADD DFSegmentation.cc and hh
DamienGilliard ff4a3a4
FIX: target include directories for boost
DamienGilliard a1ce0f3
ADD: cilantro submodule
DamienGilliard b75aa99
WIP-ADD: GetCenterPoint() to point cloud objects
DamienGilliard 5ae1b17
WIP-ADD: SegmentationPointCloud static method using cilantro
DamienGilliard c021636
WIP-FIX: numpy array for colors in rh to df point cloud conversion
DamienGilliard b1a74b7
WIP-ADD: scan_segmentation component
DamienGilliard 6da8b98
WIP: extent bindings for segmentation and GetCenterPoint method
DamienGilliard a1e36fa
WIP-FIX: OG cilantro submodule deleted
DamienGilliard 279a437
WIP-FIX: added diffCheck fork of cilantro as submodule
DamienGilliard 651eea6
FIX: update CMakeLists.txt for new submodule
DamienGilliard 0804de2
FIX: submodule with https link instead of ssh
DamienGilliard 970e13d
FIX: update the submodule for config.hpp fix
DamienGilliard 0f3009d
CAP: segmentation function well implemented and documented
DamienGilliard 1861891
CAP-fix:typo in segmentation parameter order
DamienGilliard b6427b8
FIX: update component code in code.py
DamienGilliard 6c95c01
FIX: parameters passed to segmentation function in code.py
DamienGilliard 1902f16
FIX: code.py
DamienGilliard 47448fa
FIX: mismatch in parameters for plugin code + conversion DFPointCloud…
DamienGilliard d1de3e8
FIX: naming of the cilantro wrap function changed to SmoothSegmentation
DamienGilliard f6fd4e9
WIP-ADD: AssociateSegments function created
DamienGilliard 1adc9de
FIX: renaming of cilantro segmentation wrap following review
DamienGilliard e320d64
Merge branch 'semantic_segmentation' of github.com:diffCheckOrg/diffC…
DamienGilliard 8bff20f
WIP: creation of the aggregatino function that associates point cloud…
DamienGilliard 58daa2a
FIX-MERGE: bringing the assembly/beam structure to the segmentation m…
9and3 e0b531d
ADD: small cmake utilitiy for dev convinience
9and3 3940e23
ADD: normal estimation to dfcloud
9and3 acc643c
TEMP: working on colored cluster + visualizer
9and3 08b09db
WIP: adding coloring for cloud and clustering
9and3 3eb0fc5
CAP: refactored backend for segmeentations and normal estimations
9and3 c9277c7
WIP: segmentation now using triangle faces + small fixes
DamienGilliard 2010cb0
ADD: egg link to gitignore
9and3 73888c9
ADD-MILESTONE: wraps for normal estimation + segmentation
9and3 af0c8b8
commit before rebase
DamienGilliard b24e67f
WIP: commit before pull
DamienGilliard 50cdc17
WIP: rebased onto 'segmentation' branch
DamienGilliard 2503cfb
Merge branch 'semantic_segmentation' of github.com:diffCheckOrg/diffC…
DamienGilliard c8e9ad5
CAP: AssociateClusters function implemented in the back-end
DamienGilliard 032f428
UPDATE: CleanUnassociatedClusters method added, and PR remarks included
DamienGilliard b688ec9
UPDATE-WIP: add IsPointOnFace function, and angle threshold parameter…
DamienGilliard 111c484
UPDATE: adding some preventive checks to the methods in DFSegmentation
DamienGilliard 38c12c5
CAP: Association functions implemented, defensive checks added, and g…
DamienGilliard 060464a
Merge pull request #33 from diffCheckOrg/semantic_segmentation
9and3 701f47d
FIX: correcting names in bindings + values default
9and3 d2905ff
mERGE-FIX: Merge branch 'test_suite' into segmentation for fixing cma…
9and3 94bdf5a
FIX: frix from main for colors convertion
9and3 304d2ba
WIP: working on example
9and3 6701304
Merge branch 'main' into segmentation
9and3 b7cd47d
FIX: DFFace to mesh method added
9and3 1dba340
WIP: working on wrap cad segmentator integration
9and3 673b159
FIX-TYPO
9and3 6c3dda2
ADD: temp icon
9and3 2385589
ADD: metadata for cad segmentator added
9and3 a22ecf4
UPDATE: association criterion now with projection, and no unwanted de…
DamienGilliard e8f7f0c
UPDATE: new meshing parameters for brepface to mesh conversion
DamienGilliard 8cca66a
UPDATE-FIX: segmentation methods more robust, and IsPointOnFace metho…
DamienGilliard e3d2f97
FIX: removed commented-out IsPointOnFace method in DFSegmentation cla…
DamienGilliard 0805cb4
UPDATE: CAD_segmentator code.py updated following changes to c++ side
DamienGilliard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"class_name" : "PinholeCameraParameters", | ||
"extrinsic" : | ||
[ | ||
0.78518600604290978, | ||
-0.4688467948733368, | ||
0.4045560762754441, | ||
0.0, | ||
-0.61432912235314374, | ||
-0.67201447960085037, | ||
0.41351695084435719, | ||
0.0, | ||
0.077991444038432445, | ||
-0.57321830234544802, | ||
-0.81568260525341763, | ||
0.0, | ||
1416.8243739322577, | ||
908.62300697364822, | ||
1063.1264987715035, | ||
1.0 | ||
], | ||
"intrinsic" : | ||
{ | ||
"height" : 800, | ||
"intrinsic_matrix" : | ||
[ | ||
692.82032302755101, | ||
0.0, | ||
0.0, | ||
0.0, | ||
692.82032302755101, | ||
0.0, | ||
499.5, | ||
399.5, | ||
1.0 | ||
], | ||
"width" : 1000 | ||
}, | ||
"version_major" : 1, | ||
"version_minor" : 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"class_name" : "PinholeCameraParameters", | ||
"extrinsic" : | ||
[ | ||
0.76239913059926834, | ||
-0.422274821893041, | ||
0.49033818988192268, | ||
0.0, | ||
-0.54132130094127906, | ||
-0.00099240450767756894, | ||
0.8408152378974435, | ||
0.0, | ||
-0.35456849099817256, | ||
-0.90646731321570218, | ||
-0.22934296427574399, | ||
0.0, | ||
1550.6223360557265, | ||
197.24908733414611, | ||
336.92784140962624, | ||
1.0 | ||
], | ||
"intrinsic" : | ||
{ | ||
"height" : 800, | ||
"intrinsic_matrix" : | ||
[ | ||
692.82032302755101, | ||
0.0, | ||
0.0, | ||
0.0, | ||
692.82032302755101, | ||
0.0, | ||
499.5, | ||
399.5, | ||
1.0 | ||
], | ||
"width" : 1000 | ||
}, | ||
"version_major" : 1, | ||
"version_minor" : 0 | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.\cmake\build.bat ; if ($?) { .\build\bin\Release\diffCheckApp.exe } |
Submodule eigen
updated
from 02bcf9 to d791d4
Submodule submodule-cilantro
added at
4c9fa6
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe here we could add the function to test if a point is on a mesh face @DamienGilliard ? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@9and3 It's there !