Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in point association #139

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

DamienGilliard
Copy link
Collaborator

@DamienGilliard DamienGilliard commented Nov 6, 2024

This PR concerns improvements in the point association and an adaptation in the angle threshold for considering a segment "associable".

It is minor in code, but quite visible in results

Change n° 1

DFMesh::IsPointOnFace():
* The coordinates u, v on the triangle face are not really barycentric coordinates. The comment in the code has been adapted.
* Given the nature of u, v, a small deviation can lead to large difference in 3D coordinates. For that reason, the association threshold is divided by 100 for more precise manipulation

Change n° 2

DFSegmentation::AssociateClustersToMesh() and CleanUnassociatedClusters():
* The angle between the face normal and the line that joins the face center and the cluster center is taken into account. Ideally this angle must be very close or equal to 90°. A condition states that the cosine of this angle must be smaller than the angle threshold.

@DamienGilliard DamienGilliard marked this pull request as draft November 6, 2024 20:50
@DamienGilliard DamienGilliard self-assigned this Nov 6, 2024
@DamienGilliard DamienGilliard added enhancement New feature or request backend labels Nov 6, 2024
@9and3
Copy link
Contributor

9and3 commented Nov 11, 2024

Hello @DamienGilliard ! Thanks for this PR, I see it is still a draft, can we merge this as a temporary patch already? Thanks!

@DamienGilliard
Copy link
Collaborator Author

I got a bit lazy. I'll document it before 12:00 today and then you merge ?
Sorry I should have done that last week.

@DamienGilliard DamienGilliard marked this pull request as ready for review November 11, 2024 11:42
Copy link
Contributor

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me to merge this little patch. I still belive the python segmentators need some refactoring but we'll do this in another PR! Thanks for this one!

@9and3 9and3 merged commit b5223c8 into main Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants