Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns improvements in the point association and an adaptation in the angle threshold for considering a segment "associable".
It is minor in code, but quite visible in results
Change n° 1
DFMesh::IsPointOnFace()
:* The coordinates u, v on the triangle face are not really barycentric coordinates. The comment in the code has been adapted.
* Given the nature of u, v, a small deviation can lead to large difference in 3D coordinates. For that reason, the association threshold is divided by 100 for more precise manipulation
Change n° 2
DFSegmentation::AssociateClustersToMesh()
andCleanUnassociatedClusters()
:* The angle between the face normal and the line that joins the face center and the cluster center is taken into account. Ideally this angle must be very close or equal to 90°. A condition states that the cosine of this angle must be smaller than the angle threshold.