Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refined registration #10

Closed
wants to merge 153 commits into from
Closed

refined registration #10

wants to merge 153 commits into from

Conversation

DamienGilliard
Copy link
Collaborator

This PR contains the development of refined registration methods

DamienGilliard and others added 30 commits March 29, 2024 23:03
@DamienGilliard
WIP-ADD: Fast Global Registration added
07667a4
@DamienGilliard
WIP: Correction for naming convention
f35e0df
@DamienGilliard
WIP-ADD: FastGlobalRegistrationBasedOnFeatureCorrespondence method ad…
bf1ccc6 
…ded to registration class
@DamienGilliard
ADD-WIP: Point to point error calculation method added to Registratio…
7007eab 
…n class
@9and3
FIRST commit
d9f7014
@9and3
ADD: add dataflow diag
492c72d
@9and3
ADD: gitignore for python
1a661c6
@9and3
WIP-ADD: basic draft for python structure in gh
0fe9c50
@9and3
WIP-CAP: working xml dumper for diffcheck ghcomponent - missing joint…
2041732 
… detect
@9and3
FIX: timestamp for file working
ac89bd5
@9and3
FIX: minors and typos
3cc8d04
@9and3
FIX: better button for output component
17364e1
@9and3
WIP: testing componentizer action
9db6763
@9and3
WIP: testing componentizer action x2
44748b2
@9and3
WIP: testing action componentizer
4ccb8cc
@9and3
WIP: using default compas action
27c2dd6
@9and3
WIP: using default compas action x2
f9535a2
@9and3
FIX-CAP: component fixed + componentizer
c3e7ee4
@9and3
FIX: correct categories for metadata componentizer
05afa78
@9and3
FIX-WIP: solving problem with metadata componentizer
6ef7bf1
@9and3
ADD: badge to readme for pypi
8068233
@9and3
WIP-FLASH: basic reverse transform, working on detection
1d72a73
@DamienGilliard
WIP-ADD: Registrations tested and produce csv for error and computati…
0e11970 
…on time. python plotter added
@9and3
WIP-FLASH: need to clean and add loop but joint detector in place
88c0882
@9and3
CAP: proper first draft of joint detector
096cadf
@9and3
FIX: updated component code
50b2786
@9and3
WIP: working on solving tenon-mortise
d8eefa6
@9and3
WIP: almost working conversion dface to brep rhino
9b4b8a9
@9and3
WIP-CAP: solved DFace-brep convertion, adapting exporting new structu…
69262c8 
…re now
@9and3
ADD: meshing DFace convertion
93a5a0a
9and3 and others added 24 commits May 2, 2024 10:31
@9and3 @DamienGilliard
FIX: udpated correct istructions README
b6e0072
@9and3 @DamienGilliard
FIX: udpated correct istructions README x2
c6f5c21
@9and3 @DamienGilliard
CAP: added logging
b1f400c
@9and3 @DamienGilliard
FIX: minor const for logger
b0d4068
@DamienGilliard
ADD: refinedRegistration files to create PR
f44069d
@DamienGilliard
WIP: Open3d ICP added to registration class
19bf804
@DamienGilliard
WIP: refined registrations implemented
3e9d752
@DamienGilliard
ADD: refinedRegistration files to create PR
4598514
@DamienGilliard
WIP: Open3d ICP added to registration class
3cdf659
@DamienGilliard
WIP: refined registrations implemented
d8fe53b
@DamienGilliard
FIX: open3d and boost submodules erronously deleted: re-added using l…
ab2b85b 
…ocal git directory
@DamienGilliard
WIP: change file name to DFRefinedRegistration and add documentation
fbd16db
@DamienGilliard
WIP: rebase on main
2bb29ed
@DamienGilliard
Merge branch 'refined_registration' of github.com:diffCheckOrg/diffCh…
8416784 
…eck into refined_registration
@DamienGilliard
FIX: folder naming
455881e
@DamienGilliard
FIX: folder naming
f852b97
@DamienGilliard
ADD: ICP refined registrations with exposed parameters
a3b23a2
@DamienGilliard
ADD: ICP refined registrations with exposed parameters
bd6de0a
@DamienGilliard
Fix: GeneralizedICP
283b57f
@DamienGilliard
WIP-FIX: normal computation for point to plane ICP added, and improve…
e7de865 
…ment of documentation of ICP
@DamienGilliard
CAP: Fully functionning and documented O3D ICP registration methods
c583767
@DamienGilliard
FIX: doi instead of URL for external reference
746d49b
@DamienGilliard
FIX: solve .gitmodule merge conflict
f366cd6
@DamienGilliard
FIX: sentence in documentation not clear
c497970
@DamienGilliard
Copy link
Collaborator Author

@9and3 I believe this PR is ready for review.
With the rebase a lot of files have been added, but I only touched the DFRefinedRegistration.cc & hh , diffCheckApp.cc and .gitmodule to try and solve the merge conflict (didn't work but now the 2 files are identical).

The registrations work fine, when given an adequate maxCorrespondanceDistance.

@9and3 9and3 added the enhancement New feature or request label May 3, 2024
9and3
9and3 requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm for the code and everything but the rebase is a bit of a mess 👹 . Can I ask you to open a new PR and add only your files:

  • DFRefinedRegistration.cc/hh
  • the modified header file (diffCheck.hh see my comment in this review plis, you need to add your new header here)
  • if you want your modified diffCheckApp.cc to give a quite test

Thank you @DamienGilliard 👐 !

src/diffCheck.hh Show resolved Hide resolved
src/diffCheck.hh Show resolved Hide resolved
src/diffCheckApp.cc Show resolved Hide resolved
@9and3
Copy link
Contributor

9and3 commented May 17, 2024

already merged on separate PR, closing this one..

@9and3 9and3 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9and3 9and3 9and3 requested changes

Assignees

@DamienGilliard DamienGilliard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamienGilliard @9and3