Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix five files with missing type information #250

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix five files with missing type information #250

wants to merge 4 commits into from

Commits on Apr 10, 2022

  1. Add missing Engine type to number generator 

    While not used in the code (hence the eslint disabling) it is used in the TypeScript typings which results in four immediate errors in the definitions.
    @JamesSkemp
    JamesSkemp committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    474795c View commit details
    Browse the repository at this point in the history

  2. Add missing imports for type definitions 

    While not directly used, types are referenced in the docs and aren't added to the TypeScript definitions.
    @JamesSkemp
    JamesSkemp committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    e0d9cc2 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'dice-roller:develop' into hotfix/fix-5.1-typings

    @JamesSkemp
    JamesSkemp authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    1f21c7a View commit details
    Browse the repository at this point in the history

  2. Fix random-js import in NumberGenerator

    @JamesSkemp
    JamesSkemp committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    bff6d0c View commit details
    Browse the repository at this point in the history