-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/25 add gain node #32
base: master
Are you sure you want to change the base?
Conversation
Sorry, I created the PR from the wrong branch on my fork. I added a |
To test if typescript-project works fine, you can use Considering your pull request: i thought that it should be possible to tune gainNode value "in runtime", not only during initialization. To make "mute" function or something like that. Correct me if i wrong. And thank you for your work. |
Sounds like a good idea :) Will work on that ASAP And thanks for the hint on how to test this locally. Wouldn't it be possible to reference it by going up the directory a few steps? |
This is probably possible, but partially ignores node mechanism of modules resolve. You may be can also try this (https://docs.npmjs.com/cli/link) Considering making it configurable, i think you can just add method like getGainNode to interface that will return existing gain node and that will allow users to manage it in any desired way. (probably we can also remove new 'gain' property from option). What do you think about that? |
Sounds good to me. Will change ASAP |
I added a minimal working solution for a gainNode. Tested on
Google Chrome 56.0.2924.87 (64-bit)
/ Ubuntu 16.10. See #25