Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultLoopRender and avoid fsnotify dependency #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

georgefst
Copy link

@georgefst georgefst commented Jan 13, 2025

See #370. This branch is to demonstrate how little fsnotify-dependent code this library has, and to give me somewhere to point to for projects in which I'm using diagrams with the Wasm backend.

Currently, building for Wasm with GHC 9.10 requires a cabal.project with:

packages: .

if arch(wasm32)
  active-repositories: hackage.haskell.org, head.hackage.ghc.haskell.org

Then, for example, nix shell gitlab:haskell-wasm/ghc-wasm-meta?rev=56dfe2478cae35ded335261c854bb8b2a5e7f4d2#all_9_10 -c wasm32-wasi-cabal build all works.

@georgefst
Copy link
Author

Actually, reading #370 again, it seems @byorgey is open to the idea of removing this function entirely, so perhaps this shouldn't be a draft...

@byorgey
Copy link
Member

byorgey commented Jan 13, 2025

@georgefst Yeah, definitely open to removing it entirely!

@georgefst georgefst marked this pull request as ready for review January 13, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants