Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GHC 9.8 #2

Closed
wants to merge 4 commits into from
Closed

Compatibility with GHC 9.8 #2

wants to merge 4 commits into from

Conversation

rvl
Copy link

@rvl rvl commented Jan 11, 2024

This patch lets blaze-svg compile with GHC 9.8 and bumps the version to 0.3.7.1.

However, it may be better to edit the package version bounds on Hackage.

@rvl
Copy link
Author

rvl commented Jan 11, 2024

Hi @byorgey, there are a few other packages which I know can build with GHC 9.8, if their build-depends version ranges are expanded accordingly. (Because of NixOS/nixpkgs#276275)

Package Offending bounds Pull Request
blaze-svg base <4.19 #2
diagrams-lib base <4.19, text <2.1 diagrams/diagrams-lib#364
diagrams-postscript base <4.19, bytestring <0.12
diagrams-svg base <4.19, text <2.1
statestack base <4.19 diagrams/statestack#11
svg-builder base <4.19, bytestring <0.12, text <2.1

Should I open similar PRs on those packages? Or are you happy to make revisions on Hackage?

@byorgey
Copy link
Member

byorgey commented Jan 11, 2024

Hi @rvl , thanks! I'm slowly working through updating all my packages, so no need to open more PRs, but I do appreciate the nudge.

@rvl
Copy link
Author

rvl commented Jan 11, 2024

Great, thanks. 👍

@byorgey
Copy link
Member

byorgey commented Jan 30, 2024

I went ahead and did this via my own typical workflow, and revised the bounds on Hackage. I appreciate the PR though!

@byorgey byorgey closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants