-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 for review #59
base: master
Are you sure you want to change the base?
Conversation
Make more compatible with Python 3 + Black
clarify installation instructions for use as Python package, not app
Just a note that I've successfully tested this for ICESat-2 2020 and it's been working great in Python 3. Thanks @deppen8 and @ChristinaB for your work on this. Let me know if I can offer help so this can get merged. |
Any chance this PR could be merged soon? Can I help in some way? We are getting set to review applications for OceanHackWeek 2020. Applications closed today, and we're on an accelerated track. We haven't made a definitive decision to use Entrofy, but we'd like to. For various reasons (none good), we haven't used it in previous years. |
I'm really sorry I didn't get to this earlier. Thank you for doing the Python3 conversion. I have two comments:
I think the presence of the latter files might raise some privacy concerns? I think I'd recommend updating your fork with the current master of entrofy, cloning a clean copy, make a branch, then copy the files with the relevant changes (e.g. |
I can take a run at this tonight since it was my original PR to Christina's fork that kicked things off. I'll make a commit directly to entropy without the Black formatting fun :D |
Thank you @dhuppenkothen! And @deppen8 thanks so much for offering to clean up the original PR! Great to hear from you. A "direct commit directly to entropy" sounds like a very interesting proposition 😉; maybe more interesting than a commit to entrofy. |
Autocomplete!!! :shakes fist: To be fair though, most of my commits do increase entropy 😁 |
See #63 |
Daniella - It looks like you have made a few updates since I forked. I can make those changes manually unless you suggest other steps for pull request. Do you want a different branch?
This change is