-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from paritytech:master #16
Commits on Jul 30, 2024
-
[subsystem-benchmark] Update availability-distribution-regression-ben…
…ch baseline after recent subsystem changes (#5180)
Configuration menu - View commit details
-
Copy full SHA for 0754429 - Browse repository at this point
Copy the full SHA 0754429View commit details -
[Backport] version bumps and the prdocs reordering from stable2407 (#…
…5178) This PR backports regular version bumps and reorganisation of the `prdoc` files from the stable release branch back to master
Configuration menu - View commit details
-
Copy full SHA for 4ffa9b8 - Browse repository at this point
Copy the full SHA 4ffa9b8View commit details -
[CI] Cache try-runtime check (#5179)
Adds a snapshot step to the try-runtime check that tries to download a cached snapshot. The cache is valid for the current day and is otherwise re-created. Check is now only limited by build time and docker startup. ![Screenshot 2024-07-30 at 02 02 58](https://github.com/user-attachments/assets/0773e9b9-4a52-4572-a891-74b9d725ba70) ![Screenshot 2024-07-30 at 02 02 20](https://github.com/user-attachments/assets/4685ef17-a04c-4bdc-9d61-311d0010f71c) --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 686ee99 - Browse repository at this point
Copy the full SHA 686ee99View commit details -
pallet-timestamp:
UnixTime::now
implementation logs error only if c……alled at genesis (#5055) This PR reverts the removal of an [`if` statement](7ecf3f7#diff-8bf31ba8d9ebd6377983fd7ecc7f4e41cb1478a600db1a15a578d1ae0e8ed435L370) merged recently, which affected test output verbosity of several pallets (e.g. staking, EPM, and potentially others). More generally, the `UnixTime::now` implementation of the timestamp pallet should log an error *only* when called at the genesis block.
Configuration menu - View commit details
-
Copy full SHA for 03c45b9 - Browse repository at this point
Copy the full SHA 03c45b9View commit details -
Remove
pallet::getter
usage from the pallet-balances (#4967)As per #3326, removes usage of the `pallet::getter` macro from the balances pallet. The syntax `StorageItem::<T, I>::get()` should be used instead. Also, adds public functions for compatibility. cc @muraca polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fbfc7e - Browse repository at this point
Copy the full SHA 7fbfc7eView commit details
Commits on Jul 31, 2024
-
Run UI tests in CI for some other crates (#5167)
The test name is `test-frame-ui` I don't know if I can also change it to `test-ui` without breaking other stuff. So I kept the name unchanged. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 39daa61 - Browse repository at this point
Copy the full SHA 39daa61View commit details -
litep2p/discovery: Publish authority records with external addresses …
…only (#5176) This PR reduces the occurrences for identified observed addresses. Litep2p discovers its external addresses by inspecting the `IdentifyInfo::ObservedAddress` field reported by other peers. After we get 5 confirmations of the same external observed address (the address the peer dialed to reach us), the address is reported through the network layer. The PR effectively changes this from 5 to 2. This has a subtle implication on freshly started nodes for the authority-discovery discussed below. The PR also makes the authority discovery a bit more robust by not publishing records if the node doesn't have addresses yet to report. This aims to fix a scenario where: - the litep2p node has started, it has some pending observed addresses but less than 5 - the authorit-discovery publishes a record, but at this time the node doesn't have any addresses discovered and the record is published without addresses -> this means other nodes will not be able to reach us Next Steps - [ ] versi testing Closes: #5147 cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d0aa89 - Browse repository at this point
Copy the full SHA 7d0aa89View commit details
Commits on Aug 1, 2024
-
Adjust sync templates flow to use new release branch (#5182)
As the release branch name changed starting from this release, this PR adds it to the sync templates flow so that checkout step worked properly. --------- Co-authored-by: rzadp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a5b6e0 - Browse repository at this point
Copy the full SHA 6a5b6e0View commit details -
Replace env_logger with sp_tracing (#5065)
This PR replaces env_logger with sp_tracing because of an issue with env_logger and gum #4660 --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Andrei Eres <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 776e957 - Browse repository at this point
Copy the full SHA 776e957View commit details
Commits on Aug 2, 2024
-
Add an adapter for configuring AssetExchanger (#5130)
Added a new adapter to xcm-builder, the `SingleAssetExchangeAdapter`. This adapter makes it easy to use `pallet-asset-conversion` for configuring the `AssetExchanger` XCM config item. I also took the liberty of adding a new function to the `AssetExchange` trait, with the following signature: ```rust fn quote_exchange_price(give: &Assets, want: &Assets, maximal: bool) -> Option<Assets>; ``` The signature is meant to be fairly symmetric to that of `exchange_asset`. The way they interact can be seen in the doc comment for it in the `AssetExchange` trait. This is a breaking change but is needed for #5131. Another idea is to create a new trait for this but that would require setting it in the XCM config which is also breaking. Old PR: #4375. --------- Co-authored-by: Adrian Catangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8ccb6b3 - Browse repository at this point
Copy the full SHA 8ccb6b3View commit details -
rpc: Enable ChainSpec for polkadot-parachain (#5205)
This PR enables the `chainSpec_v1` class for the polkadot-parachian. The chainSpec is part of the rpc-v2 which is spec-ed at: https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/chainSpec.md. This also paves the way for enabling a future `chainSpec_unstable_spec` on all nodes. Closes: #5191 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ce6938a - Browse repository at this point
Copy the full SHA ce6938aView commit details
Commits on Aug 5, 2024
-
beefy: Tolerate pruned state on runtime API call (#5197)
While working on #5129 I noticed that after warp sync, nodes would print: ``` 2024-07-29 17:59:23.898 ERROR ⋮beefy: 🥩 Error: ConsensusReset. Restarting voter. ``` After some debugging I found that we enter the following loop: 1. Wait for beefy pallet to be available: Pallet is detected available directly after warp sync since we are at the tip. 2. Wait for headers from tip to beefy genesis to be available: During this time we don't process finality notifications, since we later want to inspect all the headers for authority set changes. 3. Gap sync finishes, route to beefy genesis is available. 4. The worker starts acting, tries to fetch beefy genesis block. It fails, since we are acting on old finality notifications where the state is already pruned. 5. Whole beefy subsystem is being restarted, loading the state from db again and iterating a lot of headers. This already happened before #5129.
Configuration menu - View commit details
-
Copy full SHA for 2abd03e - Browse repository at this point
Copy the full SHA 2abd03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad1e556 - Browse repository at this point
Copy the full SHA ad1e556View commit details -
network/strategy: Backoff and ban overloaded peers to avoid submittin…
…g the same request multiple times (#5029) This PR avoids submitting the same block or state request multiple times to the same slow peer. Previously, we submitted the same request to the same slow peer, which resulted in reputation bans on the slow peer side. Furthermore, the strategy selected the same slow peer multiple times to submit queries to, although a better candidate may exist. Instead, in this PR we: - introduce a `DisconnectedPeers` via LRU with 512 peer capacity to only track the state of disconnected peers with a request in flight - when the `DisconnectedPeers` detects a peer disconnected with a request in flight, the peer is backed off - on the first disconnection: 60 seconds - on second disconnection: 120 seconds - on the third disconnection the peer is banned, and the peer remains banned until the peerstore decays its reputation This PR lifts the pressure from overloaded nodes that cannot process requests in due time. And if a peer is detected to be slow after backoffs, the peer is banned. Theoretically, submitting the same request multiple times can still happen when: - (a) we backoff and ban the peer - (b) the network does not discover other peers -- this may also be a test net - (c) the peer gets reconnected after the reputation decay and is still slow to respond Aims to improve: - #4924 - #531 Next Steps: - Investigate the network after this is deployed, possibly bumping the keep-alive timeout or seeing if there's something else misbehaving This PR builds on top of: - #4987 ### Testing Done - Added a couple of unit tests where test harness were set in place - Local testnet ```bash 13:13:25.102 DEBUG tokio-runtime-worker sync::persistent_peer_state: Added first time peer 12D3KooWHdiAxVd8uMQR1hGWXccidmfCwLqcMpGwR6QcTP6QRMuD 13:14:39.102 DEBUG tokio-runtime-worker sync::persistent_peer_state: Remove known peer 12D3KooWHdiAxVd8uMQR1hGWXccidmfCwLqcMpGwR6QcTP6QRMuD state: DisconnectedPeerState { num_disconnects: 2, last_disconnect: Instant { tv_sec: 93355, tv_nsec: 942016062 } }, should ban: false 13:16:49.107 DEBUG tokio-runtime-worker sync::persistent_peer_state: Remove known peer 12D3KooWHdiAxVd8uMQR1hGWXccidmfCwLqcMpGwR6QcTP6QRMuD state: DisconnectedPeerState { num_disconnects: 3, last_disconnect: Instant { tv_sec: 93485, tv_nsec: 947551051 } }, should ban: true 13:16:49.108 WARN tokio-runtime-worker peerset: Report 12D3KooWHdiAxVd8uMQR1hGWXccidmfCwLqcMpGwR6QcTP6QRMuD: -2147483648 to -2147483648. Reason: Slow peer after backoffs. Banned, disconnecting. ``` cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6619277 - Browse repository at this point
Copy the full SHA 6619277View commit details -
This PR adds functionality that allows tasks to enable auto-renewal. Each task eligible for renewal can enable auto-renewal. A new storage value is added to track all the cores with auto-renewal enabled and the associated task running on the core. The `BoundedVec` is sorted by `CoreIndex` to make disabling auto-renewal more efficient. Cores are renewed at the start of a new bulk sale. If auto-renewal fails(e.g. due to the sovereign account of the task not holding sufficient balance), an event will be emitted, and the renewal will continue for the other cores. The two added extrinsics are: - `enable_auto_renew`: Extrinsic for enabling auto renewal. - `disable_auto_renew`: Extrinsic for disabling auto renewal. TODOs: - [x] Write benchmarks for the newly added extrinsics. Closes: #4351 --------- Co-authored-by: Dónal Murray <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f170af6 - Browse repository at this point
Copy the full SHA f170af6View commit details -
make polkadot-parachain startup errors pretty (#5214)
The errors on polkadot-parachain are not printed with their full display context(what is marked with `#[error(`) because main returns plain Result and the error will be shown in its Debug format, that's not consistent with how the polkadot binary behave and is not user friendly since it does not tell them why they got the error. Fix it by using `color_eyre` as polkadot already does it. Fixes: #5211 ## Output before ``` Error: NetworkKeyNotFound("/acala/data/Collator2/chains/mandala-tc9/network/secret_ed25519") ``` ## Output after ``` Error: 0: Starting an authorithy without network key in /home/alexggh/.local/share/polkadot-parachain/chains/asset-hub-kusama/network/secret_ed25519. This is not a safe operation because other authorities in the network may depend on your node having a stable identity. Otherwise these other authorities may not being able to reach you. If it is the first time running your node you could use one of the following methods: 1. [Preferred] Separately generate the key with: <NODE_BINARY> key generate-node-key --base-path <YOUR_BASE_PATH> 2. [Preferred] Separately generate the key with: <NODE_BINARY> key generate-node-key --file <YOUR_PATH_TO_NODE_KEY> 3. [Preferred] Separately generate the key with: <NODE_BINARY> key generate-node-key --default-base-path 4. [Unsafe] Pass --unsafe-force-node-key-generation and make sure you remove it for subsequent node restarts ``` --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0cc3e17 - Browse repository at this point
Copy the full SHA 0cc3e17View commit details -
Remove unused feature gated code from the minimal template (#5237)
- Progresses #5226 There is no actual `try-runtime` or `runtime-benchmarks` functionality in the minimal template at the moment.
Configuration menu - View commit details
-
Copy full SHA for 035211d - Browse repository at this point
Copy the full SHA 035211dView commit details
Commits on Aug 6, 2024
-
Github Actions workflow to automatically sync critical forks (#5259)
This Workflow is not supposed to run in the paritytech/polkadot-sdk repo. This Workflow is supposed to run only in the forks of the repo, in `paritytech-release/polkadot-sdk` specifically, to automatically maintain the critical fork synced with the upstream. This Workflow should be always disabled in the paritytech/polkadot-sdk repo.
Configuration menu - View commit details
-
Copy full SHA for 2b5ccba - Browse repository at this point
Copy the full SHA 2b5ccbaView commit details -
[pallet_contracts] Increase the weight of the deposit_event host func…
…tion to limit the memory used by events. (#4973) This PR updates the weight of the `deposit_event` host function by adding a fixed ref_time of 60,000 picoseconds per byte. Given a block time of 2 seconds and this specified ref_time, the total allocation size is 32MB. --------- Co-authored-by: Alexander Theißen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11fdff1 - Browse repository at this point
Copy the full SHA 11fdff1View commit details -
Improve Pallet UI doc test (#5264)
Test currently failing, therefore improving to include a file from the same crate to not trip up the caching. R0 silent since this is only modifying unpublished crates. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Dónal Murray <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 291c082 - Browse repository at this point
Copy the full SHA 291c082View commit details
Commits on Aug 7, 2024
-
[Assets] Call implementation for
transfer_all
(#4527)Closes #4517 Polkadot address: 12gMhxHw8QjEwLQvnqsmMVY1z5gFa54vND74aMUbhhwN6mJR --------- Co-authored-by: joe petrowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6db2038 - Browse repository at this point
Copy the full SHA 6db2038View commit details -
Add
ProofSizeExt
to benchmarks (#5257)I propose to have `ProofSizeExt` available during benchmarking so we can improve the accuracy for extensions using it. Another thing we could do is to also enable recording for the timing benchmark here: https://github.com/paritytech/polkadot-sdk/blob/035211d707d0a74a2a768fd658160721f09d5b44/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs#L232 Parachains will need to have recording enabled during import for reclaim, so we could enable it here and provide a flag `--disable-proof-recording` for scenarios where one does not want it. Happy to hear opinions about this.
Configuration menu - View commit details
-
Copy full SHA for dd48544 - Browse repository at this point
Copy the full SHA dd48544View commit details -
cli/net_params: Warn on empty public-addr when starting a validator n…
…ode (#5240) This PR shows a warning when the `--public-addr` is not provided for validators. In the future, we'll transform this warning into a hard failure. Validators are encouraged to provide this parameter for better availability over the network. cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7a6e91c - Browse repository at this point
Copy the full SHA 7a6e91cView commit details -
Update the wishlist leaderboard script to handle PRs (#5256)
Addresses #5085 (comment) Luckily, in the rest of the script, github API allows (or forces?) us to read the state of PRs the same way as we read the state of issues, so it works without any more changes.
Configuration menu - View commit details
-
Copy full SHA for 34e64c7 - Browse repository at this point
Copy the full SHA 34e64c7View commit details -
Export more from sc-service (#5250)
Follow-up to #4457, looks like more things were missing --------- Co-authored-by: Niklas Adolfsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd1a29f - Browse repository at this point
Copy the full SHA cd1a29fView commit details -
Run semver check even when no prdoc (#5189)
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a986da2 - Browse repository at this point
Copy the full SHA a986da2View commit details -
### Context Since Rococo is now deprecated, we need another testnet to detect bleeding-edge changes to Substrate, Polkadot, & BEEFY consensus protocols that could brick the bridge. It's the mirror PR of Snowfork#157 which has reviewed by Snowbridge team internally. Synced with @acatangiu about that in channel https://matrix.to/#/!gxqZwOyvhLstCgPJHO:matrix.parity.io/$N0CvTfDSl3cOQLEJeZBh-wlKJUXx7EDHAuNN5HuYHY4?via=matrix.parity.io&via=parity.io&via=matrix.org --------- Co-authored-by: Clara van Staden <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for efdc1e9 - Browse repository at this point
Copy the full SHA efdc1e9View commit details -
Bring reference_hardware.json inline with machine used for weights (#…
…5196) Since `May 2023` after paritytech/substrate#13548 optimization, `Blake2256` is faster with about 30%, that means that there is a difference of ~30% between the benchmark values we ask validators to run against and the machine we use for generating the weights.So if all validators, just barely pass the benchmarks our weights are potentially underestimated with about ~20%, so let's bring this two in sync. Same thing happened when we merged #2524 in `Nov 2023` SR25519-Verify became faster with about 10-15% ## Results Generated on machine from here: paritytech/devops#3210 ``` +----------+----------------+--------------+-------------+-------------------+ | Category | Function | Score | Minimum | Result | +============================================================================+ | CPU | BLAKE2-256 | 1.00 GiBs | 783.27 MiBs | ✅ Pass (130.7 %) | |----------+----------------+--------------+-------------+-------------------| | CPU | SR25519-Verify | 637.62 KiBs | 560.67 KiBs | ✅ Pass (113.7 %) | |----------+----------------+--------------+-------------+-------------------| | Memory | Copy | 12.19 GiBs | 11.49 GiBs | ✅ Pass (106.1 %) | ``` Discovered and discussed here: #5127 (comment) ## Downsides Machines that barely passed the benchmark will suddenly find themselves bellow the benchmark, but since that is just an warning and everything else continues as before it shouldn't be too impactful and should give the validators the necessary information that they need to become compliant, since they actually aren't when compared with the used weights. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8af9889 - Browse repository at this point
Copy the full SHA 8af9889View commit details -
Umbrella crate: exclude chain-specific crates (#5173)
Uses custom metadata to exclude chain-specific crates. The only concern is that devs who want to use chain-specific crates, still need to select matching versions numbers. Could possibly be addresses with chain-specific umbrella crates, but currently it should be possible to use [psvm](https://github.com/paritytech/psvm). --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fb6e3c - Browse repository at this point
Copy the full SHA 0fb6e3cView commit details -
frame-omni-bencher short checks (#5268)
- Part of paritytech/ci_cd#1006 - Closes: paritytech/ci_cd#1010 - Related: #4405 - Possibly affecting how frame-omni-bencher works on different runtimes: #5083 Currently works in parallel with gitlab short benchmarks. Triggered only by adding `GHA-migration` label to assure smooth transition (kind of feature-flag). Later when tested on random PRs we'll remove the gitlab and turn on by default these tests --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 711d91a - Browse repository at this point
Copy the full SHA 711d91aView commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb0a9e5 - Browse repository at this point
Copy the full SHA eb0a9e5View commit details -
[ci] Add test-linux-stable jobs GHA (#4897)
PR adds github-action for jobs test-linux-stable-oldkernel. PR waits the latest release of forklift. cc paritytech/ci_cd#939 cc paritytech/ci_cd#1006 --------- Co-authored-by: Maksym H <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12539e7 - Browse repository at this point
Copy the full SHA 12539e7View commit details
Commits on Aug 9, 2024
-
Add stable release tag as an input parameter (#5282)
This PR adds the possibility to set the docker stable release tag as an input parameter to the produced docker images, so that it matches with the release version
Configuration menu - View commit details
-
Copy full SHA for 2993b00 - Browse repository at this point
Copy the full SHA 2993b00View commit details -
Synchronize templates through PRs, instead of pushes (#5291)
Despite what we had in the [original request](#3155 (comment)), I'm proposing a change to open a PR to the destination template repositories instead of pushing the code. This will give it a chance to run through the destination CI before making changes, and to set stricter branch protection in the destination repos.
Configuration menu - View commit details
-
Copy full SHA for 87280eb - Browse repository at this point
Copy the full SHA 87280ebView commit details -
Update BHR and BHW runtime versions (#5300)
Updating the BHR and BHW runtime versions as a result of the changes in #5074
Configuration menu - View commit details
-
Copy full SHA for b49509b - Browse repository at this point
Copy the full SHA b49509bView commit details -
[tests] make emulated setup closer to ecosystem reality (#5301)
In the real world, not all assets are sufficient. This aligns our emulated networks to that reality. Only DOT and USDT are sufficient "by default".
Configuration menu - View commit details
-
Copy full SHA for 32b8760 - Browse repository at this point
Copy the full SHA 32b8760View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a9ad4 - Browse repository at this point
Copy the full SHA b1a9ad4View commit details -
StorageWeightReclaim: Fix issue when underestimating refund. (#5273)
The code do reduce or increase the weight by comparing `benchmarked_weight` and `consumed_weight`. But `benchmarked_weight` is the pre dispatch weight. not the post dispatch weight that is actually written into the block weight by `CheckWeight`. So in case the consumed weight was: `pre dispatch weight > consumed weight > post dispatch weight` then the reclaim code was reducing the block weight instead of increasing it. Might explain this issue even better #5229 @skunert @s0me0ne-unkn0wn
Configuration menu - View commit details
-
Copy full SHA for 862860e - Browse repository at this point
Copy the full SHA 862860eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 380cd21 - Browse repository at this point
Copy the full SHA 380cd21View commit details -
Move PVF code and PoV decompression to PVF host workers (#5142)
Closes #5071 This PR aims to * Move all the blocking decompression from the candidate validation subsystem to the PVF host workers; * Run the candidate validation subsystem on the non-blocking pool again. Upsides: no blocking operations in the subsystem's main loop. PVF throughput is not limited by the ability of the subsystem to decompress a lot of stuff. Correctness and homogeneity improve, as the artifact used to be identified by the hash of decompressed code, and now they are identified by the hash of compressed code, which coincides with the on-chain `ValidationCodeHash`. Downsides: the PVF code decompression is now accounted for in the PVF preparation timeout (be it pre-checking or actual preparation). Taking into account that the decompression duration is on the order of milliseconds, and the preparation timeout is on the order of seconds, I believe it is negligible.
Configuration menu - View commit details
-
Copy full SHA for 47c1b4c - Browse repository at this point
Copy the full SHA 47c1b4cView commit details -
Add missing features in templates' node packages (#5294)
Corrects the issue we had [here](paritytech/polkadot-sdk-parachain-template#10), in which `cargo build --release` worked but `cargo build --package parachain-template-node --release` failed with missing features. The command has been added to CI to make sure it works, but at the same we're changing it in the readme to just `cargo build --release` for simplification. Labeling silent because those packages are un-published as part of the regular release process. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 149c709 - Browse repository at this point
Copy the full SHA 149c709View commit details
Commits on Aug 12, 2024
-
prospective-parachains rework: take II (#4937)
Resolves #4800 # Problem In #4035, we removed support for parachain forks and cycles and added support for backing unconnected candidates (candidates for which we don't yet know the full path to the latest included block), which is useful for elastic scaling (parachains using multiple cores). Removing support for backing forks turned out to be a bad idea, as there are legitimate cases for a parachain to fork (if they have other consensus mechanism for example, like BABE or PoW). This leads to validators getting lower backing rewards (depending on whether they back the winning fork or not) and a higher pressure on only the half of the backing group (during availability-distribution for example). Since we don't yet have approval voting rewards, backing rewards are a pretty big deal (which may change in the future). # Description A backing group is now allowed to back forks. Once a candidate becomes backed (has the minimum backing votes), we don't accept new forks unless they adhere to the new fork selection rule (have a lower candidate hash). This helps with keeping the implementation simpler, since forks will only be taken into account for candidates which are not backed yet (only seconded). Having this fork selection rule also helps with reducing the work backing validators need to do, since they have a shared way of picking the winning fork. Once they see a candidate backed, they can all decide to back a fork and not accept new ones. But they still accept new ones during the seconding phase (until the backing quorum is reached). Therefore, a block author which is not part of the backing group will likely not even see the forks (only the winning one). Just as before, a parachain producing forks will still not be able to leverage elastic scaling but will still work with a single core. Also, cycles are still not accepted. ## Some implementation details `CandidateStorage` is no longer a subsystem-wide construct. It was previously holding candidates from all relay chain forks and complicated the code. Each fragment chain now holds their candidate chain and their potential candidates. This should not increase the storage consumption since the heavy candidate data is already wrapped in an Arc and shared. It however allows for great simplifications and increase readability. `FragmentChain`s are now only creating a chain with backed candidates and the fork selection rule. As said before, `FragmentChain`s are now also responsible for maintaining their own potential candidate storage. Since we no longer have the subsytem-wide `CandidateStorage`, when getting a new leaf update, we use the storage of our latest ancestor, which may contain candidates seconded/backed that are still in scope. When a candidate is backed, the fragment chains which hold it are recreated (due to the fork selection rule, it could trigger a "reorg" of the fragment chain). I generally tried to simplify the subsystem and not introduce unneccessary optimisations that would otherwise complicate the code and not gain us much (fragment chains wouldn't realistically ever hold many candidates) TODO: - [x] update metrics - [x] update docs and comments - [x] fix and add unit tests - [x] tested with fork-producing parachain - [x] tested with cycle-producing parachain - [x] versi test - [x] prdoc
Configuration menu - View commit details
-
Copy full SHA for 0b52a2c - Browse repository at this point
Copy the full SHA 0b52a2cView commit details -
xcm-executor: allow deposit of multiple assets if at least one of the…
…m satisfies ED (#4460) Closes #4242 XCM programs that deposit assets to some new (empty) account will now succeed if at least one of the deposited assets satisfies ED. Before this change, the requirement was that the _first_ asset had to satisfy ED, but assets order can be changed during reanchoring so it is not reliable. With this PR, ordering doesn't matter, any one(s) of them can satisfy ED for the whole deposit to work. Kusama address: FkB6QEo8VnV3oifugNj5NeVG3Mvq1zFbrUu4P5YwRoe5mQN --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for ebcbca3 - Browse repository at this point
Copy the full SHA ebcbca3View commit details -
Fix favicon link to fix CI (#5319)
The polkadot.network website was recently refreshed and the `favicon-32x32.png` was removed. It was linked in some docs and so the docs have been updated to point to a working favicon on the new website. Previously the lychee link checker was failing on all PRs.
Configuration menu - View commit details
-
Copy full SHA for 1f49358 - Browse repository at this point
Copy the full SHA 1f49358View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc906d5 - Browse repository at this point
Copy the full SHA fc906d5View commit details -
chain-spec: minor clarification on the genesis config patch (#5324)
Added minor clarification on the genesis config patch ([link](https://substrate.stackexchange.com/questions/11813/in-the-genesis-config-what-does-the-patch-key-do/11825#11825)) --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for b52cfc2 - Browse repository at this point
Copy the full SHA b52cfc2View commit details -
Remove unnecessary mut (#5318)
Trivial leftover from #4844 Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bcc9673 - Browse repository at this point
Copy the full SHA bcc9673View commit details -
Bump the known_good_semver group across 1 directory with 3 updates (#…
…5315) Bumps the known_good_semver group with 2 updates in the / directory: [serde](https://github.com/serde-rs/serde) and [serde_json](https://github.com/serde-rs/json). Updates `serde` from 1.0.204 to 1.0.206 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.206</h2> <ul> <li>Improve support for <code>flatten</code> attribute inside of enums (<a href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> <h2>v1.0.205</h2> <ul> <li>Use serialize_entry instead of serialize_key + serialize_value when serialize flattened newtype enum variants (<a href="https://redirect.github.com/serde-rs/serde/issues/2785">#2785</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> <li>Avoid triggering a collection_is_never_read lint in the deserialization of enums containing flattened fields (<a href="https://redirect.github.com/serde-rs/serde/issues/2791">#2791</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/85c73ef8dea8966d88a03876e6f0dc9359e68cc9"><code>85c73ef</code></a> Release 1.0.206</li> <li><a href="https://github.com/serde-rs/serde/commit/5ba1796a7e639839d4e18c3ae23b9bb32b0700b5"><code>5ba1796</code></a> Resolve doc_markdown pedantic lint on regression test function</li> <li><a href="https://github.com/serde-rs/serde/commit/e52b7b380f88e0112c9f84e6258bdd34ad132352"><code>e52b7b3</code></a> Touch up PR 2567</li> <li><a href="https://github.com/serde-rs/serde/commit/84c7419652161bf88f88eb26302b26debfff8a8c"><code>84c7419</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2794">#2794</a> from dtolnay/neverread</li> <li><a href="https://github.com/serde-rs/serde/commit/536221b1f93a5dcf97352c7d1e3b93a5a56bf747"><code>536221b</code></a> Temporarily ignore collection_is_never_read on FlattenSkipDeserializing</li> <li><a href="https://github.com/serde-rs/serde/commit/fc55ac70d34221b38672b1583e496011fbae92aa"><code>fc55ac7</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a> from Mingun/fix-2565</li> <li><a href="https://github.com/serde-rs/serde/commit/2afe5b4ef9d0e89587ec564eadbc7583fd1f0673"><code>2afe5b4</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/2792">#2792</a></li> <li><a href="https://github.com/serde-rs/serde/commit/b4ec2595c9dd8e380227043eba42ff85beb780c2"><code>b4ec259</code></a> Correctly process flatten fields in enum variants</li> <li><a href="https://github.com/serde-rs/serde/commit/c3ac7b675a38a73170879992976acb0009834ac0"><code>c3ac7b6</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/1904">#1904</a></li> <li><a href="https://github.com/serde-rs/serde/commit/24614e44bff5466057e46c55394bac3ae20142c4"><code>24614e4</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/2565">#2565</a></li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206">compare view</a></li> </ul> </details> <br /> Updates `serde_derive` from 1.0.204 to 1.0.206 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde_derive's releases</a>.</em></p> <blockquote> <h2>v1.0.206</h2> <ul> <li>Improve support for <code>flatten</code> attribute inside of enums (<a href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> <h2>v1.0.205</h2> <ul> <li>Use serialize_entry instead of serialize_key + serialize_value when serialize flattened newtype enum variants (<a href="https://redirect.github.com/serde-rs/serde/issues/2785">#2785</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> <li>Avoid triggering a collection_is_never_read lint in the deserialization of enums containing flattened fields (<a href="https://redirect.github.com/serde-rs/serde/issues/2791">#2791</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/85c73ef8dea8966d88a03876e6f0dc9359e68cc9"><code>85c73ef</code></a> Release 1.0.206</li> <li><a href="https://github.com/serde-rs/serde/commit/5ba1796a7e639839d4e18c3ae23b9bb32b0700b5"><code>5ba1796</code></a> Resolve doc_markdown pedantic lint on regression test function</li> <li><a href="https://github.com/serde-rs/serde/commit/e52b7b380f88e0112c9f84e6258bdd34ad132352"><code>e52b7b3</code></a> Touch up PR 2567</li> <li><a href="https://github.com/serde-rs/serde/commit/84c7419652161bf88f88eb26302b26debfff8a8c"><code>84c7419</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2794">#2794</a> from dtolnay/neverread</li> <li><a href="https://github.com/serde-rs/serde/commit/536221b1f93a5dcf97352c7d1e3b93a5a56bf747"><code>536221b</code></a> Temporarily ignore collection_is_never_read on FlattenSkipDeserializing</li> <li><a href="https://github.com/serde-rs/serde/commit/fc55ac70d34221b38672b1583e496011fbae92aa"><code>fc55ac7</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a> from Mingun/fix-2565</li> <li><a href="https://github.com/serde-rs/serde/commit/2afe5b4ef9d0e89587ec564eadbc7583fd1f0673"><code>2afe5b4</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/2792">#2792</a></li> <li><a href="https://github.com/serde-rs/serde/commit/b4ec2595c9dd8e380227043eba42ff85beb780c2"><code>b4ec259</code></a> Correctly process flatten fields in enum variants</li> <li><a href="https://github.com/serde-rs/serde/commit/c3ac7b675a38a73170879992976acb0009834ac0"><code>c3ac7b6</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/1904">#1904</a></li> <li><a href="https://github.com/serde-rs/serde/commit/24614e44bff5466057e46c55394bac3ae20142c4"><code>24614e4</code></a> Add regression test for issue <a href="https://redirect.github.com/serde-rs/serde/issues/2565">#2565</a></li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206">compare view</a></li> </ul> </details> <br /> Updates `serde_json` from 1.0.121 to 1.0.124 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>v1.0.124</h2> <ul> <li>Fix a bug in processing string escapes in big-endian architectures (<a href="https://redirect.github.com/serde-rs/json/issues/1173">#1173</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> <h2>v1.0.123</h2> <ul> <li>Optimize string parsing by applying SIMD-within-a-register: 30.3% improvement on <a href="https://github.com/miloyip/nativejson-benchmark/blob/v1.0.0/data/twitter.json">twitter.json</a> from 613 MB/s to 799 MB/s (<a href="https://redirect.github.com/serde-rs/json/issues/1161">#1161</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> <h2>v1.0.122</h2> <ul> <li>Support using <code>json!</code> in no-std crates (<a href="https://redirect.github.com/serde-rs/json/issues/1166">#1166</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/cf771a0471dd797b6fead77e767f2f7943740c98"><code>cf771a0</code></a> Release 1.0.124</li> <li><a href="https://github.com/serde-rs/json/commit/8b314a77bf57ad8d6089536fea1b3c3b303cba92"><code>8b314a7</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1173">#1173</a> from iex-rs/fix-big-endian</li> <li><a href="https://github.com/serde-rs/json/commit/8eba7863b126584f4b9a5b1d3cc4cbc0d0f59976"><code>8eba786</code></a> Fix skip_to_escape on BE architectures</li> <li><a href="https://github.com/serde-rs/json/commit/2cab07e68607ab0e11c3a8b0461a472c37886210"><code>2cab07e</code></a> Release 1.0.123</li> <li><a href="https://github.com/serde-rs/json/commit/346189a524694b98b92ccccb07775868d34b144c"><code>346189a</code></a> Fix needless_borrow clippy lint in new control character test</li> <li><a href="https://github.com/serde-rs/json/commit/859ead8e6d60f4eaed97f7ac2b18f879bec5afe5"><code>859ead8</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1161">#1161</a> from iex-rs/vectorized-string-parsing</li> <li><a href="https://github.com/serde-rs/json/commit/e43da5ee0e64819972f08254e8ce799796238791"><code>e43da5e</code></a> Immediately bail-out on empty strings</li> <li><a href="https://github.com/serde-rs/json/commit/8389d8a11293616ce5a4358651aede271871248d"><code>8389d8a</code></a> Don't run the slow algorithm from the beginning</li> <li><a href="https://github.com/serde-rs/json/commit/1f0dcf791ab1756d7ad07c20889e50bd9a7887fb"><code>1f0dcf7</code></a> Allow clippy::items_after_statements</li> <li><a href="https://github.com/serde-rs/json/commit/a95d6df9d08611c9a11ac6524903d693921b8eae"><code>a95d6df</code></a> Big endian support</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.121...v1.0.124">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79e9aa5 - Browse repository at this point
Copy the full SHA 79e9aa5View commit details -
ci: Paused
cmd-action
commenter (#5287)Paused the action which comments on every command starting with `bot ` until we can fix all the commands which are not working.
Configuration menu - View commit details
-
Copy full SHA for aca25a0 - Browse repository at this point
Copy the full SHA aca25a0View commit details -
polkadot-node-core-pvf-common
: Fix test compilation error (#5310)This crate only uses `tempfile` on linux but includes it unconditionally in its `Cargo.toml`. It also sets `#![deny(unused_crate_dependencies)]`. This leads to an hard error to anything that is not Linux. This PR fixes this error. I am wondering why CI didn't catch that. Shouldn't the test at least be compiled (but not run) on macOS?
Configuration menu - View commit details
-
Copy full SHA for 8e8dc61 - Browse repository at this point
Copy the full SHA 8e8dc61View commit details -
Hello I found several spelling errors. Br, Elias.
Configuration menu - View commit details
-
Copy full SHA for bc22f08 - Browse repository at this point
Copy the full SHA bc22f08View commit details -
Bump authoring duration for async backing to 2s. (#5195)
Should be safe on all production network. I noticed that Paseo needs to be updated, it is lacking behind in a couple of things. Execution environment parameters should be updated to those of Polkadot: ``` [ { MaxMemoryPages: 8,192 } { PvfExecTimeout: [ Backing 2,500 ] } { PvfExecTimeout: [ Approval 15,000 ] } ] ] ``` --------- Co-authored-by: eskimor <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 819a581 - Browse repository at this point
Copy the full SHA 819a581View commit details
Commits on Aug 13, 2024
-
Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
Bumps [libp2p-identity](https://github.com/libp2p/rust-libp2p) from 0.2.8 to 0.2.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/libp2p/rust-libp2p/releases">libp2p-identity's releases</a>.</em></p> <blockquote> <h2>libp2p-v0.53.2</h2> <p>See individual <a href="https://github.com/libp2p/rust-libp2p/blob/HEAD/CHANGELOG.md">changelogs</a> for details.</p> <h2>libp2p-v0.53.1</h2> <p>See individual <a href="https://github.com/libp2p/rust-libp2p/blob/HEAD/CHANGELOG.md">changelogs</a> for details.</p> <h2>libp2p-v0.53.0</h2> <p>The most ergonomic version of rust-libp2p yet!</p> <p>We've been busy again, with over <a href="https://github.com/libp2p/rust-libp2p/compare/libp2p-v0.52.0...master">250</a> PRs being merged into <code>master</code> since <code>v0.52.0</code> (excluding dependency updates).</p> <h2>Backwards-compatible features</h2> <p>Numerous improvements landed as patch releases since the <code>v0.52.0</code> release, for example a new, type-safe <a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4120"><code>SwarmBuilder</code></a> that also encompasses the most common transport protocols:</p> <pre lang="rust"><code>let mut swarm = libp2p::SwarmBuilder::with_new_identity() .with_tokio() .with_tcp( tcp::Config::default().port_reuse(true).nodelay(true), noise::Config::new, yamux::Config::default, )? .with_quic() .with_dns()? .with_relay_client(noise::Config::new, yamux::Config::default)? .with_behaviour(|keypair, relay_client| Behaviour { relay_client, ping: ping::Behaviour::default(), dcutr: dcutr::Behaviour::new(keypair.public().to_peer_id()), })? .build(); </code></pre> <p>The new builder makes heavy use of the type-system to guide you towards a correct composition of all transports. For example, it is important to compose the DNS transport as a wrapper around all other transports but before the relay transport. Luckily, you no longer need to worry about these details as the builder takes care of that for you! Have a look yourself if you dare <a href="https://github.com/libp2p/rust-libp2p/tree/master/libp2p/src/builder">here</a> but be warned, the internals are a bit wild :)</p> <p>Some more features that we were able to ship in <code>v0.52.X</code> patch-releases include:</p> <ul> <li><a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4325">stable QUIC implementation</a></li> <li>for rust-libp2p compiled to WASM running in the browser <ul> <li><a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4015">WebTransport support</a></li> <li><a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4248">WebRTC support</a></li> </ul> </li> <li><a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4156">UPnP implementation to automatically configure port-forwarding with ones gateway</a></li> <li><a href="https://redirect.github.com/libp2p/rust-libp2p/pull/4281">option to limit connections based on available memory</a></li> </ul> <p>We always try to ship as many features as possible in a backwards-compatible way to get them to you faster. Often times, these come with deprecations to give you a heads-up about what will change in a future version. We advise updating to each intermediate version rather than skipping directly to the most recent one, to avoid missing any crucial deprecation warnings. We highly recommend you stay up-to-date with the latest version to make upgrades as smooth as possible.</p> <p>Some improvments we unfortunately cannot ship in a way that Rust considers a non-breaking change but with every release, we attempt to smoothen the way for future upgrades.</p> <h2><code>#[non_exhaustive]</code> on key enums</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/libp2p/rust-libp2p/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=libp2p-identity&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c5f6b70 - Browse repository at this point
Copy the full SHA c5f6b70View commit details -
Create subsystem-benchmarks.yml (#5325)
Closes paritytech/ci_cd#1014 Adds subsystem-benchmarking in GHA (only works with temp label)
Configuration menu - View commit details
-
Copy full SHA for ae1b84d - Browse repository at this point
Copy the full SHA ae1b84dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7bd6b - Browse repository at this point
Copy the full SHA 0d7bd6bView commit details -
[Bot] Add prdoc generation (#5331)
Add a bot to automatically generate prdocs that have all the crates populated. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b78d795 - Browse repository at this point
Copy the full SHA b78d795View commit details -
StorageWeightReclaim: set to node pov size if higher (#5281)
This PR adds an additional defensive check to the reclaim SE. Since it can happen that we miss some storage accesses on other SEs pre-dispatch, we should double check that the bookkeeping of the runtime stays ahead of the node-side pov-size. If we discover a mismatch and the node-side pov-size is indeed higher, we should set the runtime bookkeeping to the node-side value. In cases such as #5229, we would stop including extrinsics and not run `on_idle` at least. cc @gui1117 --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 055eb53 - Browse repository at this point
Copy the full SHA 055eb53View commit details -
[Pools] Ensure members can always exit the pool gracefully (#4998)
Resolves paritytech-secops/srlabs_findings#412 ## Changes - Clear any dangling delegation when member is removed. - Agents need to be killed explicitly when pools are destroyed. - Member withdraw amount is max of their locked funds and the value of their points. --------- Co-authored-by: Gonçalo Pestana <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 42eb4ec - Browse repository at this point
Copy the full SHA 42eb4ecView commit details -
This PR performs minor code cleanup to reduce verbosity. Since the compiler has already optimized out indirect calls in the existing code, these changes improve readability but do not affect performance. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0cd577b - Browse repository at this point
Copy the full SHA 0cd577bView commit details
Commits on Aug 14, 2024
-
Migrate foreign assets v3::Location to v4::Location (#4129)
In the move from XCMv3 to XCMv4, the `AssetId` for `ForeignAssets` in `asset-hub-rococo` and `asset-hub-westend` was left as `v3::Location` to be later migrated to `v4::Location`. This is that migration PR. Because the encoding of `v3::Location` and `v4::Location` is the same, we don't need to do any data migration, the keys will still be decodable. The [original idea by Jan](paritytech/polkadot#7236) was to make the v4 changes in v3 since the ABI (the encoding/decoding) didn't change. Corroborated the ABI is the same iterating over all storage, the code is on [another branch](https://github.com/paritytech/polkadot-sdk/blob/cisco-assert-v3-v4-encodings-equal/cumulus/parachains/runtimes/assets/migrations/src/foreign_assets_to_v4/mod.rs). We will need a data migration when we want to update from `v4::Location` to `v5::Location` because of [the accepted RFC changing the NetworkId enum](polkadot-fellows/RFCs#108). I'll configure MBMs (Multi-Block Migrations) then and make the actual migration. Fixes #4128 --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for be74fe9 - Browse repository at this point
Copy the full SHA be74fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d944ac2 - Browse repository at this point
Copy the full SHA d944ac2View commit details -
[tests] dedup test code, add more tests, improve naming and docs (#5338)
This is mostly tests cleanup: - uses helper macro for generating teleport tests, - adds missing treasury tests, - improves naming and docs for transfer tests. - [x] does not need a PRDOC --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for e4f8a6d - Browse repository at this point
Copy the full SHA e4f8a6dView commit details -
Make ticket non-optional and add ensure_successful method to Consider…
…ation trait (#5359) Make ticket non-optional and add ensure_successful method to Consideration trait. Reverts the optional return ticket type for the new function introduced in [polkadot-sdk/4596](#4596) and adds a helper `ensure_successful` function for the runtime benchmarks. Since the existing FRAME pallet represents zero cost with a zero balance rather than `None` in an option, maintaining the ticket type as a non-optional balance is beneficial for backward compatibility and helps avoid unnecessary migrations.
Configuration menu - View commit details
-
Copy full SHA for 00946b1 - Browse repository at this point
Copy the full SHA 00946b1View commit details -
Fix OurViewChange small race (#5356)
Always queue OurViewChange event before we send view changes to our peers, because otherwise we risk the peers sending us a message that can be processed by our subsystems before OurViewChange. Normally, this is not really a problem because the latency of the ViewChange we send to our peers is way higher that our subsystem processing OurViewChange, however on testnets like versi where CPU is sometimes overcommitted this race gets triggered occasionally, so let's fix it by sending the messages in the right order. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 05a8ba6 - Browse repository at this point
Copy the full SHA 05a8ba6View commit details -
Beefy: add benchmarks for
report_fork_voting()
(#5188)Related to #4523 This PR adds benchmarks for `report_fork_voting()`. **Important: Even though the benchmarks are now available, we still use `Weight::MAX`. That's because I realized while working on this PR that there's still one missing piece. We should also check that the ancestry proof is optimal. I plan to do this in a future PR, hopefully the last one related to #4523.** --------- Co-authored-by: Branislav Kontur <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 81d8f0c - Browse repository at this point
Copy the full SHA 81d8f0cView commit details -
[CI] Fix prdoc command (#5358)
Changes: - Run the prdoc command in a docker container since otherwise the set-up-gh script wont work. - Take try-runtime snapshot at night to avoid spamming the node with snapshot jobs at day. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8c2944 - Browse repository at this point
Copy the full SHA d8c2944View commit details -
Unify
no_genesis
check (#5360)The same exact `matches!()` was duplicated in `Configuration::no_genesis()` method and inline in full node parts creation. Since this is the same exact logic and reason, it makes sense to de-duplicate them. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a9396f - Browse repository at this point
Copy the full SHA 5a9396fView commit details -
[Pools] Fix issues with member migration to
DelegateStake
(#4822)## Context Pool members using the old `TransferStake` strategy were able to transfer all their funds to the pool. With `DelegateStake` changes, we want to ensure similar behaviour by allowing members to delegate all their stake to the pool. ## Changes - Ensure all the balance including ED of an account can be delegated (and used in the pool) by adding a provider for delegators. - Gates calls that mutates the pool or pool member if they are in unmigrated state. Closes paritytech-secops/srlabs_findings#409. - Adds remote test to migrate all pools and members to `DelegateStake` which can be used with `Kusama` and `Polkadot` runtime state. closes #4629. - Add new runtime apis to read pool and member balance. ## Addressing possible migration errors Pool members migrating can run into two types of errors: - Already Staking: If the pool member is already staking, we cannot migrate them to `DelegateStake` since this may mean they are able to use the same staked funds in the pool. Users would need to withdraw all their funds from staking, in order to migrate their pool funds. - Pool contribution below ED: For these cases transfer from pool account to member account would fail. The affected users can top up their accounts and redo migration. Another error that was earlier possible was when member's free balance is below ED. This PR adds a provider to delegator allowing all user balance including ED can be contributed towards the pool. This helps `1095` accounts in Polkadot and `41` accounts in Kusama to migrate now which would have earlier failed. ## Results from RemoteExternalities Tests. ### Kusama `Migration stats: success: 3017, direct_stakers: 361, unexpected_errors: 0` ### Polkadot `Migration stats: success: 42859, direct_stakers: 643, unexpected_errors: 0` ## TODO - [x] Add runtime api for member total balance. - [x] New [issue](#5009) to reap pool members with contribution below ED. - [x] Add provider for delegators so whole balance including ED can be held while contributing to pools. - [x] Gate all pool extrinsics if pool/member is in non-migrated state. --------- Co-authored-by: Gonçalo Pestana <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for feacf2f - Browse repository at this point
Copy the full SHA feacf2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f4274 - Browse repository at this point
Copy the full SHA 53f4274View commit details
Commits on Aug 15, 2024
-
[Pools] fix derivation of pool account (#4999)
closes paritytech-secops/srlabs_findings#408. This fixes how ProxyDelegator accounts are derived but may cause issues in Westend since it would use the old derivative accounts. Does not affect Polkadot/Kusama as this pallet is not deployed to them yet. --------- Co-authored-by: Gonçalo Pestana <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ebf4f8d - Browse repository at this point
Copy the full SHA ebf4f8dView commit details -
[Coretime] Always include UnpaidExecution, not just when revenue is >…
… 0 (#5369) The NotifyRevenue XCM from relay to coretime chain fails to pass the barrier when revenue is 0. https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L401 pushes notifyrevenue onto an [empty vec](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L361) when `revenue == 0`, so it never explicitly requests unpaid execution, because that happens only in [the block where revenue is `> 0`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L387). This will need to be backported to 1.14 when merged.
Configuration menu - View commit details
-
Copy full SHA for 78c3daa - Browse repository at this point
Copy the full SHA 78c3daaView commit details -
Bump trie-db from 0.29.0 to 0.29.1 (#5231)
Bumps [trie-db](https://github.com/paritytech/trie) from 0.29.0 to 0.29.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/paritytech/trie/commit/48fcfa99c439949f55d29762e35f8793113edc91"><code>48fcfa9</code></a> memory-db: update parity-util-mem (<a href="https://redirect.github.com/paritytech/trie/issues/166">#166</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/02b030a24bc60d46ed7f156888bdbbed6498b216"><code>02b030a</code></a> Prepare trie-db 0.24.0 release (<a href="https://redirect.github.com/paritytech/trie/issues/163">#163</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/aff1cbac8f03e8dc7533263b374dc0fcd17444ad"><code>aff1cba</code></a> Introduce trie level cache & recorder (<a href="https://redirect.github.com/paritytech/trie/issues/157">#157</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/aa3168d6de01793e71ebd906d3a82ae4b363db59"><code>aa3168d</code></a> Bump actions/checkout from 2 to 3 (<a href="https://redirect.github.com/paritytech/trie/issues/160">#160</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/d597275768f4796417c7fc9f8ad64f9b26be14d8"><code>d597275</code></a> Add GHA to dependabot and CODEOWNERS (<a href="https://redirect.github.com/paritytech/trie/issues/159">#159</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/5c9267c1133000aa41a5983d8acd6d0968ab8032"><code>5c9267c</code></a> test prefix seek more precisely (<a href="https://redirect.github.com/paritytech/trie/issues/158">#158</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/f64e1b0a8ced1b4b574d2b705202bf790d4394e4"><code>f64e1b0</code></a> Do not check for root in <code>TrieDB</code> and <code>TrieDBMut</code> constructors (<a href="https://redirect.github.com/paritytech/trie/issues/155">#155</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/8d5b8675fcc8ecc8648206d08f2e4c06ab489593"><code>8d5b867</code></a> Update dependencies. (<a href="https://redirect.github.com/paritytech/trie/issues/154">#154</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/fac100cbf49c197c49d102f12040bccbfa38827e"><code>fac100c</code></a> Adding support for eip-1186 proofs (<a href="https://redirect.github.com/paritytech/trie/issues/146">#146</a>)</li> <li><a href="https://github.com/paritytech/trie/commit/2e1541e44989f24cec5dbe3081c7cecf00d8b509"><code>2e1541e</code></a> Fix hex trace output (<a href="https://redirect.github.com/paritytech/trie/issues/153">#153</a>)</li> <li>Additional commits viewable in <a href="https://github.com/paritytech/trie/compare/trie-db-v0.29.0...reference-trie-v0.29.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=trie-db&package-manager=cargo&previous-version=0.29.0&new-version=0.29.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e91f146 - Browse repository at this point
Copy the full SHA e91f146View commit details -
Update Identity pallet README.md (#5183)
Update Identity pallet README.md according to the up-to-date docs, particularly to explain the _username_ concept of the pallet. --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 048f4b8 - Browse repository at this point
Copy the full SHA 048f4b8View commit details -
Aura: Ensure we are building on each relay chain fork (#5352)
We only want to build one block per slot for Aura on parachains. However, we still need to build on each relay chain fork, which is using the same slot. Closes: #5349 --------- Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 63bf73d - Browse repository at this point
Copy the full SHA 63bf73dView commit details -
Correct some typos in crates' descriptions (#5262)
Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a6dffe3 - Browse repository at this point
Copy the full SHA a6dffe3View commit details -
fix visibility for
pallet_nfts
types used as call arguments (#3634)fix #3631 Types which are impacted and fixed here are `ItemTip`, `PriceWithDirection`, `PreSignedMint`, `PreSignedAttributes`. Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 069f8a6 - Browse repository at this point
Copy the full SHA 069f8a6View commit details -
Update links in the documentation (#5175)
- Where applicable, use a regular [`reference`] instead of `../../../reference/index.html`. - Typos. - Update a link to `polkadot-evm` which has moved out of the monorepo. - ~~The link specification for `chain_spec_builder` is invalid~~ (actually it was valid) - it works fine without it. Part of paritytech/eng-automation#10
Configuration menu - View commit details
-
Copy full SHA for b5029eb - Browse repository at this point
Copy the full SHA b5029ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41a679c - Browse repository at this point
Copy the full SHA 41a679cView commit details -
allow for
u8
to be used as hold/freeze reason (#5348)..without needing to provide your own `newtype` around it. This will allow `type Reason = u8` to be used as `FreezeReason` and `HoldReason`, which I think is a nice simplification if one doens't want to deal with the complications. At the same time, it is a bit of an anti-pattern. Putting it out there to check people's vibes.
Configuration menu - View commit details
-
Copy full SHA for 90c91b1 - Browse repository at this point
Copy the full SHA 90c91b1View commit details -
Update Readme of the
polkadot
crate (#5326)- Typos. - Those telemetry links like https://telemetry.polkadot.io/#list/Kusama didn't seem to properly point to a proper list (anymore?) - updated them. - Also looks like it was trying to use rust-style linking instead of markdown linking, changed that. - Relative links do not work on crates.io - updated to absolute, similarly as some already existing links, such as contribution guidelines.
Configuration menu - View commit details
-
Copy full SHA for 843c4db - Browse repository at this point
Copy the full SHA 843c4dbView commit details
Commits on Aug 16, 2024
-
Fix zombienet bridges test (#5373)
After #4129, a zombienet bridge test was broken. This is because XCMv4 locations have an array in the `interior` field, which also has to appear in PJS. --------- Co-authored-by: Serban Iorga <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 80c3c1f - Browse repository at this point
Copy the full SHA 80c3c1fView commit details -
More logs in
is_potential_spam
fromdispute-coordinator
(#5252)Add more logs in `is_potential_spam` revealing why a statement was marked as a spam. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dbd194a - Browse repository at this point
Copy the full SHA dbd194aView commit details -
approval-distribution: Fix handling of conclude (#5375)
After 0636ffd approval-distribution did not terminate anymore if Conclude signal was received. This should have been caught by the subsystem tests, but it wasn't because the subsystem is also exiting on error when the channels are dropped so the test overseer was dropped which made the susbystem exit and masked the problem. This pr fixes both the test and the subsystem. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4780e3d - Browse repository at this point
Copy the full SHA 4780e3dView commit details -
Remove redundant minimal template workspace (#5330)
This removes the workspace of the minimal template, which (I think) is redundant. The other two templates do not have such a workspace. The synchronized template created [it's own workspace](https://github.com/paritytech/polkadot-sdk-minimal-template/blob/master/Cargo.toml) anyway, and the new readme replaced the old docs contained in `lib.rs`. Closes paritytech/polkadot-sdk-minimal-template#11 Silent because the crate was private.
Configuration menu - View commit details
-
Copy full SHA for 7426788 - Browse repository at this point
Copy the full SHA 7426788View commit details -
Fix doc: start_destroy doesn't need asset to be frozen (#5204)
Fix #5184 `owner` can set himself as a `freezer` and freeze the asset so requirement is not really needed. And requirement is not implemented. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd522b8 - Browse repository at this point
Copy the full SHA fd522b8View commit details
Commits on Aug 18, 2024
-
Replace unnecessary
&mut self
with&self
in `BlockImport::import_…Configuration menu - View commit details
-
Copy full SHA for feac7a5 - Browse repository at this point
Copy the full SHA feac7a5View commit details -
binary-merkle-tree: Do not spam test output (#5376)
The CI isn't happy with the amount of output: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7035621/raw --------- Co-authored-by: Shawn Tabrizi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3fe22d1 - Browse repository at this point
Copy the full SHA 3fe22d1View commit details
Commits on Aug 19, 2024
-
## Before <img width="320px" src="https://github.com/user-attachments/assets/27c4c50b-632b-4a3b-a154-0e828a1ac650"/> ## After <img width="320px" src="https://github.com/user-attachments/assets/314954fa-7f49-415d-82dd-a9a99983a283"/>
Configuration menu - View commit details
-
Copy full SHA for a4b5159 - Browse repository at this point
Copy the full SHA a4b5159View commit details -
Fix publishing of the
chain-spec-builder
image (#5387)This PR fixes the issue with the publishing flow of the `chain-speck-builder` image Closes: paritytech/release-engineering#219
Configuration menu - View commit details
-
Copy full SHA for 946afaa - Browse repository at this point
Copy the full SHA 946afaaView commit details
Commits on Aug 20, 2024
-
Fix leases with gaps and time slice calculation in
MigrateToCoretime
(#5380) Backport fixes from polkadot-fellows/runtimes#426
Configuration menu - View commit details
-
Copy full SHA for 37c2027 - Browse repository at this point
Copy the full SHA 37c2027View commit details -
approval-distribution: Fix preallocation of ApprovalEntries (#5411)
We preallocated the approvals field in the ApprovalEntry by up to a factor of two in the worse conditions, since we can't have more than 6 approvals and candidates.len() will return 20 if you have just the 20th bit set. This adds to a lot of wasted memory because we have an ApprovalEntry for each assignment we received This was discovered while running rust jemalloc-profiling with the steps from here: https://www.magiroux.com/rust-jemalloc-profiling/ Just with this optimisation approvals subsystem-benchmark memory usage on the worst case scenario is reduced from 6.1GiB to 2.4 GiB, even cpu usage of approval-distribution decreases by 4-5%. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f239aba - Browse repository at this point
Copy the full SHA f239abaView commit details -
Fix mmr zombienet test (#5417)
Fixes #4309 If a new block is generated between these 2 lines: ``` const proof = await apis[nodeName].rpc.mmr.generateProof([1, 9, 20]); const root = await apis[nodeName].rpc.mmr.root() ``` we will try to verify a proof for the previous block with the mmr root at the current block. Which will fail. So we generate the proof and get the mmr root at block 21 for consistency.
Configuration menu - View commit details
-
Copy full SHA for 73e2316 - Browse repository at this point
Copy the full SHA 73e2316View commit details -
Migrated
docs
scripts to GitHub actions (#5345)Migrated the following scripts to GHA - test-doc - test-rustdoc - build-rustdoc - build-implementers-guide - publish-rustdoc (only runs when `master` is modified) Resolves paritytech/ci_cd#1016 --- Some questions I have: - Should I remove the equivalent scripts from the `gitlab-ci` files? --------- Co-authored-by: Alexander Samusev <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 717bbb2 - Browse repository at this point
Copy the full SHA 717bbb2View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ca3d2e - Browse repository at this point
Copy the full SHA 5ca3d2eView commit details -
docs: Fix beefy primitives link in beefy README (#5428)
Just fixing the beefy primitives link to the right one after moving these primitives to `consensus`
Configuration menu - View commit details
-
Copy full SHA for 646e4f7 - Browse repository at this point
Copy the full SHA 646e4f7View commit details -
peerstore: Clarify peer report warnings (#5407)
This PR aims to make the logging from the peer store a bit more clear. In the past, we aggressively produced warning logs from the peer store component, even in cases where the reputation change was not malicious. This has led to an extensive number of logs, as well to node operator confusion. In this PR, we produce a warning message if: - The peer crosses the banned threshold for the first time. This is the actual reason of a ban - The peer misbehaves again while being banned. This may happen during a batch peer report cc @paritytech/networking Part of: #5379. --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b17f0f - Browse repository at this point
Copy the full SHA 8b17f0fView commit details
Commits on Aug 22, 2024
-
Add the Polkadot Coretime chain-spec (#5436)
Add the Polkadot Coretime chain-spec to the directory with the other system chain-specs. This is the chain-spec used at genesis and for which the genesis head data was generated. It is also included in the assets for fellowship [release v1.3.0](https://github.com/polkadot-fellows/runtimes/releases/tag/v1.3.0)
Configuration menu - View commit details
-
Copy full SHA for dce789d - Browse repository at this point
Copy the full SHA dce789dView commit details -
[Backport] Version bumps and prdoc reorgs from stable2407-1 (#5374)
This PR backports regular version bumps and `prdoc` reorganisation from the `stable2407` release branch to master
Configuration menu - View commit details
-
Copy full SHA for e600b74 - Browse repository at this point
Copy the full SHA e600b74View commit details -
Don't disconnect on invalid imports. (#5392)
There are numerous reasons for invalid imports, most of them would likely be caused by bugs. On the other side, dispute distribution handles all connections fairly, thus there is little harm in keeping a problematic connection open. --------- Co-authored-by: eskimor <[email protected]> Co-authored-by: ordian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b2ec017 - Browse repository at this point
Copy the full SHA b2ec017View commit details
Commits on Aug 23, 2024
-
Remove the need to wait for target block header in warp sync implemen…
…tation (#5431) I'm not sure if this is exactly what #3537 meant, but I think it should be fine to wait for relay chain before initializing parachain node fully, which removed the need for background task and extra hacks throughout the stack just to know where warp sync should start. Previously there were both `WarpSyncParams` and `WarpSyncConfig`, but there was no longer any point in having two data structures, so I simplified it to just `WarpSyncConfig`. Fixes #3537
Configuration menu - View commit details
-
Copy full SHA for 6d819a6 - Browse repository at this point
Copy the full SHA 6d819a6View commit details -
Update OpenZeppelin template documentation (#5398)
# Description Updates `template.rs` to reflect the two OZ templates available and a short description # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable) --------- Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4ffccac - Browse repository at this point
Copy the full SHA 4ffccacView commit details -
Add initial version of
pallet_revive
(#5293)This is a heavily modified and stripped down version of `pallet_contracts`. We decided to fork instead of extend the old pallet. Reasons for that are: - There is no benefit of supporting both on the same pallet as the intended payload for the new pallet (recompiled YUL) will be using a different ABI. - It is much easier since it allows us to remove all the code that was necessary to support Wasm and focus fully on running cross compiled YUL contracts. **The code is reviewable but can't be merged because it depends on an unreleased version of PolkaVM via git.** ## Current state All tests are passing and the code is not quick and dirty but written to last. The work is not finished, though. It is included in the `kitchensink-runtime` and a node can be built. However, we merge early in order to be able to start testing other components as early as possible. Outstanding changes are tracked here and will be merged separately: #5308 ## Syscall Interface The syscall interface is best explored by generating the docs of this crate and looking at the `SyscallDoc` trait. Arguments are passed in registers a0-a5 in the order they are listed. If there are more than 6 arguments (call, instantiate) a pointer to a packed struct of the arguments is expected as the only argument. I plan to create variants of those syscalls with less arguments specifically for YUL. Functions are just referenced by their name as ASCII within the PolkaVM container. Rather than by a syscall number as it was the case in the last implementation. ## Changes vs. `pallet_contracts` The changes are too numerous to list them all here. This is an incomplete list: - Use PolkaVM instead of wasmi to execute contracts - Made Runtime generic over a new `Memory` trait as we can't map memory directly on PolkaVM anymore - No static verification on code upload. Everything is a determinstic runtime failure - Removed all migrations and reset the pallet version - Removed the nonce storage item and instead use the deployers account nonce to generate a unique trie - We now bump the deployers account nonce on contract instantiation to they are bumped even within a batch transaction - Removed the instantiation nonce host function: We should add a new `instantiate` variant as a replacement for thos - ContractInfoOf of uses the indentity hasher now - Remove the determinism feature: User of that feature should switch to soft floats - The `unstable` attribute has been replaced by a `api_version` attribute to declare at which version an API became available - leaving out that attribute makes the API effectively unstable - a new `api_version` field on the CodeInfo makes sure that old contracts can't access new APIs (necessary due to lack of static verification. - Added a `behaviour_version` field to CodeInfo that can used if we need to introduce breaking changes and keep the old behaviour for existing contracts - Unified storage vs. transient and fixed vs. variable sized keys all into one set of multiplexing host functions - Removed all contract observeable limits from the `Config` trait and instead hardcode them - Removed the Schedule - Removed all deprecated host functions - Simplify chain extension as preperation for making it a pre-compile --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 559fa1d - Browse repository at this point
Copy the full SHA 559fa1dView commit details -
Improve the appearance of crates on
crates.io
(#5243)## Context Currently, many crates have no readme files, even though they are public and available on crates.io. Others have just a couple of words that does not look super presentable. Even though probably nobody starts a journey with `polkadot-sdk` or its documentation with a readme of a random low-level crate, I think it would look more mature to have a little better readmes there. So, in an attempt to improve [the aesthetics](paritytech/eng-automation#10) of `polkadot-sdk`, I propose a set of consistent, branded, better-looking readmes for all published crates. ## What's inside - ~~New readme files for published crates.~~ - A python script to generate new readmes, for the crates that have none. - It will skip crates that do have a readme, and private crates. - Added a new image asset to the repo - logo with a background. - The main readme of the repo uses a [nice trick](https://github.com/paritytech/polkadot-sdk/blob/ce6938ae92b77b54aa367e6d367a4d490dede7c4/README.md?plain=1#L4-L5) to accompany both light and dark modes - but that doesn't work on `crates.io` so a single logo with a background is needed. ## Example ### Current ![Screenshot 2024-08-04 at 16 13 36](https://github.com/user-attachments/assets/3ae0881d-0f40-4614-9d2c-3c95029f0820) ### Changed ![Screenshot 2024-08-04 at 16 12 28](https://github.com/user-attachments/assets/fa7eadc8-aec8-4f77-84d9-54d63ce189cd)
Configuration menu - View commit details
-
Copy full SHA for c66f7bd - Browse repository at this point
Copy the full SHA c66f7bdView commit details -
Change the chain to Rococo in the parachain template Zombienet config (…
…#5279) Following this: paritytech/polkadot-sdk-parachain-template#11 --------- Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9fecd89 - Browse repository at this point
Copy the full SHA 9fecd89View commit details -
[bridges] Prune messages from confirmation tx body, not from the on_i…
…dle (#5006) (Please, do not merge until SA, reverted and restored of #4944) Original PR with more context: paritytech/parity-bridges-common#2211 Relates to: paritytech/parity-bridges-common#2210 ## TODO - [x] fresh weighs for `pallet_bridge_messages` - [x] add `try_state` for `pallet_bridge_messages` which checks for unpruned messages - relates to the [comment](paritytech/parity-bridges-common#2211 (comment)) - [x] ~prepare migration, that prunes leftovers, which would be pruned eventually from `on_idle` the [comment](paritytech/parity-bridges-common#2211 (comment) can be done also by `set_storage` / `kill_storage` or with `OnRuntimeUpgrade` implementatino when `do_try_state_for_outbound_lanes` detects problem. ## Open question - [ ] Do we really need `oldest_unpruned_nonce` afterwards? - after the runtime upgrade and when `do_try_state_for_outbound_lanes` pass, we won't need any migrations here - we won't even need `do_try_state_for_outbound_lanes` - please check comments bellow: #4944 (comment) --------- Signed-off-by: Branislav Kontur <[email protected]> Co-authored-by: Serban Iorga <[email protected]> Co-authored-by: Svyatoslav Nikolsky <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for e4ffba6 - Browse repository at this point
Copy the full SHA e4ffba6View commit details -
Reactive syncing metrics (#5410)
This PR untangles syncing metrics and makes them reactive, the way metrics are supposed to be in general. Syncing metrics were bundled in a way that caused coupling across multiple layers: justifications metrics were defined and managed by `ChainSync`, but only updated periodically on tick in `SyncingEngine`, while actual values were queried from `ExtraRequests`. This convoluted architecture was hard to follow when I was looking into #5333. Now metrics that correspond to each component are owned by that component and updated as changes are made instead of on tick every 1100ms. This does add some annoying boilerplate that is a bit harder to maintain, but it separates metrics more nicely and if someone queries them more frequently will give arbitrary resolution. Since metrics updates are just atomic operations I do not expect any performance impact of these changes. Will add prdoc if changes look good otherwise. P.S. I noticed that importing requests (and corresponding metrics) were not cleared ever since corresponding code was introduced in dc41558#r145518721 and I left it as is to not change the behavior, but it might be something worth fixing. cc @dmitry-markin --------- Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4057ccd - Browse repository at this point
Copy the full SHA 4057ccdView commit details -
Remove panic, as proof is invalid. (#5427)
`validity_vote` function is also called from `import_statement` not only from `import_candidate`. The proof still holds if we assume seconded statements always come before valid statements, which should be the case but is not actually enforced by this module at all. On top of this the proof is not local. Co-authored-by: eskimor <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d26d7f1 - Browse repository at this point
Copy the full SHA d26d7f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c2a25 - Browse repository at this point
Copy the full SHA b3c2a25View commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 13d43bb - Browse repository at this point
Copy the full SHA 13d43bbView commit details -
pallet-collator-selection: correctly register weight in
new_session
(……#5430) The `pallet-collator-selection` is not correctly using the weight for the [new_session](https://github.com/blockdeep/pallet-collator-staking/blob/main/src/benchmarking.rs#L350-L353) function. The first parameter is the removed candidates, and the second one the original number of candidates before the removal, but both values are swapped.
Configuration menu - View commit details
-
Copy full SHA for 475432f - Browse repository at this point
Copy the full SHA 475432fView commit details
Commits on Aug 25, 2024
-
Add symlinks for code of conduct and contribution guidelines (#5447)
Addresses [this](paritytech/eng-automation#10 (comment)). > Another side note is the checkmarks in https://github.com/paritytech/polkadot-sdk/community. It seems like even though we have `CONTRIBUTING.md` in `/docs` it is not picked up in this list. I am not even sure what is the benefit of following these standards, but it is probably for the best to do it.
Configuration menu - View commit details
-
Copy full SHA for 91b5a49 - Browse repository at this point
Copy the full SHA 91b5a49View commit details -
Skip slot before creating inherent data providers during major sync (#…
…5344) # Description Moves `create_inherent_data_provider` after checking if major sync is in progress. ## Integration Change is internal to sc-consensus-slots. It should be no-op unless someone is using fork of this SDK. ## Review Notes Motivation for this change is to avoid calling `create_inherent_data_providers` if it's result is going to be discarded anyway during major sync. This has potential to speed up node operations during major sync by not calling possibly expensive `create_inherent_data_provider`. TODO: labels T0-node D0-simple TODO: there is no tests for `Slots`, should I add one for this case? # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [ ] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
Configuration menu - View commit details
-
Copy full SHA for 178e699 - Browse repository at this point
Copy the full SHA 178e699View commit details
Commits on Aug 26, 2024
-
MaybeConsideration
extension trait forConsideration
(#5384)Introduce `MaybeConsideration` extension trait for `Consideration`. The trait allows for the management of tickets that may represent no cost. While the `MaybeConsideration` still requires proper handling, it introduces the ability to determine if a ticket represents no cost and can be safely forgotten without any side effects. The new trait is particularly useful when a consumer expects the cost to be zero under certain conditions (e.g., when the proposal count is below a threshold N) and does not want to store such consideration tickets in storage. The extension approach allows us to avoid breaking changes to the existing trait and to continue using it as a non-optional version for migrating pallets that utilize the `Currency` and `fungible` traits for `holds` and `freezes`, without requiring any storage migration.
Configuration menu - View commit details
-
Copy full SHA for ad0de74 - Browse repository at this point
Copy the full SHA ad0de74View commit details -
Add build options to the srtool build step (#4956)
This PR adds possibility to set BUILD_OPTIONS to the "Srtool Build" step in the release pipeline while building runtimes. Colses: paritytech/release-engineering#213 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: EgorPopelyaev <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3cbefaf - Browse repository at this point
Copy the full SHA 3cbefafView commit details -
Sync status refactoring (#5450)
As I was looking at the coupling between `SyncingEngine`, `SyncingStrategy` and individual strategies I noticed a few things that were unused, redundant or awkward. The awkward change comes from paritytech/substrate#13700 where `num_connected_peers` property was added to `SyncStatus` struct just so it can be rendered in the informer. While convenient, the property didn't really belong there and was annoyingly set to `0` in some strategies and to `num_peers` in others. I have replaced that with a property on `SyncingService` that already stored necessary information internally. Also `ExtendedPeerInfo` didn't have a working `Clone` implementation due to lack of perfect derive in Rust and while I ended up not using it in the refactoring, I included fixed implementation for it in this PR anyway. While these changes are not strictly necessary for #5333, they do reduce coupling of syncing engine with syncing strategy, which I thought is a good thing. Reviewing individual commits will be the easiest as usual. --------- Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd1aaa4 - Browse repository at this point
Copy the full SHA dd1aaa4View commit details -
[CI] Fix SemVer check base commit (#5361)
After seeing some cases of reported changes that did not happen by the merge request proposer (like #5339), it became clear that [this](https://github.com/orgs/community/discussions/59677) is probably the issue. The base commit of the SemVer check CI is currently using the *latest* master commit, instead of the master commit at the time when the MR was created. Trying to get the correct base commit now. For this to be debugged, i have to wait until another MR is merged into master. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b34d4a0 - Browse repository at this point
Copy the full SHA b34d4a0View commit details
Commits on Aug 27, 2024
-
Only log the propagating transactions when they are not empty (#5424)
This can make the log cleaner, especially when you specify `--log sync=debug`.
Configuration menu - View commit details
-
Copy full SHA for 6ecbde3 - Browse repository at this point
Copy the full SHA 6ecbde3View commit details -
Make the PR template a default for new PRs (#5462)
A follow-up to #5447 Instead of having an option to select a PR template (like is the case with issues), this change will make the one PR template we have the default, it will show up for every new PR. Also updated one link so it works properly in the PR body.
Configuration menu - View commit details
-
Copy full SHA for 5a84374 - Browse repository at this point
Copy the full SHA 5a84374View commit details -
Remove deprecated calls in cumulus-parachain-system (#5439)
Calls were written to be removed after June 2024. This PR removes them. This PR will break users using those calls. The call won't be decodable by the runtime, so it should fail early with no consequences. The functionality must be same as before, users will just need to use the calls in `System`.
Configuration menu - View commit details
-
Copy full SHA for f0323d5 - Browse repository at this point
Copy the full SHA f0323d5View commit details -
Bump the ci_dependencies group across 1 directory with 2 updates (#5401)
Bumps the ci_dependencies group with 2 updates in the / directory: [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) and [docker/build-push-action](https://github.com/docker/build-push-action). Updates `docker/setup-buildx-action` from 3.5.0 to 3.6.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/setup-buildx-action/releases">docker/setup-buildx-action's releases</a>.</em></p> <blockquote> <h2>v3.6.1</h2> <ul> <li>Check for malformed docker context by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/setup-buildx-action/pull/347">docker/setup-buildx-action#347</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/setup-buildx-action/compare/v3.6.0...v3.6.1">https://github.com/docker/setup-buildx-action/compare/v3.6.0...v3.6.1</a></p> <h2>v3.6.0</h2> <ul> <li>Create temp docker context if default one has TLS data loaded before creating a container builder by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/setup-buildx-action/pull/341">docker/setup-buildx-action#341</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/setup-buildx-action/compare/v3.5.0...v3.6.0">https://github.com/docker/setup-buildx-action/compare/v3.5.0...v3.6.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/setup-buildx-action/commit/988b5a0280414f521da01fcc63a27aeeb4b104db"><code>988b5a0</code></a> Merge pull request <a href="https://redirect.github.com/docker/setup-buildx-action/issues/347">#347</a> from crazy-max/skip-malformed-context</li> <li><a href="https://github.com/docker/setup-buildx-action/commit/2c215620b8bfc319fa4c45228e004e292677fd33"><code>2c21562</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/setup-buildx-action/commit/3382292cd51ea1cda5852caf2e65d8e7b3f1c2ca"><code>3382292</code></a> check for malformed docker context</li> <li><a href="https://github.com/docker/setup-buildx-action/commit/3d68780484996aa9d417bb9016193885cdf1f299"><code>3d68780</code></a> Merge pull request <a href="https://redirect.github.com/docker/setup-buildx-action/issues/341">#341</a> from crazy-max/docker-context-tls</li> <li><a href="https://github.com/docker/setup-buildx-action/commit/d069e98648dcd5f11d3f726983a778dcf30aeca0"><code>d069e98</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/setup-buildx-action/commit/8b850f86dc46ba7eb11e02c7d3db66aeb2b0f022"><code>8b850f8</code></a> create docker context if default one has TLS data loaded</li> <li>See full diff in <a href="https://github.com/docker/setup-buildx-action/compare/aa33708b10e362ff993539393ff100fa93ed6a27...988b5a0280414f521da01fcc63a27aeeb4b104db">compare view</a></li> </ul> </details> <br /> Updates `docker/build-push-action` from 6.5.0 to 6.7.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v6.7.0</h2> <ul> <li>Print info message for build summary support checks by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1211">docker/build-push-action#1211</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.6.1...v6.7.0">https://github.com/docker/build-push-action/compare/v6.6.1...v6.7.0</a></p> <h2>v6.6.1</h2> <ul> <li>Bump <code>@docker/actions-toolkit</code> from 0.37.0 to 0.37.1 in <a href="https://redirect.github.com/docker/build-push-action/pull/1205">docker/build-push-action#1205</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.6.0...v6.6.1">https://github.com/docker/build-push-action/compare/v6.6.0...v6.6.1</a></p> <h2>v6.6.0</h2> <ul> <li>Generate GitHub annotations for <a href="https://docs.docker.com/build/checks/">build checks</a> by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1197">docker/build-push-action#1197</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.35.0 to 0.37.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1196">docker/build-push-action#1196</a> <a href="https://redirect.github.com/docker/build-push-action/pull/1198">docker/build-push-action#1198</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.5.0...v6.6.0">https://github.com/docker/build-push-action/compare/v6.5.0...v6.6.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/5cd11c3a4ced054e52742c5fd54dca954e0edd85"><code>5cd11c3</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1211">#1211</a> from crazy-max/summary-info-message</li> <li><a href="https://github.com/docker/build-push-action/commit/0aba704831628413787ada4cf0e8f04d977f1d21"><code>0aba704</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/23c657a01f105567f668c7596ce8e5a038da2555"><code>23c657a</code></a> print info message for build summary support checks</li> <li><a href="https://github.com/docker/build-push-action/commit/16ebe778df0e7752d2cfcbd924afdbbd89c1a755"><code>16ebe77</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1205">#1205</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="https://github.com/docker/build-push-action/commit/646a62b4f2189bfb0b46bfa1676692e7bff6e4d7"><code>646a62b</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/d92ab1347f14b597b6d4a546737ec663aef4a184"><code>d92ab13</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.37.0 to 0.37.1</li> <li><a href="https://github.com/docker/build-push-action/commit/4f7cdeb0f05278b464e71357394bf2c61f94138e"><code>4f7cdeb</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1198">#1198</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="https://github.com/docker/build-push-action/commit/ad3cd774a4f620adb18ba3ba3fa178c73b624bd2"><code>ad3cd77</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/3efbc133663acf954bb07c2ab14201de1e1733a4"><code>3efbc13</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.36.0 to 0.37.0</li> <li><a href="https://github.com/docker/build-push-action/commit/2dbe91db48e489c125002fbd97678eaf1e0e563e"><code>2dbe91d</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1197">#1197</a> from crazy-max/build-checks</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/5176d81f87c23d6fc96624dfdbcd9f3830bbe445...5cd11c3a4ced054e52742c5fd54dca954e0edd85">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3301009 - Browse repository at this point
Copy the full SHA 3301009View commit details -
frame-omni-bencher maintenance (#5466)
Changes: - Set default level to `Info` again. Seems like a dependency update set it to something higher. - Fix docs to not use `--locked` since we rely on dependency bumps via cargo. - Add README with rust docs. - Fix bug where the node ignored `--heap-pages` argument. You can test the `--heap-pages` bug by running this command on master and then on this branch. Note that it should fail because of the very low heap pages arg: `cargo run --release --bin polkadot --features=runtime-benchmarks -- benchmark pallet --chain=dev --steps=10 --repeat=30 --wasm-execution=compiled --heap-pages=8 --pallet=frame-system --extrinsic="*"` --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: ggwpez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e7c334 - Browse repository at this point
Copy the full SHA 7e7c334View commit details -
Make
PendingConfigs
storage item public (#5467)## Description This PR changes `PendingConfigs` storage item's visibility from crate to public. This enable us to read it in our runtime. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d7becf - Browse repository at this point
Copy the full SHA 0d7becfView commit details -
Opening this PR to add our bootnodes for the IBP. These nodes are located in Santiago Chile, we own and manage the underlying hardware. If you need any more information please let me know. Commands to test: ``` ./polkadot --tmp --name "testing-bootnode" --chain kusama --reserved-only --reserved-nodes "/dns/kusama.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWJHhnF64TXSmyxNkhPkXAHtYNRy86LuvGQu1LTi5vrJCL" --no-hardware-benchmarks ./polkadot --tmp --name "testing-bootnode" --chain paseo --reserved-only --reserved-nodes "/dns/paseo.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWMdND5nwfCs5M2rfp5kyRo41BGDgD8V67rVRaB3acgZ53" --no-hardware-benchmarks ./polkadot --tmp --name "testing-bootnode" --chain polkadot --reserved-only --reserved-nodes "/dns/polkadot.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWEymrFRHz6c17YP3FAyd8kXS5gMRLgkW4U77ZJD2ZNCLZ" --no-hardware-benchmarks ./polkadot --tmp --name "testing-bootnode" --chain westend --reserved-only --reserved-nodes "/dns/westend.bootnode.stkd.io/tcp/30633/wss/p2p/12D3KooWHaQKkJiTPqeNgqDcW7dfYgJxYwT8YqJMtTkueSu6378V" --no-hardware-benchmarks ```
Configuration menu - View commit details
-
Copy full SHA for 7a2c537 - Browse repository at this point
Copy the full SHA 7a2c537View commit details -
Add feature to allow Aura collator to use full PoV size (#5393)
This PR introduces a feature that allows to optionally enable using the full PoV size. Technically, we're ready to enable it by default, but as corresponding runtime changes have not been propagated to the system parachain runtimes yet, doing so could put them at risk. On the other hand, there are teams that could benefit from it right now, and it makes no sense for them to wait for the fellowship release and everything. --------- Co-authored-by: Andrei Sandu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f90bfa6 - Browse repository at this point
Copy the full SHA f90bfa6View commit details
Commits on Aug 28, 2024
-
polkadot-parachain-bin: Remove contracts parachain (#5471)
Related to: #5210 Follow-up for #5288, as per this comment: #5288 (comment) I hope I understood this correctly.
Configuration menu - View commit details
-
Copy full SHA for 38fce08 - Browse repository at this point
Copy the full SHA 38fce08View commit details -
change try-runtime rpc domains (#5443)
as part of paritytech/devops/3502, try-runtime nodes were migrated to a new provider with a new domain address. The PR fixes all the references to try-runtime nodes on rococo, westend, kusama and polkadot networks. --------- Co-authored-by: ArshamTeymouri <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Niklas Adolfsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4be48c - Browse repository at this point
Copy the full SHA f4be48cView commit details -
Update approval-voting-regression-bench (#5504)
The accepted divergence rate of 1/1000 is excessive and leads to false positives especially after #4772 and #5042, so let's increase it to 1/100 since we do have some randomness in the system and there is no point in being that strict. Fixes: #5463 --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f0fd083 - Browse repository at this point
Copy the full SHA f0fd083View commit details -
rpc server: listen to
ipv6 socket
if available and `--experimental-……rpc-endpoint` CLI option (#4792) Close #3488, #4331 This changes/adds the following: 1. The default setting is that substrate starts a rpc server that listens to localhost both Ipv4 and Ipv6 on the same port. Ipv6 is allowed to fail because some platforms may not support it 2. A new RPC CLI option `--experimental-rpc-endpoint` which allow to configure arbitrary listen addresses including the port, if this is enabled no other interfaces are enabled. 3. If the local addr is not found for any of the sockets the server is not started throws an error. 4. Remove the deny_unsafe from the RPC implementations instead this is an extension to allow different polices for different interfaces/sockets such one may enable unsafe on local interface and safe on only the external interface. So for instance in this PR it's now possible to start up three RPC endpoints as follows: ``` $ polkadot --experimental-rpc-endpoint "listen-addr=127.0.0.1:9944,rpc-methods=unsafe" --experimental-rpc-endpoint "listen-addr=0.0.0.0:9945,rpc-methods=safe,rate-limit=100" --experimental-rpc-endpoint "listen-addr=[::1]:9944,optional=true" ``` #### Needs to be addressed ~1. Support binding to a random port if it's fails with the default stuff for backward compatible reasons~ ~2. How to sync that the rpc CLI params and that the rpc-listen-addr align, hard to maintain...~ ~3. Add similar warning prints for exposing unsafe methods on external interfaces..~ ~4. Inline todos + the hacky String conversion from rpc params.~ #### Cons with this PR Manual strings parsing impl more error-prone than relying on clap.... //cc @jsdw @BulatSaif @PierreBesson @bkchr --------- Co-authored-by: Sebastian Kunert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 09254eb - Browse repository at this point
Copy the full SHA 09254ebView commit details -
IBP Coretime Polkadot bootnodes (#5499)
✄ ----------------------------------------------------------------------------- Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in [this document](https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md) and fill out the sections below. Once you're ready to submit your PR for review, please delete this section and leave only the text under the "Description" heading. # Description *A concise description of what your PR is doing, and what potential issue it is solving. Use [Github semantic linking](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) to link the PR to an issue that must be closed once this is merged.* ## Integration *In depth notes about how this PR should be integrated by downstream projects. This part is mandatory, and should be reviewed by reviewers, if the PR does NOT have the `R0-Silent` label. In case of a `R0-Silent`, it can be ignored.* ## Review Notes *In depth notes about the **implementation** details of your PR. This should be the main guide for reviewers to understand your approach and effectively review it. If too long, use [`<details>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details)*. *Imagine that someone who is depending on the old code wants to integrate your new code and the only information that they get is this section. It helps to include example usage and default value here, with a `diff` code-block to show possibly integration.* *Include your leftover TODOs, if any, here.* # Checklist * [ ] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [ ] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) You can remove the "Checklist" section once all have been checked. Thank you for your contribution! ✄ ----------------------------------------------------------------------------- Co-authored-by: Dónal Murray <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef3a0d8 - Browse repository at this point
Copy the full SHA ef3a0d8View commit details -
Use umbrella crate for minimal template (#5155)
Co-authored-by: kianenigma <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9cf5e81 - Browse repository at this point
Copy the full SHA 9cf5e81View commit details -
A test is triggering a log error. But is correct and successful. This is a refactor without triggering the log error.
Configuration menu - View commit details
-
Copy full SHA for 97fa922 - Browse repository at this point
Copy the full SHA 97fa922View commit details -
polkadot-parachain: Add omni-node variant with u64 block number (#5269)
Related to #4787 The main changes in this PR are the following: - making the NodeSpec logic generic on the Block type - adding an omni-node variant with u64 block number Apart from this, the PR also moves some of the logic in `service.rs` to the `common` subfolder The omni-node variant with u64 block number is not used yet. We have to either expose the option in the CLI or to read the block number from the chain spec somehow. Will do it in a future PR.
Configuration menu - View commit details
-
Copy full SHA for c4ced11 - Browse repository at this point
Copy the full SHA c4ced11View commit details -
Bridge zombienet tests: remove old command (#5434)
Related to: #3176 This PR: - migrates test 0003 to the new bridges zombienet tests command **This test didn't work before and it still doesn't work. It was added at a time when we couldn't run it because we didn't have the scafolding. It needs to be fixed. For the moment we keep it in the repo as it is since the idea has value. But we don't run it in the CI. We can also decide to remove it in the future** - removes the old command for running bridge zombienet tests - updates the README
Configuration menu - View commit details
-
Copy full SHA for edd6f71 - Browse repository at this point
Copy the full SHA edd6f71View commit details -
Bump rustversion from 1.0.14 to 1.0.17 (#5405)
Bumps [rustversion](https://github.com/dtolnay/rustversion) from 1.0.14 to 1.0.17. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/rustversion/releases">rustversion's releases</a>.</em></p> <blockquote> <h2>1.0.17</h2> <ul> <li>Support Windows builds that have OUT_DIR prefixed with <code>\\?\</code> (<a href="https://redirect.github.com/dtolnay/rustversion/issues/51">#51</a>)</li> </ul> <h2>1.0.16</h2> <ul> <li>Resolve unexpected_cfgs warning (<a href="https://redirect.github.com/dtolnay/rustversion/issues/48">#48</a>)</li> </ul> <h2>1.0.15</h2> <ul> <li>Recognize $RUSTC_WRAPPER environment variable (<a href="https://redirect.github.com/dtolnay/rustversion/issues/47">#47</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/rustversion/commit/adb11fa32295a5d3df7b742e545f4e9b776f9bb3"><code>adb11fa</code></a> Release 1.0.17</li> <li><a href="https://github.com/dtolnay/rustversion/commit/875982000ea11f59a67564bf34c6f3255935b6e2"><code>8759820</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rustversion/issues/51">#51</a> from dtolnay/windows</li> <li><a href="https://github.com/dtolnay/rustversion/commit/cfafcd5906e6020ae67014e33a84446824301c95"><code>cfafcd5</code></a> Support OUT_DIR located in \?\ path on Windows</li> <li><a href="https://github.com/dtolnay/rustversion/commit/c7bc274d96fbde0fe3b3fd5a4a9ea1e0215b0ddb"><code>c7bc274</code></a> Release 1.0.16</li> <li><a href="https://github.com/dtolnay/rustversion/commit/746bf5af0dc5423574982ba2f479190b643c98fe"><code>746bf5a</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rustversion/issues/48">#48</a> from dtolnay/checkcfg</li> <li><a href="https://github.com/dtolnay/rustversion/commit/84f01fa8d731c51842848a4e4d27750cefd879e0"><code>84f01fa</code></a> Resolve unexpected_cfgs warning</li> <li><a href="https://github.com/dtolnay/rustversion/commit/70ca5ad8a2aba79053be803a4e70156b46e44028"><code>70ca5ad</code></a> Release 1.0.15</li> <li><a href="https://github.com/dtolnay/rustversion/commit/0fa74f583b1fff92ed6f48acad6509428f44ed1a"><code>0fa74f5</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rustversion/issues/47">#47</a> from dtolnay/rustcwrapper</li> <li><a href="https://github.com/dtolnay/rustversion/commit/51f46e2d2281dce75a8e4d46c0ed55f2ae3c4e33"><code>51f46e2</code></a> Apply RUSTC_WRAPPER</li> <li><a href="https://github.com/dtolnay/rustversion/commit/df7e51d0f01e06b2212c96f26cd04af5c59e1e39"><code>df7e51d</code></a> Explicitly install a Rust toolchain for cargo-outdated job</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/rustversion/compare/1.0.14...1.0.17">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rustversion&package-manager=cargo&previous-version=1.0.14&new-version=1.0.17)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f7e0ecc - Browse repository at this point
Copy the full SHA f7e0eccView commit details -
Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
Bumps [blake2b_simd](https://github.com/oconnor663/blake2_simd) from 1.0.1 to 1.0.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/oconnor663/blake2_simd/commit/1dfcf325200cf281d9313ae79734c828d914d241"><code>1dfcf32</code></a> version 1.0.2</li> <li><a href="https://github.com/oconnor663/blake2_simd/commit/b66d6b5124e7568bbb92f8a1f22e043ac8cded25"><code>b66d6b5</code></a> Bump constant_time_eq to 0.3 and MSRV to 1.66</li> <li><a href="https://github.com/oconnor663/blake2_simd/commit/d9ce189cb98e00b0a0653d8a9586ff12e5774202"><code>d9ce189</code></a> stop using MIPS for big-endian testing</li> <li><a href="https://github.com/oconnor663/blake2_simd/commit/9d338b55992a5e6a0411e2da7153ec654f70b213"><code>9d338b5</code></a> use <code>avoid-dev-deps</code> for the MSRV test</li> <li><a href="https://github.com/oconnor663/blake2_simd/commit/c347f493365a82bc4472a05609c68a1152439b44"><code>c347f49</code></a> update the assert_cmd test dependency to v2.0.8</li> <li>See full diff in <a href="https://github.com/oconnor663/blake2_simd/compare/1.0.1...1.0.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=blake2b_simd&package-manager=cargo&previous-version=1.0.1&new-version=1.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9423718 - Browse repository at this point
Copy the full SHA 9423718View commit details -
Remove pallet::getter usage from treasury (#4962)
ISSUE Link to the issue: #3326 Deliverables [Deprecation] remove pallet::getter usage from pallet-treasury --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4096ad7 - Browse repository at this point
Copy the full SHA 4096ad7View commit details -
Command bot GHA v2 - /cmd <cmd> (#5457)
Closes paritytech/product-engineering#93 - Deprecates old command bot bash scripts. New cmd implementation is re-written on Python - Deprecates `sync` command, which was never used - Benchmarks: - Uses new [frame-omni-bencher](https://crates.io/crates/frame-omni-bencher) - Simplifies usage to only providing a runtime and/or pallet name (even multiple runtimes or pallets) - Supports sub-modules (like `/cmd bench --runtime dev --pallet pallet_asset_conversion_ops`) - Can regenerate all weights with one command (substrate, polkadot, cumulus) for provided pallet(s) name - Adds [subweight](https://crates.io/crates/subweight-core) diff as a result of bench command
Configuration menu - View commit details
-
Copy full SHA for 8e0cefc - Browse repository at this point
Copy the full SHA 8e0cefcView commit details -
Fix benchmark failures when using
insecure_zero_ed
flag (#5354)Currently, when the pallet is compiled with the `insecure_zero_ed flag`, benchmarks fail because the minimum balance is set to zero. The PR aims to resolve this issue by implementing a placeholder value for the minimum balance when the `insecure_zero_ed` flag is active. it ensures that benchmarks run successfully regardless of whether this flag is used or not
Configuration menu - View commit details
-
Copy full SHA for 1c4141a - Browse repository at this point
Copy the full SHA 1c4141aView commit details -
CI: Add backporting bot (#4795)
Adds a bot that automatically opens MRs into the `stable2407` branch when the `A4-needs-backport` label is applied to a merged MR. TODO: - [x] ~~Settle on label vs error message trade-off~~ (resolved) docs: # Backporting This document explains how to backport a merged PR from `master` to one of the `stable*` branches. Backports should only be used to fix bugs or security issues - never to introduce new features. ## Steps 1. Fix a bug through a PR that targets `master`. 2. Add label `A4-needs-backport` to the PR. 4. Merge the PR into `master`. 5. Wait for the bot to open the backport PR. 6. Ensure the change is audited or does not need audit. 7. Merge the backport PR. The label can also be added after the PR is merged. ## Example For example here where the dev triggered the process by adding the label after merging: ![backport-ex2](https://github.com/user-attachments/assets/c7b686db-a0fe-41f1-9d6f-959a5a7097b1) --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5620196 - Browse repository at this point
Copy the full SHA 5620196View commit details
Commits on Aug 29, 2024
-
short-term fix for para inherent weight overestimation (#5082)
closes #849 ## Context For the background on this and the long-term fix, see #849 (comment). ## Changes * The weigh files are renamed from `runtime_(parachains|common).*` to `polkadot_runtime_(parachains|common).*`. The reason for it is the renaming introduced in #4633. The new weight command and files are generated now include `polkadot_` prefix. * The WeightInfo for `paras_inherent` now includes `enter_empty` which calculates the cost of processing an empty parachains inherent. This cost is subtracted dynamically when calculating other weights (so the other weights remain the same) ## Benefits See #849 (comment), but TL;DR is that we are not blocked on weights for scaling the number of validators and cores further. Resolved questions: - [x] why new benchmarks for westend are doing fewer db IOPS? Is it due polkadot-sdk update (db IOPS diff)? or the bench setup is no longer valid? https://github.com/polkadot-fellows/runtimes/blob/7723274a2c5cbb10213379271094d5180716ca7d/relay/polkadot/src/weights/runtime_parachains_paras_inherent.rs#L131-L196 Answer: see background section of #5270 TODOs: - [x] Rerun benchmarks for Rococo and Westend - [x] PRDoc --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for cc7ebe0 - Browse repository at this point
Copy the full SHA cc7ebe0View commit details -
[ci] Migrate checks to GHA (#5511)
PR migrates jobs `quick-benchmarks`, `cargo-clippy`, `check-try-runtime` and `check-core-crypto-features` from Gitlab to GitHub cc paritytech/ci_cd#1006 --------- Co-authored-by: Maksym H <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a67d623 - Browse repository at this point
Copy the full SHA a67d623View commit details -
Add an utility function to get the first timestamp of a slot (#5316)
# Description Add `starting_timestamp` function for `Slot` type. ## Integration This is an addition of public function to a type, so integration should be seamless for idiomatic use of Rust. ## Review Notes Since `Slot` is just a slot number, the it's starting timestamp depends on `SlotDuration` which is a parameter to the added function. This function can be seen as dual to existing `fn from_timestamp`. Because there is a potential for overflow, the return type is `Option`. Q1: should I introduce tests for in this crate and add cases for both case: overflow (`None`) and no overflow (`Some`)? Q2: How can I add labels? IMO they should be `T0-node` and `D0-easy` but I cannot add them using GH interface. # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [ ] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) --------- Co-authored-by: Squirrel <[email protected]> Co-authored-by: Davide Galassi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9374643 - Browse repository at this point
Copy the full SHA 9374643View commit details -
[CI] Fixup backport bot (#5517)
Changes: - Backport bot should just commit merge conflicts instead of failing.
Configuration menu - View commit details
-
Copy full SHA for ba48e4b - Browse repository at this point
Copy the full SHA ba48e4bView commit details -
inclusion: bench
enact_candidate
weight (#5270)On top of #5082. ## Background Previously, before #3479, we would [include](https://github.com/paritytech/polkadot-sdk/blame/75074952a859f90213ea25257b71ec2189dbcfc1/polkadot/runtime/parachains/src/builder.rs#L508C12-L508C44) the cost enacting the candidate into the cost of processing a single bitfield. [Now](https://github.com/paritytech/polkadot-sdk/blame/dd48544a573dd02da2082cec1dda7ce735e2e719/polkadot/runtime/parachains/src/builder.rs#L529) it is different, although the benchmarks seems to be not-up-to date. Including the cost of enacting a candidate into a processing a single bitfield cost was incorrect, since we multiple that by the number of bitfields we have. Instead, we should separate calculate the cost of processing a single bitfield without enactment, and multiple the cost of enactment by the actual number of processed candidates (which is limited by the number cores, not validators). ## Bench Previously, the weight of `enact_candidate` was calculated manually (without a benchmark) and then neglected: https://github.com/paritytech/polkadot-sdk/blob/dd48544a573dd02da2082cec1dda7ce735e2e719/polkadot/runtime/parachains/src/inclusion/mod.rs#L584 In this PR, we have a benchmark for it and it's based on the number of ump and sent hrmp messages as well as whether the candidate has a runtime upgrade (new_validation_code). The differences from the previous attempt paritytech/polkadot#6929 are that * we don't include the cost of enactment into the cost of processing a backed candidate. The reason for it is that enactment happens not in the same block as backing (typically the next one), since we process bitfields before backing votes. * we don't take into account the size of the runtime upgrade, the benchmark weight doesn't seem to depend much on it, but rather whether there was one or not. Similarly to the previous attempt, we don't account for dmp messages (fixed cost). Also we don't account properly for received hrmp messages (hrmp_watermark) because the cost of it depends on the runtime state and can't be statically deduced in the benchmark (unless we pass the information about channels as benchmark u32 arguments). The total weight cost of processing a parainherent now includes the cost of enactment of each candidate, but we don't do filtering based on that (because we enact after processing bitfields and making other changes to the storage). ## Numbers ``` Reads = 7 + (0 * u) + (3 * h) + (8 * c) Writes = 10 + (1 * u) + (3 * h) + (7 * c) ``` In addition, there is a fixed cost of a few of ms (!) per candidate. This might result a full block slightly overflowing its weight with 200 enacted candidates, which in turn could prevent non-mandatory transactions from being included in a block. Given our modest limits on max ump and hrmp messages: ``` maxUpwardMessageNumPerCandidate: 16 hrmpMaxMessageNumPerCandidate: 10 ``` and the fact that runtime upgrades are can't happen very frequently (`validation_upgrade_cooldown`), we might only go over the limits in case of many disputes. TODOs: - [x] Fix the overweight test - [x] Generate the weights for Westend and Rococo - [x] PRDoc --------- Co-authored-by: command-bot <> Co-authored-by: Alin Dima <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ddd58c1 - Browse repository at this point
Copy the full SHA ddd58c1View commit details -
Add new try-state check invariant for nomination-pools (points >= sta…
…ke) (#5465) closes #5448 --------- Co-authored-by: Gonçalo Pestana <[email protected]> Co-authored-by: Ankan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 61bfcb8 - Browse repository at this point
Copy the full SHA 61bfcb8View commit details -
[ci] Move check-runtime-migration to GHA (#5519)
PR moves rococo and wococo check-runtime-migration jobs to GHA cc paritytech/ci_cd#1006
Configuration menu - View commit details
-
Copy full SHA for f7504ce - Browse repository at this point
Copy the full SHA f7504ceView commit details
Commits on Aug 30, 2024
-
Add support for memory-profiling on subsystem-bench (#5522)
Add support in subsystem-benchmarks to profile memory usage using the jemalloc builting profiler, this allows us to run each benchmark with profiling enabled and determine if the memory usage patters are in conformance with our expectations. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c32160e - Browse repository at this point
Copy the full SHA c32160eView commit details -
Added
mac-setup
script (#5528)This is used for the steps that use the `macos` runner. It installs the Rust version that we are using in the [`forklift` image](https://github.com/paritytech/polkadot-sdk/blob/master/.github/env). To be used in #5386.
Configuration menu - View commit details
-
Copy full SHA for 18e9504 - Browse repository at this point
Copy the full SHA 18e9504View commit details -
Simplify
SyncingEngine::new()
a bit (#5396)Tiny changes to simplify the code: - Remove an unnecessary `collect`. - Reduce the code duplication a little bit. --------- Co-authored-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3d4a335 - Browse repository at this point
Copy the full SHA 3d4a335View commit details -
Polkadot Primitives v8 (#5525)
As Runtime release 1.3.0 includes all of the remaining staging primitives and APIs we can now release primitives version 8. No other changes other than renaming/moving done here. --------- Signed-off-by: Andrei Sandu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 09035a7 - Browse repository at this point
Copy the full SHA 09035a7View commit details -
Add more logs for AcceptanceCheckErr (#5513)
# Description The error message should be logged out when the check method returns an error. Because specific information is lost when `UmpAcceptanceCheckErr`, `ProcessedDownwardMessagesAcceptanceErr`, `HrmpWatermarkAcceptanceErr`, `OutboundHrmpAcceptanceErr` are converted to `AcceptanceCheckErr`, a log is added to each check. ## Integration ## Review Notes # Checklist * [ ] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [ ] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
Configuration menu - View commit details
-
Copy full SHA for 9cdf3d9 - Browse repository at this point
Copy the full SHA 9cdf3d9View commit details -
fix cmd bot PR context (#5531)
- restore update-ui.sh (accidentally removed with bunch of bash 😅 - fix empty context and pushing to dev branch (supporting forks) tested fork here: paritytech-stg#45
Configuration menu - View commit details
-
Copy full SHA for d34f687 - Browse repository at this point
Copy the full SHA d34f687View commit details -
asset-hub-rococo: genesis config presets added (#3996)
Gensis config presets moved from `polkadot-parachain` binary into `asset-hub-rococo` runtime. relates to: #3944 --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95f3977 - Browse repository at this point
Copy the full SHA 95f3977View commit details -
parachain-template: genesis config presets added (#4739)
Gensis config presets moved from `parachain-template-node` binary into `parachain-template-runtime` runtime. cc: @PierreBesson
Configuration menu - View commit details
-
Copy full SHA for 562870d - Browse repository at this point
Copy the full SHA 562870dView commit details -
'remainder' instead of reminder && explicit instruction to clone (#5535)
# Description Trivial doc fixes: * Replace the word `reminder` with `remainder` so that the English matches the code intent. * Explicit instruct the reader to `clone`. ## Review Notes * Trivial Co-authored-by: Jan-Jan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 824e1cf - Browse repository at this point
Copy the full SHA 824e1cfView commit details -
Bump the known_good_semver group across 1 directory with 5 updates (#…
…5460) Bumps the known_good_semver group with 4 updates in the / directory: [quote](https://github.com/dtolnay/quote), [serde](https://github.com/serde-rs/serde), [serde_json](https://github.com/serde-rs/json) and [syn](https://github.com/dtolnay/syn). Updates `quote` from 1.0.36 to 1.0.37 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/quote/releases">quote's releases</a>.</em></p> <blockquote> <h2>1.0.37</h2> <ul> <li>Implement ToTokens for CStr and CString (<a href="https://redirect.github.com/dtolnay/quote/issues/283">#283</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/quote/commit/b1ebffa035363a430862e033aa3268e8cb17affa"><code>b1ebffa</code></a> Release 1.0.37</li> <li><a href="https://github.com/dtolnay/quote/commit/43acd77961424b3cb5035688f74d14d556eefe90"><code>43acd77</code></a> Delete unneeded use of <code>ref</code></li> <li><a href="https://github.com/dtolnay/quote/commit/9382c2182ea10f8e0f90d1e5f15ca3f20a777dff"><code>9382c21</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/quote/issues/283">#283</a> from dtolnay/cstr</li> <li><a href="https://github.com/dtolnay/quote/commit/6ac432877bbfe43892677e32af7e3f0e28b6333e"><code>6ac4328</code></a> Add C string tests</li> <li><a href="https://github.com/dtolnay/quote/commit/9fb0591a17893eea81260351c6eb431e1fd83524"><code>9fb0591</code></a> Implement ToTokens for CStr and CString</li> <li><a href="https://github.com/dtolnay/quote/commit/ba7a9d08c9acba8ae97926dcc18822b20441c0fa"><code>ba7a9d0</code></a> Organize test imports</li> <li><a href="https://github.com/dtolnay/quote/commit/aa9970f9838a5b6dd5438c662921470f873e2b3a"><code>aa9970f</code></a> Inline the macro that generates primitive impls</li> <li><a href="https://github.com/dtolnay/quote/commit/ba411091c98c311526774adde73e724448836337"><code>ba41109</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/quote/issues/282">#282</a> from dtolnay/tokens</li> <li><a href="https://github.com/dtolnay/quote/commit/c77340a4c6869690ad7b40069e8ca1cb90e4abb8"><code>c77340a</code></a> Consistently use 'tokens' as the name of the &mut TokenStream arg</li> <li><a href="https://github.com/dtolnay/quote/commit/a4a0abf12fa0137eca5aaa74fe88ca6694e78746"><code>a4a0abf</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/quote/issues/281">#281</a> from dtolnay/char</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/quote/compare/1.0.36...1.0.37">compare view</a></li> </ul> </details> <br /> Updates `serde` from 1.0.206 to 1.0.209 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.209</h2> <ul> <li>Fix deserialization of empty structs and empty tuples inside of untagged enums (<a href="https://redirect.github.com/serde-rs/serde/issues/2805">#2805</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> <h2>v1.0.208</h2> <ul> <li>Support serializing and deserializing unit structs in a <code>flatten</code> field (<a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a>, thanks <a href="https://github.com/jonhoo"><code>@jonhoo</code></a>)</li> </ul> <h2>v1.0.207</h2> <ul> <li>Improve interactions between <code>flatten</code> attribute and <code>skip_serializing</code>/<code>skip_deserializing</code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/30752ac4ffdaa284606eda34055ad185e28c5499"><code>30752ac</code></a> Release 1.0.209</li> <li><a href="https://github.com/serde-rs/serde/commit/b84e6ca4f5fef69b3de985c586a07b1246f3eb9a"><code>b84e6ca</code></a> Improve wording of PR 2805 comments</li> <li><a href="https://github.com/serde-rs/serde/commit/87a2fb0f1a2774ea5bb20c0ed988b9ba57fc8166"><code>87a2fb0</code></a> Wrap comments from PR 2805 to 80 columns</li> <li><a href="https://github.com/serde-rs/serde/commit/9eaf7b9824f2082c50d17ad22b786322dc283a61"><code>9eaf7b9</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2805">#2805</a> from Mingun/untagged-tests</li> <li><a href="https://github.com/serde-rs/serde/commit/7bde100237875d4f435de5ad90074b0479c37486"><code>7bde100</code></a> Replace MapRefDeserializer with value::MapDeserializer</li> <li><a href="https://github.com/serde-rs/serde/commit/da7fc795ee654252effa232a62a5a1e6d4f551ee"><code>da7fc79</code></a> Fix deserialization of empty struct variant in untagged enums</li> <li><a href="https://github.com/serde-rs/serde/commit/4c5fec1363d363f995375426f72db11c28f357c1"><code>4c5fec1</code></a> Test special cases that reaches SeqRefDeserializer::deserialize_any len==0 co...</li> <li><a href="https://github.com/serde-rs/serde/commit/6588b0ad3777f7ad930d68ab4b9ec5b9c25398e0"><code>6588b0a</code></a> Cover Content::Seq case in VariantRefDeserializer::struct_variant</li> <li><a href="https://github.com/serde-rs/serde/commit/0093f74cfee5ee3239514a7aad5fb44843eddcdd"><code>0093f74</code></a> Split test newtype_enum into four tests for each variant</li> <li><a href="https://github.com/serde-rs/serde/commit/171c6da57af712cfcf01c6c124b14cabfca364ba"><code>171c6da</code></a> Complete coverage of ContentRefDeserializer::deserialize_newtype_struct</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.206...v1.0.209">compare view</a></li> </ul> </details> <br /> Updates `serde_derive` from 1.0.206 to 1.0.209 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde_derive's releases</a>.</em></p> <blockquote> <h2>v1.0.209</h2> <ul> <li>Fix deserialization of empty structs and empty tuples inside of untagged enums (<a href="https://redirect.github.com/serde-rs/serde/issues/2805">#2805</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> <h2>v1.0.208</h2> <ul> <li>Support serializing and deserializing unit structs in a <code>flatten</code> field (<a href="https://redirect.github.com/serde-rs/serde/issues/2802">#2802</a>, thanks <a href="https://github.com/jonhoo"><code>@jonhoo</code></a>)</li> </ul> <h2>v1.0.207</h2> <ul> <li>Improve interactions between <code>flatten</code> attribute and <code>skip_serializing</code>/<code>skip_deserializing</code> (<a href="https://redirect.github.com/serde-rs/serde/issues/2795">#2795</a>, thanks <a href="https://github.com/Mingun"><code>@Mingun</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/30752ac4ffdaa284606eda34055ad185e28c5499"><code>30752ac</code></a> Release 1.0.209</li> <li><a href="https://github.com/serde-rs/serde/commit/b84e6ca4f5fef69b3de985c586a07b1246f3eb9a"><code>b84e6ca</code></a> Improve wording of PR 2805 comments</li> <li><a href="https://github.com/serde-rs/serde/commit/87a2fb0f1a2774ea5bb20c0ed988b9ba57fc8166"><code>87a2fb0</code></a> Wrap comments from PR 2805 to 80 columns</li> <li><a href="https://github.com/serde-rs/serde/commit/9eaf7b9824f2082c50d17ad22b786322dc283a61"><code>9eaf7b9</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2805">#2805</a> from Mingun/untagged-tests</li> <li><a href="https://github.com/serde-rs/serde/commit/7bde100237875d4f435de5ad90074b0479c37486"><code>7bde100</code></a> Replace MapRefDeserializer with value::MapDeserializer</li> <li><a href="https://github.com/serde-rs/serde/commit/da7fc795ee654252effa232a62a5a1e6d4f551ee"><code>da7fc79</code></a> Fix deserialization of empty struct variant in untagged enums</li> <li><a href="https://github.com/serde-rs/serde/commit/4c5fec1363d363f995375426f72db11c28f357c1"><code>4c5fec1</code></a> Test special cases that reaches SeqRefDeserializer::deserialize_any len==0 co...</li> <li><a href="https://github.com/serde-rs/serde/commit/6588b0ad3777f7ad930d68ab4b9ec5b9c25398e0"><code>6588b0a</code></a> Cover Content::Seq case in VariantRefDeserializer::struct_variant</li> <li><a href="https://github.com/serde-rs/serde/commit/0093f74cfee5ee3239514a7aad5fb44843eddcdd"><code>0093f74</code></a> Split test newtype_enum into four tests for each variant</li> <li><a href="https://github.com/serde-rs/serde/commit/171c6da57af712cfcf01c6c124b14cabfca364ba"><code>171c6da</code></a> Complete coverage of ContentRefDeserializer::deserialize_newtype_struct</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.206...v1.0.209">compare view</a></li> </ul> </details> <br /> Updates `serde_json` from 1.0.124 to 1.0.127 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>1.0.127</h2> <ul> <li>Add more removal methods to OccupiedEntry (<a href="https://redirect.github.com/serde-rs/json/issues/1179">#1179</a>, thanks <a href="https://github.com/GREsau"><code>@GREsau</code></a>)</li> </ul> <h2>1.0.126</h2> <ul> <li>Improve string parsing on targets that use 32-bit pointers but also have fast 64-bit integer arithmetic, such as aarch64-unknown-linux-gnu_ilp32 and x86_64-unknown-linux-gnux32 (<a href="https://redirect.github.com/serde-rs/json/issues/1182">#1182</a>, thanks <a href="https://github.com/CryZe"><code>@CryZe</code></a>)</li> </ul> <h2>1.0.125</h2> <ul> <li>Speed up \uXXXX parsing and improve handling of unpaired surrogates when deserializing to bytes (<a href="https://redirect.github.com/serde-rs/json/issues/1172">#1172</a>, <a href="https://redirect.github.com/serde-rs/json/issues/1175">#1175</a>, thanks <a href="https://github.com/purplesyringa"><code>@purplesyringa</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/5ebf65cc480f90714c94f82099ca9161d80cbb10"><code>5ebf65c</code></a> Release 1.0.127</li> <li><a href="https://github.com/serde-rs/json/commit/f287a3b1a93ecb1a11cee31cb638bd9523a58add"><code>f287a3b</code></a> Merge pull request 1179 from GREsau/patch-1</li> <li><a href="https://github.com/serde-rs/json/commit/ec980b02774abbff12fd3e26b0a1582eb14dcef7"><code>ec980b0</code></a> Release 1.0.126</li> <li><a href="https://github.com/serde-rs/json/commit/e6282b0c479947805a33c7f167b1d19dd4c7ad4f"><code>e6282b0</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1184">#1184</a> from serde-rs/fastarithmetic</li> <li><a href="https://github.com/serde-rs/json/commit/ffc4a43453029cdc5603cfe3ef08414488fd45de"><code>ffc4a43</code></a> Improve cfg names for fast arithmetic</li> <li><a href="https://github.com/serde-rs/json/commit/4b1048d0ecc4d326d6657531689513f182a4f850"><code>4b1048d</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1183">#1183</a> from serde-rs/arithmetic</li> <li><a href="https://github.com/serde-rs/json/commit/f268173a9fb1f5f8a80f47af62b564525cf33764"><code>f268173</code></a> Unify chunk size choice between float and string parsing</li> <li><a href="https://github.com/serde-rs/json/commit/fec03769743c3f0ceb6b5b56d91321fdc856dff2"><code>fec0376</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1182">#1182</a> from CryZe/chunk-64bit</li> <li><a href="https://github.com/serde-rs/json/commit/3d837e1cc4a0f1df56ba6645c3b6d144768b5d9d"><code>3d837e1</code></a> Ensure the SWAR chunks are 64-bit in more cases</li> <li><a href="https://github.com/serde-rs/json/commit/11fc61c7af7b59ea80fb2ef7d78db94465dfbd54"><code>11fc61c</code></a> Add <code>OccupiedEntry::shift_remove()</code> and <code>swap_remove()</code></li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.124...1.0.127">compare view</a></li> </ul> </details> <br /> Updates `syn` from 2.0.61 to 2.0.65 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/syn/releases">syn's releases</a>.</em></p> <blockquote> <h2>2.0.65</h2> <ul> <li>Optimize the implementation of <code>Fold</code> to compile faster (<a href="https://redirect.github.com/dtolnay/syn/issues/1666">#1666</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1667">#1667</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1668">#1668</a>)</li> </ul> <h2>2.0.64</h2> <ul> <li>Support using ParseBuffer across <code>catch_unwind</code> (<a href="https://redirect.github.com/dtolnay/syn/issues/1646">#1646</a>)</li> <li>Validate that the expression in a let-else ends in brace as required by rustc (<a href="https://redirect.github.com/dtolnay/syn/issues/1648">#1648</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1649">#1649</a>)</li> <li>Legalize invalid const generic arguments by wrapping in braces (<a href="https://redirect.github.com/dtolnay/syn/issues/1654">#1654</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1655">#1655</a>)</li> <li>Fix some expression precedence edge cases involving <code>break</code> and <code>return</code> in loop headers (<a href="https://redirect.github.com/dtolnay/syn/issues/1656">#1656</a>)</li> <li>Always print closure bodies with a brace when the closure has an explicit return type (<a href="https://redirect.github.com/dtolnay/syn/issues/1658">#1658</a>)</li> <li>Automatically insert necessary parentheses in ToTokens for Expr when required by expression precedence (<a href="https://redirect.github.com/dtolnay/syn/issues/1659">#1659</a>)</li> <li>Support struct literal syntax in match guard expressions (<a href="https://redirect.github.com/dtolnay/syn/issues/1662">#1662</a>)</li> </ul> <h2>2.0.63</h2> <ul> <li>Parse and print long if-else-if chains without reliance on deep recursion to avoid overflowing stack (<a href="https://redirect.github.com/dtolnay/syn/issues/1644">#1644</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1645">#1645</a>)</li> </ul> <h2>2.0.62</h2> <ul> <li>Reject invalid unparenthesized range and comparison operator expressions (<a href="https://redirect.github.com/dtolnay/syn/issues/1642">#1642</a>, <a href="https://redirect.github.com/dtolnay/syn/issues/1643">#1643</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/syn/commit/9f2371eefa6f681b53e4d74458d86dd41673227f"><code>9f2371e</code></a> Release 2.0.65</li> <li><a href="https://github.com/dtolnay/syn/commit/4cd181325f3488c47866f15966977682be610da1"><code>4cd1813</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/syn/issues/1668">#1668</a> from dtolnay/foldhelper</li> <li><a href="https://github.com/dtolnay/syn/commit/ed54092bcea6798ab0b5ed7aca6755f8918fc79e"><code>ed54092</code></a> Eliminate gen::helper module</li> <li><a href="https://github.com/dtolnay/syn/commit/eacc8ab1b98b590df3ce9462510fd755cddf6762"><code>eacc8ab</code></a> Eliminate FoldHelper trait</li> <li><a href="https://github.com/dtolnay/syn/commit/6e20bb8d7799d0f4c34c144e80b3bd1b6e9afd27"><code>6e20bb8</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/syn/issues/1667">#1667</a> from dtolnay/punctuatedfold</li> <li><a href="https://github.com/dtolnay/syn/commit/9d95cab6d332d08903538d5ce3d6e47c1598912e"><code>9d95cab</code></a> Optimize punctuated::fold</li> <li><a href="https://github.com/dtolnay/syn/commit/82ffe86c2b721b9985edb6f368e7366bd202bc5b"><code>82ffe86</code></a> Move Punctuated fold helper to punctuated module</li> <li><a href="https://github.com/dtolnay/syn/commit/3dfacc1538f655d33c5c8037b14669149bcd81cd"><code>3dfacc1</code></a> Ignore manual_map clippy lint</li> <li><a href="https://github.com/dtolnay/syn/commit/7273aa77aa09ee2562b279a5d9495a212d9c0876"><code>7273aa7</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/syn/issues/1666">#1666</a> from dtolnay/foldhelper</li> <li><a href="https://github.com/dtolnay/syn/commit/8124c0eb99e11cae036d2c967f91f0c456c50368"><code>8124c0e</code></a> Generate fewer monomorphizations in Fold</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/syn/compare/2.0.61...2.0.65">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ea80adf - Browse repository at this point
Copy the full SHA ea80adfView commit details
Commits on Aug 31, 2024
-
Update CODEOWNERS for contracts (#5537)
Added the new contracts pallet and also added @pgherveou as code owners.
Configuration menu - View commit details
-
Copy full SHA for 9cf6c5b - Browse repository at this point
Copy the full SHA 9cf6c5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7d5f15 - Browse repository at this point
Copy the full SHA b7d5f15View commit details
Commits on Sep 2, 2024
-
Bump color-eyre from 0.6.2 to 0.6.3 (#5543)
Bumps [color-eyre](https://github.com/eyre-rs/eyre) from 0.6.2 to 0.6.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eyre-rs/eyre/commit/f544fed447df75b1accbc95bc2c26aa8fedc312e"><code>f544fed</code></a> chore: Release</li> <li><a href="https://github.com/eyre-rs/eyre/commit/7689b983de53562d678f58a05a6dcfc57d5fae76"><code>7689b98</code></a> chore: don't inherit workspace readme</li> <li><a href="https://github.com/eyre-rs/eyre/commit/63cb4122fcff401efcab862ecf6c65509bc9d1c0"><code>63cb412</code></a> chore: remove old metadata</li> <li><a href="https://github.com/eyre-rs/eyre/commit/7e7e17319aaf7b42bffd9e9cd4a12cb1c2bc8318"><code>7e7e173</code></a> chore: update changelog</li> <li><a href="https://github.com/eyre-rs/eyre/commit/7a5c32acd7a4a6139448b7900a6787f70b5b69fb"><code>7a5c32a</code></a> Add color-eyre to workspace (<a href="https://redirect.github.com/eyre-rs/eyre/issues/110">#110</a>)</li> <li><a href="https://github.com/eyre-rs/eyre/commit/eb8d059c501fbad8de6c6c8af4745f73083969a3"><code>eb8d059</code></a> Merge remote-tracking branch 'origin/master' into color-eyre</li> <li><a href="https://github.com/eyre-rs/eyre/commit/75beaaea3fc85ddab5e9c81570d3c76ea3a21ac8"><code>75beaae</code></a> fix: remove <code>anyhow</code> feature flag from <code>OptionExt</code> location test (<a href="https://redirect.github.com/eyre-rs/eyre/issues/148">#148</a>)</li> <li><a href="https://github.com/eyre-rs/eyre/commit/e57015195082391e00132b4ea4a7ed9fe4536248"><code>e570151</code></a> color-spantrace: bump owo-colors to 4.0 (<a href="https://redirect.github.com/eyre-rs/eyre/issues/156">#156</a>)</li> <li><a href="https://github.com/eyre-rs/eyre/commit/cb4bab6fd0355461f6eec4241e4db9949d890e73"><code>cb4bab6</code></a> chore: update issues redirect</li> <li><a href="https://github.com/eyre-rs/eyre/commit/8ebc308a0ae54f04a410911d2f9c621c988b766a"><code>8ebc308</code></a> fix: make theme test more lenient</li> <li>Additional commits viewable in <a href="https://github.com/eyre-rs/eyre/compare/v0.6.2...color-eyre-v0.6.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=color-eyre&package-manager=cargo&previous-version=0.6.2&new-version=0.6.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f0b2add - Browse repository at this point
Copy the full SHA f0b2addView commit details -
[3 / 5] Move crypto checks in the approval-distribution (#4928)
# Prerequisite This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading #4849 (comment), # Description This PR contain changes, so that the crypto checks are performed by the approval-distribution subsystem instead of the approval-voting one. The benefit for these, is twofold: 1. Approval-distribution won't have to wait every single time for the approval-voting to finish its job, so the work gets to be pipelined between approval-distribution and approval-voting. 2. By running in parallel multiple instances of approval-distribution as described here #4849 (comment), this significant body of work gets to run in parallel. ## Changes: 1. When approval-voting send `ApprovalDistributionMessage::NewBlocks` it needs to pass the core_index and candidate_hash of the candidates. 2. ApprovalDistribution needs to use `RuntimeInfo` to be able to fetch the SessionInfo from the runtime. 3. Move `approval-voting` logic that checks VRF assignment into `approval-distribution` 4. Move `approval-voting` logic that checks vote is correctly signed into `approval-distribution` 5. Plumb `approval-distribution` and `approval-voting` tests to support the new logic. ## Benefits Even without parallelisation the gains are significant, for example on my machine if we run approval subsystem bench for 500 validators and 100 cores and trigger all 89 tranches of assignments and approvals, the system won't fall behind anymore because of late processing of messages. ``` Before change Chain selection approved after 11500 ms hash=0x0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a After change Chain selection approved after 5500 ms hash=0x0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a ``` ## TODO: - [x] Run on versi. - [x] Update parachain host documentation. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6b854ac - Browse repository at this point
Copy the full SHA 6b854acView commit details -
Swaps for XCM delivery fees (#5131)
# Context Fees can already be paid in other assets locally thanks to the Trader implementations we have. This doesn't work when sending messages because delivery fees go through a different mechanism altogether. The idea is to fix this leveraging the `AssetExchanger` config item that's able to turn the asset the user wants to pay fees in into the asset the router expects for delivery fees. # Main addition An adapter was needed to use `pallet-asset-conversion` for exchanging assets in XCM. This was created in #5130. The XCM executor was modified to use `AssetExchanger` (when available) to swap assets to pay for delivery fees. ## Limitations We can only pay for delivery fees in different assets in intermediate hops. We can't pay in different assets locally. The first hop will always need the native token of the chain (or whatever is specified in the `XcmRouter`). This is a byproduct of using the `BuyExecution` instruction to know which asset should be used for delivery fee payment. Since this instruction is not present when executing an XCM locally, we are left with this limitation. To illustrate this limitation, I'll show two scenarios. All chains involved have pools. ### Scenario 1 Parachain A --> Parachain B Here, parachain A can use any asset in a pool with its native asset to pay for local execution fees. However, as of now we can't use those for local delivery fees. This means transfers from A to B need some amount of A's native token to pay for delivery fees. ### Scenario 2 Parachain A --> Parachain C --> Parachain B Here, Parachain C's remote delivery fees can be paid with any asset in a pool with its native asset. This allows a reserve asset transfer between A and B with C as the reserve to only need A's native token at the starting hop. After that, it could all be pool assets. ## Future work The fact that delivery fees go through a totally different mechanism results in a lot of bugs and pain points. Unfortunately, this is not so easy to solve in a backwards compatible manner. Delivery fees will be integrated into the language in future XCM versions, following polkadot-fellows/xcm-format#53. Old PR: #4375.
Configuration menu - View commit details
-
Copy full SHA for 5291412 - Browse repository at this point
Copy the full SHA 5291412View commit details -
Improve
sc-service
API (#5364)This improves `sc-service` API by not requiring the whole `&Configuration`, using specific configuration options instead. `RpcConfiguration` was also extracted from `Configuration` to group all RPC options together. We don't use Substrate's CLI and would rather not use `Configuration` either, but some key public functions require it even though they ignored most of the fields anyway. `RpcConfiguration` is very helpful not just for consolidation of the fields, but also to finally make RPC optional for our use case, while Substrate still runs RPC server on localhost even if listening address is explicitly set to `None`, which is annoying (and I suspect there is a reason for it, so didn't want to change the default just yet). While this is a breaking change, most developers will not notice it if they use higher-level APIs. Fixes #2897 --------- Co-authored-by: Niklas Adolfsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da65410 - Browse repository at this point
Copy the full SHA da65410View commit details -
collator-protocol: Handle unknown validator heads (#5538)
There is a race condition when a validator sends its heads to the collator, but the collator doesn't yet know these heads. Before it is aware of these heads by importing the block(s), any collation registered on the collator is not announced to the validators. The collations aren't advertised, because the collator doesn't know yet that these heads of the validator are descendants of the collations relay parent. The solution is to store these unknown heads of the validators and to handle them when the collator updates its own view.
Configuration menu - View commit details
-
Copy full SHA for f58e2b8 - Browse repository at this point
Copy the full SHA f58e2b8View commit details -
Bump clap_complete from 4.4.0 to 4.5.13 (#5541)
Bumps [clap_complete](https://github.com/clap-rs/clap) from 4.4.0 to 4.5.13. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap_complete's releases</a>.</em></p> <blockquote> <h2>v4.5.13</h2> <h2>[4.5.13] - 2024-07-31</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Improve error message when <code>#[flatten]</code>ing an optional <code>#[group(skip)]</code></li> <li><em>(help)</em> Properly wrap long subcommand descriptions in help</li> </ul> <h2>v4.5.12</h2> <h2>[4.5.12] - 2024-07-31</h2> <h2>v4.5.10</h2> <h2>[4.5.10] - 2024-07-23</h2> <h2>v4.5.9</h2> <h2>[4.5.9] - 2024-07-09</h2> <h3>Fixes</h3> <ul> <li><em>(error)</em> When defining a custom help flag, be sure to suggest it like we do the built-in one</li> </ul> <h2>v4.5.8</h2> <h2>[4.5.8] - 2024-06-28</h2> <h3>Fixes</h3> <ul> <li>Reduce extra flushes</li> </ul> <h2>v4.5.7</h2> <h2>[4.5.7] - 2024-06-10</h2> <h3>Fixes</h3> <ul> <li>Clean up error message when too few arguments for <code>num_args</code></li> </ul> <h2>v4.5.6</h2> <h2>[4.5.6] - 2024-06-06</h2> <h2>v4.5.4</h2> <h2>[4.5.4] - 2024-03-25</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Allow non-literal <code>#[arg(id)]</code> attributes again</li> </ul> <h2>v4.5.3</h2> <h2>[4.5.3] - 2024-03-15</h2> <h3>Internal</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap_complete's changelog</a>.</em></p> <blockquote> <h2>[4.5.13] - 2024-07-31</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Improve error message when <code>#[flatten]</code>ing an optional <code>#[group(skip)]</code></li> <li><em>(help)</em> Properly wrap long subcommand descriptions in help</li> </ul> <h2>[4.5.12] - 2024-07-31</h2> <h2>[4.5.11] - 2024-07-25</h2> <h2>[4.5.10] - 2024-07-23</h2> <h2>[4.5.9] - 2024-07-09</h2> <h3>Fixes</h3> <ul> <li><em>(error)</em> When defining a custom help flag, be sure to suggest it like we do the built-in one</li> </ul> <h2>[4.5.8] - 2024-06-28</h2> <h3>Fixes</h3> <ul> <li>Reduce extra flushes</li> </ul> <h2>[4.5.7] - 2024-06-10</h2> <h3>Fixes</h3> <ul> <li>Clean up error message when too few arguments for <code>num_args</code></li> </ul> <h2>[4.5.6] - 2024-06-06</h2> <h2>[4.5.5] - 2024-06-06</h2> <h3>Fixes</h3> <ul> <li>Allow <code>exclusive</code> to override <code>required_unless_present</code>, <code>required_unless_present_any</code>, <code>required_unless_present_all</code></li> </ul> <h2>[4.5.4] - 2024-03-25</h2> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Allow non-literal <code>#[arg(id)]</code> attributes again</li> </ul> <h2>[4.5.3] - 2024-03-15</h2> <h3>Internal</h3> <ul> <li><em>(derive)</em> Update <code>heck</code></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/clap-rs/clap/commit/d222ae4cb62d08b4d8f635aa80ddb3c880b82e6e"><code>d222ae4</code></a> chore: Release</li> <li><a href="https://github.com/clap-rs/clap/commit/a8abcb40c5f2628bfa671adf61a090a1bbfbcfa2"><code>a8abcb4</code></a> docs: Update changelog</li> <li><a href="https://github.com/clap-rs/clap/commit/2690e1bdb19df3e4dde7a50fc33b14a3bf6f0b8a"><code>2690e1b</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5621">#5621</a> from shannmu/dynamic_valuehint</li> <li><a href="https://github.com/clap-rs/clap/commit/7fd7b3e40bd835070253432accf4076bb020beda"><code>7fd7b3e</code></a> feat(clap_complete): Support to complete custom value of argument</li> <li><a href="https://github.com/clap-rs/clap/commit/fc6aaca52b42d0e4ae13805e7480cbb05f63a0ca"><code>fc6aaca</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5638">#5638</a> from epage/cargo</li> <li><a href="https://github.com/clap-rs/clap/commit/631e54bc715ed2fa53d8457dc273a25b92d3b354"><code>631e54b</code></a> docs(cookbook): Style cargo plugin</li> <li><a href="https://github.com/clap-rs/clap/commit/6fb49d08bb2acfbc2f2aa5f717ccd4a4018ca872"><code>6fb49d0</code></a> Merge pull request <a href="https://redirect.github.com/clap-rs/clap/issues/5636">#5636</a> from gibfahn/styles_const</li> <li><a href="https://github.com/clap-rs/clap/commit/6f215eee98c4f73099b0ede2ac62ba019ada24ce"><code>6f215ee</code></a> refactor(styles): make styles example use a const</li> <li><a href="https://github.com/clap-rs/clap/commit/bbb2e6fdde1c724e39c2f2616332310252c12ab8"><code>bbb2e6f</code></a> test: Add test case for completing custom value of argument</li> <li><a href="https://github.com/clap-rs/clap/commit/999071c46dca0367d93f66ecd97b2e3507963284"><code>999071c</code></a> fix: Change <code>visible</code> to <code>hidden</code></li> <li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/clap_complete-v4.4.0...clap_complete-v4.5.13">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=clap_complete&package-manager=cargo&previous-version=4.4.0&new-version=4.5.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for da11c7e - Browse repository at this point
Copy the full SHA da11c7eView commit details -
Bump toml from 0.8.8 to 0.8.12 (#5542)
Bumps [toml](https://github.com/toml-rs/toml) from 0.8.8 to 0.8.12. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/toml-rs/toml/commit/3a777b326b8c91f48c79ea6fc21aabc695f7dc3d"><code>3a777b3</code></a> chore: Release</li> <li><a href="https://github.com/toml-rs/toml/commit/79799052128f3ea64316d3acc4c54e63fc6f285c"><code>7979905</code></a> docs: Update changelog</li> <li><a href="https://github.com/toml-rs/toml/commit/487768d8d7c41b12eb7547cab4e964b3dede002b"><code>487768d</code></a> Merge pull request <a href="https://redirect.github.com/toml-rs/toml/issues/703">#703</a> from epage/overflow</li> <li><a href="https://github.com/toml-rs/toml/commit/6987f77649aacc7a6cc2b9cff0d1f22c260f9643"><code>6987f77</code></a> chore(ci): Run with default opt-level</li> <li><a href="https://github.com/toml-rs/toml/commit/21f545d05ca57560485f24cbf78aaf8478a52c5d"><code>21f545d</code></a> fix(parser): Don't stackoverflow on opt-level=0</li> <li><a href="https://github.com/toml-rs/toml/commit/af1f97dbf5a40740e26eb4f705a0bd744744807b"><code>af1f97d</code></a> refactor(parser): Pull recursion limit out to variable</li> <li><a href="https://github.com/toml-rs/toml/commit/eb865434a251b30ca1a9699b8762a1f5f4670c1c"><code>eb86543</code></a> chore: Release</li> <li><a href="https://github.com/toml-rs/toml/commit/246b2920e28919e02a94c0b3eab8e55c7742f5d0"><code>246b292</code></a> docs: Update changelog</li> <li><a href="https://github.com/toml-rs/toml/commit/d41c62ca5d09c50064905f7da04fc103d78ff566"><code>d41c62c</code></a> Merge pull request <a href="https://redirect.github.com/toml-rs/toml/issues/701">#701</a> from epage/cleanup</li> <li><a href="https://github.com/toml-rs/toml/commit/31457b3aedcddae92549b5fe19c1938d29a73a2d"><code>31457b3</code></a> refactor(error): Clean up highlight code</li> <li>Additional commits viewable in <a href="https://github.com/toml-rs/toml/compare/toml-v0.8.8...toml-v0.8.12">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=toml&package-manager=cargo&previous-version=0.8.8&new-version=0.8.12)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7c46b28 - Browse repository at this point
Copy the full SHA 7c46b28View commit details -
[bridges-v2] Permissionless lanes (#4949)
Relates to: paritytech/parity-bridges-common#2451 Closes: paritytech/parity-bridges-common#2500 ## Summary Now, the bridging pallet supports only static lanes, which means lanes that are hard-coded in the runtime files. This PR fixes that and adds support for dynamic, also known as permissionless, lanes. This means that allowed origins (relay chain, sibling parachains) can open and close bridges (through BridgeHubs) with another bridged (substrate-like) consensus using just `xcm::Transact` and `OriginKind::Xcm`. _This PR is based on the migrated code from the Bridges V2 [branch](#4427) from the old `parity-bridges-common` [repo](https://github.com/paritytech/parity-bridges-common/tree/bridges-v2)._ ## Explanation Please read [bridges/modules/xcm-bridge-hub/src/lib.rs](https://github.com/paritytech/polkadot-sdk/blob/149b0ac2ce43fba197988f2642032fa24dd8289a/bridges/modules/xcm-bridge-hub/src/lib.rs#L17-L136) to understand how managing bridges works. The basic concepts around `BridgeId` and `LaneId` are also explained there. ## TODO - [x] search and fix for comment: `// TODO:(bridges-v2) - most of that stuff was introduced with free header execution: https://github.com/paritytech/polkadot-sdk/pull/4102` - more info in the comment [bellow](#4427 (comment)) - [x] TODO: there's only one impl of `EnsureOrigin<Success = Location>` ## TODO - not blocking review **benchmarking:** - [x] regenerate all relevant weights for BH/AH runtimes - [ ] regenerate default weights for bridging pallets e.g. `modules/messages/src/weights.rs` - [ ] add benchmarks for `xcm-bridge-hub` pallet #5550 **testing:** - [ ] add xcm-emulator tests for Rococo/Penpal to Westend/Penpal with full opening channel and sending/receiving `xcm::Transact` **migrations:** - [x] add migrations for BridgeHubRococo/Westend paritytech/parity-bridges-common#2794 (to be reusable for P/K bridge) - [x] check also storage migration, if needed for pallets - [ ] migration for XCM type (optional) - [x] migration for static lanes to the dynamic (reuse for fellows) **investigation:** - [ ] revisit paritytech/parity-bridges-common#2380 - [ ] check congestion around `LocalXcmChannelManager` and `OutboundLanesCongestedSignals` impls - #5551 - to be reusable for polkadot-fellows - return `report_bridge_status` was remove, so we need to `XcmpQueue` alternative? --------- Signed-off-by: Branislav Kontur <[email protected]> Co-authored-by: Svyatoslav Nikolsky <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Francisco Aguirre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2210099 - Browse repository at this point
Copy the full SHA 2210099View commit details -
Update CODEOWNERS and review-bot for new contracts pallet (#5549)
Created a new @paritytech/smart-contracts team that is now referenced in the review bot config and CODEOWNERS file. Also excluded the new pallet in the other review bot rules.
Configuration menu - View commit details
-
Copy full SHA for 7d228d9 - Browse repository at this point
Copy the full SHA 7d228d9View commit details -
Elastic scaling: introduce new candidate receipt primitive (#5322)
closes #5044 This PR switches the runtime to the new receipts format (vstaging primitives). I've implemented `From` to convert from new primitives to `v7` primitives and used them in the node runtime api client implementation. Until we implement the support in the node, it will continue e to use the v7 primitives but the runtime apis already use the new primitives. An expected downside of RFC103 is decoding V2 receipts shows garbage values if the input is V1: _![ima_9ce77de](https://github.com/user-attachments/assets/71d80e78-e238-4518-8cd1-548ae0d74b70)_ TODO: - [x] fix tests - [x] A few more tests for the new primitives - [x] PRDoc --------- Signed-off-by: Andrei Sandu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad2ac0d - Browse repository at this point
Copy the full SHA ad2ac0dView commit details -
[pallet-revive] Use address20 for contract's address (#5548)
Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 3835507 - Browse repository at this point
Copy the full SHA 3835507View commit details -
Snowbridge free consensus updates (#5201)
Allow free Snowbridge consensus updates, if the header interval is larger than the configured value (set to 32, so once a epoch). This PR also moves the Rococo Snowbridge pallet config into its own module. Original PR: Snowfork#159 --------- Co-authored-by: Francisco Aguirre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c8015b2 - Browse repository at this point
Copy the full SHA c8015b2View commit details -
[FRAME] MQ processor should be transactional (#5198)
closes #2441 Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6eeca9 - Browse repository at this point
Copy the full SHA f6eeca9View commit details
Commits on Sep 3, 2024
-
Remove noise from the template list (#5437)
Co-authored-by: Javier Viola <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 3c71db3 - Browse repository at this point
Copy the full SHA 3c71db3View commit details -
revive: Make
salt
salt optional to allow for CREATE1 semantics (#5556)Before we only supported CREATE2 semantics for contract address derivations. In order to be compatible we also want to allow CREATE1 semantics. We accomplish this to make the salt an `Option` in all places where it is used. Supplying `None` will use CREATE1 semantics by just using the deployers account nonce. ## Todo - [x] Add new tests specific for CREATE1
Configuration menu - View commit details
-
Copy full SHA for 020cda3 - Browse repository at this point
Copy the full SHA 020cda3View commit details -
[CI] Also backport to stable2409 (#5561)
Also make the backport bot use the new release.
Configuration menu - View commit details
-
Copy full SHA for 09331f2 - Browse repository at this point
Copy the full SHA 09331f2View commit details -
GHA Migration - build misc (#5346)
Closes paritytech/ci_cd#1017 - Enabled subsystem-benchmarks 100% + adjusted them to publish as separate job so it can use environment for scope secrets - Added -v1.* triggers for GHA checks - Removed remove subkey & polkavm from gitlab --------- Co-authored-by: Alexander Samusev <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7b5753 - Browse repository at this point
Copy the full SHA d7b5753View commit details -
chainHead/fix: Report bestBlock events only for newBlock reports (#5527)
The #5512 has surfaced that we reported a `BestBlock` event for a block not previously reported via `NewBlock`. This is because of a race between: - the stream of events that announces new blocks - `self.client.info().best_block` It is possible that `client.info()` contains newer information than the information polled from the block stream (that may be lagging). To mitigate this, instead of relying on the client's info use the last finalized block to emit a new event. There are two cases when a new best block event is emitted: - The best block is in the pruned list and is reported immediately - The best block is not a descendant of the last finalized block Closes: #5512 Thanks @jsdw and @josepot for helping debug this 🙏 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for 325df54 - Browse repository at this point
Copy the full SHA 325df54View commit details -
cumulus/client: added external rpc connection retry logic (#5515)
# Description Adds retry logic that makes the RPC relay chain interface more reliable for the cases of a collator connecting to external RPC servers. Closes #5514 Closes #4278 Final solution still debated on #5514 , what this PR addresses might change (e.g. #4278 might require a more advanced approach). ## Integration Users that start collators should barely observe differences based on this logic, since the retry logic applies only in case the collators fail to connect to the RPC servers. In practice I assume the RPC servers are already live before starting collators, and the issue isn't visible. ## Review Notes The added retry logic is for retrying the connection to the RPC servers (which can be multiple). It is at the level of the cumulus/client/relay-chain-rpc-interface module, but more specifically relevant to the RPC clients logic (`ClientManager`). The retry logic is not configurable, it tries to connect to the RPC client for 5 times, with an exponential backoff in between each iteration starting with 1 second wait time and ending with 16 seconds. The same logic is applied in case an existing connection to an RPC is dropped. There is a `ReconnectingWebsocketWorker` who ensures there is connectivity to at least on RPC node, and the retry logic makes this stronger by insisting on trying connections to the RPC servers list for 5 times. ## Testing - This was tested manually by starting zombienet natively based on [006-rpc_collator_builds_blocks.toml](https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/zombienet/tests/0006-rpc_collator_builds_blocks.toml) and observing collators don't fail anymore: ```bash zombienet -l text --dir zbn-run -f --provider native spawn polkadot-sdk/cumulus/zombienet/tests/0006-rpc_collator_builds_blocks.toml ``` - Added a unit test that exercises the retry logic for a client connection to a server that comes online in 10 seconds. The retry logic can wait for as long as 30 seconds, but thought that it is too much for a unit test. Just being conscious of CI time if it runs this test, but I am happy to see suggestions around it too. I am not that sure either it runs in CI, haven't figured it out entirely yet. The test can be considered an integration test too, but it exercises crate internal implementation, not the public API. Collators example logs after the change: ``` 2024-08-29 14:28:11.730 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=0 index=2 url="ws://127.0.0.1:37427/" 2024-08-29 14:28:12.737 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=1 index=0 url="ws://127.0.0.1:43617/" 2024-08-29 14:28:12.739 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=1 index=1 url="ws://127.0.0.1:37965/" 2024-08-29 14:28:12.755 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=1 index=2 url="ws://127.0.0.1:37427/" 2024-08-29 14:28:14.758 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=2 index=0 url="ws://127.0.0.1:43617/" 2024-08-29 14:28:14.759 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=2 index=1 url="ws://127.0.0.1:37965/" 2024-08-29 14:28:14.760 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=2 index=2 url="ws://127.0.0.1:37427/" 2024-08-29 14:28:18.766 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=3 index=0 url="ws://127.0.0.1:43617/" 2024-08-29 14:28:18.768 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=3 index=1 url="ws://127.0.0.1:37965/" 2024-08-29 14:28:18.768 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=3 index=2 url="ws://127.0.0.1:37427/" 2024-08-29 14:28:26.770 INFO tokio-runtime-worker reconnecting-websocket-client: [Parachain] Trying to connect to next external relaychain node. current_iteration=4 index=0 url="ws://127.0.0.1:43617/" ``` --------- Signed-off-by: Iulian Barbu <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4d2f793 - Browse repository at this point
Copy the full SHA 4d2f793View commit details
Commits on Sep 4, 2024
-
Add parachain related parameters to
chain-spec-builder
(#4889)When using with `polkadot-parachain`, you usually need to specify the `relay_chain` and `para_id` fields in the chain spec. With this PR it can be achieved by specifying newly added `--para-id` and `--relay-chain` command line args, e.g: ``` chain-spec-builder create -r _runtime.wasm --para-id 100 --relay-chain xxx default ``` This was implemented by simple _json_ blobs merging. Additionally unit tests covering basic functionality were added. Also adds a fix for not overwriting the chain spec with the default config each time, swallowing not standard fields is also fixed. Fixes: #4873 --------- Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 89b41c5 - Browse repository at this point
Copy the full SHA 89b41c5View commit details -
Avoid updating the block gap when it's unchanged (#5540)
There are basically three commits in this PR. Since all these commits essentially have no logical changes, I packed them into one PR. Review by per-commit is recommended. - The first commit avoids unnecessarily updating the block gap storage when the value remains unchanged, as discovered when I worked on #5406. - The second commit is purely about format string style changes but deletes ~10 lines of code, which slightly helps me look into this file :P - The third commit is added to avoid the unnecessary block gap update in `BlockchainDb`. --------- Co-authored-by: Davide Galassi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b28a54 - Browse repository at this point
Copy the full SHA 9b28a54View commit details -
Add badges with the release info to the README.md (#5518)
This PR adds the badges to the readme to show the info about the current stable release version and the version and date of the upcoming stable release. The idea here to give a possibility for people from the outside to have an overview about the current and upcoming release, until we have a proper public release calendar. <img width="1280" alt="Screenshot 2024-08-29 at 14 47 57" src="https://github.com/user-attachments/assets/8faff023-c4b2-444b-95a3-ce6d106e2a7a"> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db41fab - Browse repository at this point
Copy the full SHA db41fabView commit details -
Collective: dynamic deposit based on number of proposals (#3151)
Introduce a dynamic proposal deposit mechanism influenced by the total number of active proposals, with the option to set the deposit to none. The potential cost (e.g., balance hold) for proposal submission and storage is determined by the implementation of the `Consideration` trait. The footprint is defined as `proposal_count`, representing the total number of active proposals in the system, excluding the one currently being proposed. This cost may vary based on the proposal count. The pallet also offers various types to define a cost strategy based on the number of proposals. Two new calls are introduced: - kill(origin, proposal_hash): the cancellation of a proposal, accompanied by the burning of the associated cost/consideration ticket. - release_proposal_cost(origin, proposal_hash): the release of the cost for a non-active proposal. Additionally change: - benchmarks have been upgraded to benchmarks::v2 for collective pallet; - `ensure_successful` function added to the `Consideration` under `runtime-benchmarks` feature. --------- Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cc3b7bb - Browse repository at this point
Copy the full SHA cc3b7bbView commit details -
try making bench numbers make sense (#5526)
Follow-up to #5270. The baseline numbers for Westend were too high to be representative of the reality as it seemed to do with how multi-variate linear regression is calculated. --------- Co-authored-by: command-bot <>
Configuration menu - View commit details
-
Copy full SHA for de0b6f2 - Browse repository at this point
Copy the full SHA de0b6f2View commit details -
build and publish images migration (#5558)
migrate jobs to gha - build-linux-stable-cumulus - build-test-parachain - build-linux-stable - build-test-collators - build-malus - build-linux-substrate - prepare-bridges-zombienet-artifacts (might require help from zombienet team) - build-push-image-polkadot-parachain-debug - build-push-image-test-parachain - build-push-image-polkadot-debug - build-push-image-colander - build-push-image-malus - build-push-image-substrate-pr - build-push-image-bridges-zombienet-tests see [ci_cd#1013](paritytech/ci_cd#1013)
Configuration menu - View commit details
-
Copy full SHA for 778a9e4 - Browse repository at this point
Copy the full SHA 778a9e4View commit details -
Create a Basic Proving Trie for the Runtime (#3881)
This PR will introduce a `BasicProvingTrie` type, which makes it easy to construct and prove data in a base-16 merkle trie within the runtime. Data into the merkle trie only require that they implement `Encode` / `Decode`. A FRAME compatible `TrieError` was created and added to `DispatchError`. Expected usage is to construct the merkle trie with all data offline, and then place only the merkle root of that trie on-chain. Also offchain, a user is given a compact merkle proof of some data they want to prove exists on the blockchain. Then in the runtime, you can call `verify_single_value_proof` or `verify_proof` with the root, proof, and the keys and values you want to verify exists in the merkle trie. Closes #3880 Contributes to #5400 --------- Co-authored-by: Ankan <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1cff666 - Browse repository at this point
Copy the full SHA 1cff666View commit details
Commits on Sep 5, 2024
-
PR Doc #5443 broke the link checker because it includes a link to this private repo: paritytech/devops#3502 This PR adds the `prdoc` folder to the excluded paths of the link checker to ensure that historical PR Docs do not break the pipeline. I think this makes sense over whitelisting the github link because we probably expect that in a long enough time period, links from old PR docs will start to break, but I don't think we intend to update those old PR docs, or start whitelisting lots of urls.
Configuration menu - View commit details
-
Copy full SHA for d5346e7 - Browse repository at this point
Copy the full SHA d5346e7View commit details -
[pallet-revive] refactor uapi with better types (#5555)
start using better type for address, code_hash, and salt in runtime and the uapi crate fix #5575
Configuration menu - View commit details
-
Copy full SHA for cf330cc - Browse repository at this point
Copy the full SHA cf330ccView commit details -
Update and test the
getting-started
script (#5446)Here are some changes to the `getting-started.sh` scripts we have advertised on top of the readme. ### Changes to the script 1. Change `echo` to a more portable `printf`. On my machine, the script printed a literal `\n` string if run with `bash`. If I changed it to `echo -e`, then it printed a literal `-e` if run with `sh`. Changed it to `printf` which is more portable. --- 2. Template selection The script proceeded to clone and build the `minimal` template, which is not always what we want. Added a selection prompt where the user can select one of the 3 templates, and choose if it should be built&run or not. The user can also select no template at all - that way, we have a starter of a dependencies-installation script. --- 3. Added some missing dependencies for some of the systems. ### A workflow testing the script I propose a workflow, that will test the script using the [expect](https://core.tcl-lang.org/expect/index) tool. For each OS mentioned in the script (macOS, Ubuntu, Debian, Arch, Fedora, OpenSUSE) we go through the script twice, and after that build and run the template binary. I'm using docker containers, so we start from scratch and make sure the scripts installs all required dependencies - with the exception of macOS, which I can't run from scratch in a container. The jobs use a selected combination of OSes, shell interpreters (`bash` or `sh`), and templates. There is too much combinations to run them all, but I have [run it once](https://github.com/paritytech-stg/polkadot-sdk/actions/runs/10509533645) in staging to make sure all pass. I'm adding a cron schedule because it can break without any code changes in this repository (e.g. new `latest` release of a container). --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e0ec3e - Browse repository at this point
Copy the full SHA 5e0ec3eView commit details -
[ci] Move test-linux-stable to GHA (#5571)
PR moves jobs `test-linux-stable`, `test-linux-stable-int` and `test-linux-stable-runtime-benchmarks` to github actions cc paritytech/ci_cd#1006
Configuration menu - View commit details
-
Copy full SHA for 6a1b200 - Browse repository at this point
Copy the full SHA 6a1b200View commit details -
Clear other messages before dry-run to get only the ones produced dur…
…ing (#5581) The dry-run shows in `forwarded_xcms` all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a `System::remark`. This PR fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about. --------- Co-authored-by: Adrian Catangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d9ebcd - Browse repository at this point
Copy the full SHA 8d9ebcdView commit details -
Make the docs logo readable on light backgrounds (#5389)
Currently, the logo on the docs site blends into the background on the light theme: <img width="320px" src="https://github.com/user-attachments/assets/4cded445-d3af-4100-bd11-6a33da836cb1"> [Here](https://internals.rust-lang.org/t/feedback-on-new-rust-documentation-logo-background/12787) is a discussion related to this. There doesn't seem to be a perfect way to handle this situation. --- Silent because the docs crate is not part of the regular release process. --------- Co-authored-by: ordian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6fd5bc - Browse repository at this point
Copy the full SHA f6fd5bcView commit details -
Add benchmark for the number of minimum cpu cores (#5127)
Fixes: #5122. This PR extends the existing single core `benchmark_cpu` to also build a score of the entire processor by spawning `EXPECTED_NUM_CORES(8)` threads and averaging their throughput. This is better than simply checking the number of cores, because also covers multi-tenant environments where the OS sees a high number of available CPUs, but because it has to share it with the rest of his neighbours its total throughput does not satisfy the minimum requirements. ## TODO - [x] Obtain reference values on the reference hardware. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a947cb8 - Browse repository at this point
Copy the full SHA a947cb8View commit details -
GHA Migration - test-misc (#5385)
Closes: paritytech/ci_cd#1018 ![image](https://github.com/user-attachments/assets/b434d809-2c38-47e9-8a62-448f32cf24cb) Added DAG similar to how it was on Gitlab --------- Co-authored-by: Alexander Samusev <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49a6813 - Browse repository at this point
Copy the full SHA 49a6813View commit details -
Github actions coverage (#5148)
Jobs for coverage collections and upload to codecov for github PR's Uses same test suit as test-linux-stable, splits tests into 5 parallel jobs, uploads to codecov, generates report comment and status checks (can be made required) | | | | --- | --- | | <img width="640" alt="image" src="https://github.com/user-attachments/assets/3790f255-27d1-46b9-8d25-2e40b3dcd844"> | <img width="764" alt="image" src="https://github.com/user-attachments/assets/9e0c8cc7-3278-4b4e-9e28-d76cd57b9163"> | Codecov behavior (required coverage, thresholds, comment info etc.) is highly customizable via `.github/codecov.yaml` ([reference](https://docs.codecov.com/docs/codecovyml-reference)) Unfortunately, some tests are excluded because with `-C instrument-coverage` they run very slowly, flaky, or fail (see [nextest filter expression](https://github.com/paritytech/polkadot-sdk/pull/5148/files#diff-b19504a9520a2498d03020108344d8e6d93d254d812bfa26247faaa7f55263d6R80) of test-linux-stable-coverage). So for now, this workflow is optional, and will only run for pr's with the `GHA-coverage` label
Configuration menu - View commit details
-
Copy full SHA for b9b34fb - Browse repository at this point
Copy the full SHA b9b34fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 702a15c - Browse repository at this point
Copy the full SHA 702a15cView commit details -
Closes: #5545 - add missing template for frame & xcm benchmarks - fix `git pull` -> https://github.com/paritytech/polkadot-sdk/actions/runs/10644887539/job/29510118915 - respect runtimes headers - use GNU instead of apache for runtimes - adds tests for cmd.py Tip: review this one with Whitespace hidden ![image](https://github.com/user-attachments/assets/3bcdc6c2-7371-428f-9962-556ca81c1467) --------- Co-authored-by: GitHub Action <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d81f1e - Browse repository at this point
Copy the full SHA 8d81f1eView commit details
Commits on Sep 6, 2024
-
Previously, block gaps could only be created by warp sync, but block gaps will also be generated by fast sync once #5406 is fixed. This PR is part 1 of the detailed implementation plan in #5406 (comment): refactor `BlockGap`. This refactor converts the existing `(NumberFor<Block>, NumberFor<Block>)` into a dedicated `BlockGap<NumberFor<Block>>` struct. This change is purely structural and does not alter existing logic, but lays the groundwork for the follow-up PR. The compatibility concern caused by the new structure is addressed in the second commit. cc @dmitry-markin --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fdb4554 - Browse repository at this point
Copy the full SHA fdb4554View commit details -
[CI/Release] Pipeline to create a stable release branch (#5598)
This PR contains a pipeline which is going to branch off the new stable release branch (e.g. `stab2412`, `stable2503`) and bump `polkadot` `NODE_VERSION`, `spec_version` of the runtimes and reorganisation of the `prdocs` related to the new stable release. This is a first step in the automated `polkadot-sdk` release flow as part of the task: #3291 The pipeline is not supposed to be triggered in the main` polkadot-sdk` repo, but in the fork in the [`paritytech-release`](https://github.com/paritytech-release/polkadot-sdk) org, where the whole release flow is going to land. Closes: paritytech/release-engineering#222
Configuration menu - View commit details
-
Copy full SHA for 76df1ae - Browse repository at this point
Copy the full SHA 76df1aeView commit details -
Update Templates Readme - Github Repo links (#5381)
When someone downloads the Polkadot SDK repo and navigates to the templates folder, the Readme instructions do not work. There is a getting started script of the Polkadot SDK readme which can be overlooked (and also it covers only minimal template and not the parachain/solochain templates). The instructions of the Readme files are updated such that they work for anyone on https://github.com/paritytech/polkadot-sdk https://github.com/paritytech/polkadot-sdk-minimal-template https://github.com/paritytech/polkadot-sdk-parachain-template https://github.com/paritytech/polkadot-sdk-solochain-template --------- Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 986e7ae - Browse repository at this point
Copy the full SHA 986e7aeView commit details -
Fix PVF precompilation for Kusama (#5606)
![image](https://github.com/user-attachments/assets/2deaee85-67c3-4119-b0c0-d2e7f818b4ea) Because on Kusama validators.len() < discovery_keys.len() we can tweak the PVF precompilation to allow prepare PVFs when the node is an authority but not a validator.
Configuration menu - View commit details
-
Copy full SHA for 5040b3c - Browse repository at this point
Copy the full SHA 5040b3cView commit details -
[ci] Fix final job for required workflows (#5619)
Currently if a required job fails the final jobs is skipped which breaks the logic of required jobs. PR fixes it. Closes paritytech/ci_cd#1033
Configuration menu - View commit details
-
Copy full SHA for b2089d8 - Browse repository at this point
Copy the full SHA b2089d8View commit details -
Fixes paritytech/ci_cd#1032 --------- Co-authored-by: Alexander Samusev <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 365d992 - Browse repository at this point
Copy the full SHA 365d992View commit details
Commits on Sep 7, 2024
-
Fix occasional
alloc
not found error informat_runtime_string!
(#……5632) The macro hygiene for the `format_runtime_string!` macro was broken since #5010, which resulted in the following build error under certain circumstances: ```console error[E0433]: failed to resolve: use of undeclared crate or module `alloc` --> /home/clang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-benchmarking-36.0.0/src/v1.rs:1738:2 | 1738 | / sp_runtime::format_runtime_string!( 1739 | | "\n* Pallet: {}\n\ 1740 | | * Benchmark: {}\n\ 1741 | | * Components: {:?}\n\ ... | 1750 | | error_message, 1751 | | ) | |_____^ use of undeclared crate or module `alloc` | = note: this error originates in the macro `sp_runtime::format_runtime_string` (in Nightly builds, run with -Z macro-backtrace for more info) For more information about this error, try `rustc --explain E0433`. ``` This bug has been known already, but hasn't been fixed so far, see #5213 and https://substrate.stackexchange.com/questions/11786/use-of-undeclared-crate-or-module-alloc-when-upgrade-to-v1-13-0. I have made a mini rust crate that can reproduce the bug, and it also shows that this PR will fix the issue: https://github.com/clangenb/sp-runtime-string-test.
Configuration menu - View commit details
-
Copy full SHA for 96fecc3 - Browse repository at this point
Copy the full SHA 96fecc3View commit details -
Add debugging info for
StorageWeightReclaim
(#5594)When inspecting the logs we often encounter the following message: `Benchmarked storage weight smaller than consumed storage weight. benchmarked: {benchmarked_weight} consumed: {consumed_weight} unspent: {unspent}` However, it is very hard to guess which call is causing the issue. With the changes proposed in this PR, information about the call is provided so that we can easily identify the source of the problem without further delay, and this way work more efficiently in solving the issue. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 016421a - Browse repository at this point
Copy the full SHA 016421aView commit details
Commits on Sep 8, 2024
-
[pallet-revive] update generic runtime types (#5608)
fix #5574 - Use U256 instead of BalanceOf<T> and MomentOf<T> in Ext trait - Enforce H256 for T::Hash The Ext trait still depends on the associated type `T: Config`, we can look into refactoring it even more later but even in the current state it should not influence how the data is encoded / decoded between the contract and the host ``` fn caller(&self) -> Origin<Self::T>; -> only use to extract the address of the caller fn account_id(&self) -> &AccountIdOf<Self::T>; -> only used to expose the address or access the account_id internally fn gas_meter(&self) -> &GasMeter<Self::T>; fn gas_meter_mut(&mut self) -> &mut GasMeter<Self::T>; -> encoding does not depend on T fn call_runtime(&self, call: <Self::T as Config>::RuntimeCall) -> DispatchResultWithPostInfo; -> Substrate specific, just an opaque blob of bytes from the contract's perspective fn contract_info(&mut self) -> &mut ContractInfo<Self::T>; fn transient_storage(&mut self) -> &mut TransientStorage<Self::T>; -> gated by #[cfg(any(test, feature = "runtime-benchmarks"))] ``` --------- Co-authored-by: Alexander Theißen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 868a36b - Browse repository at this point
Copy the full SHA 868a36bView commit details
Commits on Sep 9, 2024
-
Bump the known_good_semver group with 3 updates (#5636)
Bumps the known_good_semver group with 3 updates: [serde](https://github.com/serde-rs/serde), [serde_derive](https://github.com/serde-rs/serde) and [serde_json](https://github.com/serde-rs/json). Updates `serde` from 1.0.209 to 1.0.210 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde's releases</a>.</em></p> <blockquote> <h2>v1.0.210</h2> <ul> <li>Support serializing and deserializing <code>IpAddr</code> and <code>SocketAddr</code> in no-std mode on Rust 1.77+ (<a href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>, thanks <a href="https://github.com/MathiasKoch"><code>@MathiasKoch</code></a>)</li> <li>Make <code>serde::ser::StdError</code> and <code>serde::de::StdError</code> equivalent to <code>core::error::Error</code> on Rust 1.81+ (<a href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/89c4b02bf32ceae5b17d89f93a452ccc195ca038"><code>89c4b02</code></a> Release 1.0.210</li> <li><a href="https://github.com/serde-rs/serde/commit/eeb8e44cda15f929796cd72241b0311e0bd04e67"><code>eeb8e44</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a> from dtolnay/coreerror</li> <li><a href="https://github.com/serde-rs/serde/commit/785c2d9605ee73cc172dfd421228c1dccca984c9"><code>785c2d9</code></a> Stabilize no-std StdError trait</li> <li><a href="https://github.com/serde-rs/serde/commit/d549f048e10bcb5e677afaf7b99d0ed3604b113b"><code>d549f04</code></a> Reformat parse_ip_impl definition and calls</li> <li><a href="https://github.com/serde-rs/serde/commit/4c0dd63011434905265e2710bb9186e09e4f8ec2"><code>4c0dd63</code></a> Delete attr support from core::net deserialization macros</li> <li><a href="https://github.com/serde-rs/serde/commit/26fb1341651c4e0ae4d58c675db3ca2a0d6e12c2"><code>26fb134</code></a> Relocate cfg attrs out of parse_ip_impl and parse_socket_impl</li> <li><a href="https://github.com/serde-rs/serde/commit/07e614b52b5ab3387d86d3198e5f52cd1f5ff3cb"><code>07e614b</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2817">#2817</a> from dtolnay/corenet</li> <li><a href="https://github.com/serde-rs/serde/commit/b1f899fbe81f070803d9f7ca6e5d1cc3f19c9ea2"><code>b1f899f</code></a> Delete doc(cfg) attribute from impls that are supported in no-std</li> <li><a href="https://github.com/serde-rs/serde/commit/b4f860e62767828beb3ef91721b6c56a31f9baad"><code>b4f860e</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a> from MathiasKoch/chore/core-net</li> <li><a href="https://github.com/serde-rs/serde/commit/d940fe1b4934f097b0333dcb87bec5ee308d39cd"><code>d940fe1</code></a> Reuse existing Buf wrapper as replacement for std::io::Write</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.209...v1.0.210">compare view</a></li> </ul> </details> <br /> Updates `serde_derive` from 1.0.209 to 1.0.210 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/serde/releases">serde_derive's releases</a>.</em></p> <blockquote> <h2>v1.0.210</h2> <ul> <li>Support serializing and deserializing <code>IpAddr</code> and <code>SocketAddr</code> in no-std mode on Rust 1.77+ (<a href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a>, thanks <a href="https://github.com/MathiasKoch"><code>@MathiasKoch</code></a>)</li> <li>Make <code>serde::ser::StdError</code> and <code>serde::de::StdError</code> equivalent to <code>core::error::Error</code> on Rust 1.81+ (<a href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/serde/commit/89c4b02bf32ceae5b17d89f93a452ccc195ca038"><code>89c4b02</code></a> Release 1.0.210</li> <li><a href="https://github.com/serde-rs/serde/commit/eeb8e44cda15f929796cd72241b0311e0bd04e67"><code>eeb8e44</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2818">#2818</a> from dtolnay/coreerror</li> <li><a href="https://github.com/serde-rs/serde/commit/785c2d9605ee73cc172dfd421228c1dccca984c9"><code>785c2d9</code></a> Stabilize no-std StdError trait</li> <li><a href="https://github.com/serde-rs/serde/commit/d549f048e10bcb5e677afaf7b99d0ed3604b113b"><code>d549f04</code></a> Reformat parse_ip_impl definition and calls</li> <li><a href="https://github.com/serde-rs/serde/commit/4c0dd63011434905265e2710bb9186e09e4f8ec2"><code>4c0dd63</code></a> Delete attr support from core::net deserialization macros</li> <li><a href="https://github.com/serde-rs/serde/commit/26fb1341651c4e0ae4d58c675db3ca2a0d6e12c2"><code>26fb134</code></a> Relocate cfg attrs out of parse_ip_impl and parse_socket_impl</li> <li><a href="https://github.com/serde-rs/serde/commit/07e614b52b5ab3387d86d3198e5f52cd1f5ff3cb"><code>07e614b</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2817">#2817</a> from dtolnay/corenet</li> <li><a href="https://github.com/serde-rs/serde/commit/b1f899fbe81f070803d9f7ca6e5d1cc3f19c9ea2"><code>b1f899f</code></a> Delete doc(cfg) attribute from impls that are supported in no-std</li> <li><a href="https://github.com/serde-rs/serde/commit/b4f860e62767828beb3ef91721b6c56a31f9baad"><code>b4f860e</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/serde/issues/2816">#2816</a> from MathiasKoch/chore/core-net</li> <li><a href="https://github.com/serde-rs/serde/commit/d940fe1b4934f097b0333dcb87bec5ee308d39cd"><code>d940fe1</code></a> Reuse existing Buf wrapper as replacement for std::io::Write</li> <li>Additional commits viewable in <a href="https://github.com/serde-rs/serde/compare/v1.0.209...v1.0.210">compare view</a></li> </ul> </details> <br /> Updates `serde_json` from 1.0.127 to 1.0.128 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p> <blockquote> <h2>1.0.128</h2> <ul> <li>Support serializing maps containing 128-bit integer keys to serde_json::Value (<a href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a>, thanks <a href="https://github.com/Mrreadiness"><code>@Mrreadiness</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/serde-rs/json/commit/d96b1d9b643b49a0bb92a8cf280daf6aa08f37cc"><code>d96b1d9</code></a> Release 1.0.128</li> <li><a href="https://github.com/serde-rs/json/commit/599228d5dc52a0f1595fe4bd901821f70d0317a5"><code>599228d</code></a> Merge pull request <a href="https://redirect.github.com/serde-rs/json/issues/1188">#1188</a> from Mrreadiness/feat/add-hashmap-key-128-serializer</li> <li><a href="https://github.com/serde-rs/json/commit/5416cee6c5ad355907f6e9d5f6039b994c69f768"><code>5416cee</code></a> feat: add support for 128 bit HashMap key serialization</li> <li><a href="https://github.com/serde-rs/json/commit/27a4ca9d7a62394fe8f0103f3d91de59f055a4c4"><code>27a4ca9</code></a> Upload CI Cargo.lock for reproducing failures</li> <li>See full diff in <a href="https://github.com/serde-rs/json/compare/1.0.127...1.0.128">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 083f527 - Browse repository at this point
Copy the full SHA 083f527View commit details -
Bump lazy_static from 1.4.0 to 1.5.0 (#5639)
Bumps [lazy_static](https://github.com/rust-lang-nursery/lazy-static.rs) from 1.4.0 to 1.5.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/be7c1c43f264699f956b70ce8e29941bd1e61bde"><code>be7c1c4</code></a> point readme version to 1.5.0</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/8971a27dac57dbef72dd6abb9a55bca795ed58de"><code>8971a27</code></a> update readme build badge</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/15691ec43162cb50ba02bf39adac38f113688e77"><code>15691ec</code></a> Modernize lazy-static infra (<a href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/219">#219</a>)</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/2660041abcd4112854d1f6ebff35d421cc24263a"><code>2660041</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/206">#206</a> from TheBotlyNoob/master</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/6ace970cabd2bda121745d8b12539c93ba2878fd"><code>6ace970</code></a> Merge pull request <a href="https://redirect.github.com/rust-lang-nursery/lazy-static.rs/issues/216">#216</a> from frewsxcv/patch-1</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/a2031053df502518e44fec72712db8f927c6ee5c"><code>a203105</code></a> Update README.md</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/cfd89ac7fcbc3fb8ee5ee20b374b2b1dfb357198"><code>cfd89ac</code></a> Update README.md</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/fc8e466b94cc9c5f38d6002d3cc865f19a9ca004"><code>fc8e466</code></a> Update README.md</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/a8afb21bfd9dc53b51111bd1d9f19c2275fc97fe"><code>a8afb21</code></a> Update README.md</li> <li><a href="https://github.com/rust-lang-nursery/lazy-static.rs/commit/41fa23457d65b5c4688a42228734fd8479214a83"><code>41fa234</code></a> Update README to indicate how to replace with <code>std::sync::OnceLock</code></li> <li>Additional commits viewable in <a href="https://github.com/rust-lang-nursery/lazy-static.rs/compare/1.4.0...1.5.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=lazy_static&package-manager=cargo&previous-version=1.4.0&new-version=1.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for def35b9 - Browse repository at this point
Copy the full SHA def35b9View commit details -
Bump proc-macro2 from 1.0.82 to 1.0.86 (#5638)
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.82 to 1.0.86. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/proc-macro2/releases">proc-macro2's releases</a>.</em></p> <blockquote> <h2>1.0.86</h2> <ul> <li>Documentation improvements</li> </ul> <h2>1.0.85</h2> <ul> <li>Mark some tests as only for 64-bit targets (<a href="https://redirect.github.com/dtolnay/proc-macro2/issues/463">#463</a>)</li> </ul> <h2>1.0.84</h2> <ul> <li>Documentation improvements (<a href="https://redirect.github.com/dtolnay/proc-macro2/issues/455">#455</a>, thanks <a href="https://github.com/CensoredUsername"><code>@CensoredUsername</code></a>)</li> </ul> <h2>1.0.83</h2> <ul> <li>Optimize the representation of <code>Ident</code> (<a href="https://redirect.github.com/dtolnay/proc-macro2/issues/462">#462</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/proc-macro2/commit/aa9476b27932ae1b1b50bbfe0530b3b261fc1b72"><code>aa9476b</code></a> Release 1.0.86</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/19613587b70633e8bd383dd2fc29856d2d080f45"><code>1961358</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/proc-macro2/issues/466">#466</a> from dtolnay/buildrs</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/e1bd2cc29da09be421555bb0e1156c5e2b87df5d"><code>e1bd2cc</code></a> Bring build script comments up to date</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/5b271279521e11ac6eada5435e5a8d87f46d3619"><code>5b27127</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/proc-macro2/issues/465">#465</a> from dtolnay/ignorereason</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/0da4629757024ac6dac1680ba3be44bac24af809"><code>0da4629</code></a> Fill in ignore reasons in all #[ignore] attributes</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/5ee1cabadb40abe12abe27e3b34de8fc6f60bc0a"><code>5ee1cab</code></a> Release 1.0.85</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/aa64c2007390a33d4edbc07aa3e576848ae3d653"><code>aa64c20</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/proc-macro2/issues/464">#464</a> from dtolnay/testsize</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/bc9f4d938058be43d38f921f34f48b94a25278b7"><code>bc9f4d9</code></a> Ignore size tests on non-64bit target</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/1160ec3c7d723e115c5acf2b4e9f00c2c049e84a"><code>1160ec3</code></a> Make size tests #[ignore] in cfg(randomize_layout)</li> <li><a href="https://github.com/dtolnay/proc-macro2/commit/33c95785826bbd1fa353c48989dfc5a7ca62f54c"><code>33c9578</code></a> Release 1.0.84</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/proc-macro2/compare/1.0.82...1.0.86">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=proc-macro2&package-manager=cargo&previous-version=1.0.82&new-version=1.0.86)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f5783cc - Browse repository at this point
Copy the full SHA f5783ccView commit details -
[CI] Remove duplicate jobs (#5602)
All of these things are already tested in Github Actions: https://github.com/paritytech/polkadot-sdk/blob/b3c2a25b73bb4854f26204068f0aec3e8577196c/.github/workflows/checks-quick.yml#L50 Q: the `job-starter` seems to be used by tests, so am keeping it, but not sure how useful it is. --------- Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: alvicsam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a3eda0a - Browse repository at this point
Copy the full SHA a3eda0aView commit details -
Plumb RPC listener up to caller (#5038)
# Description This PR allows the RPC server's socket address to be returned when initializing the server. This allows the library consumer to easily programmatically determine which port the RPC server is listening on. My use case for this is automated testing. I'd like to be able to simply specify that the server bind to port '0' and then test against whatever port the OS assigns dynamically. I will have many RPC servers running in parallel across many tests within a single process, and I don't want to have to deal with port conflicts. ## Integration Integration is straightforward. My main concern is that I am making non-backwards-compatible changes to public library functions. Let me know if I should leave backwards-compatible wrappers in place for any/all of the public functions that were modified. ## Review Notes The rationale for making the new listen_addresses field on the RpcHandlers struct a ```[MultiAddr]``` rather than ```SocketAddr``` is because I wanted it to be transport-agnostic as well as capable of supporting multiple listening addresses in case that is ever required by the RPC server in the future. # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable) * [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) 1. I didn't understand what the 'T' label meant. Am I supposed to open a github Issue for my PR? 2. I didn't see an easy way to add tests since the functions I am modifying are not directly called by any tests. --------- Co-authored-by: Niklas Adolfsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c72f9ab - Browse repository at this point
Copy the full SHA c72f9abView commit details -
pallet-utility: Improve weight annotations (#5644)
Prevent allocations when calculating the weights. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f4eb417 - Browse repository at this point
Copy the full SHA f4eb417View commit details -
Allow to disable gap creation during block import (#5343)
This feature is helpful for us with custom sync protocol that is similar to Warp sync except we do not ever sync the gap and don't want it to exist in the first place (see #5333 and its references for motivation). Otherwise we had to resort to this: autonomys@d537512 --------- Co-authored-by: Davide Galassi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 030cb4a - Browse repository at this point
Copy the full SHA 030cb4aView commit details -
[Bot] Revive prdoc bot (#5648)
Prdoc bot was deleted in #5457 just after being added in #5331 without replacement. Now bringing it back until it is integrated into the new command structure. Formatting is now also fixed, such that the title is always first and the description renders correctly. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2d4e89f - Browse repository at this point
Copy the full SHA 2d4e89fView commit details -
Install prdoc from Parity fork (#5625)
Prdoc is now published as a Parity fork under the [`parity-prdoc`](https://crates.io/crates/parity-prdoc) crate after the directions diverged from the ideas of the original creator (discussions [here](paritytech/prdoc#40) and [here](paritytech/prdoc#36)). Now updating the install instructions here. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2e962f - Browse repository at this point
Copy the full SHA d2e962fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3f377f - Browse repository at this point
Copy the full SHA f3f377fView commit details -
frame pallet macro: fix span for error on wrong returned type. (#5580)
Explicitly give the types in some generated code so that the error shows up good when user code is wrong. --------- Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aec2b10 - Browse repository at this point
Copy the full SHA aec2b10View commit details
Commits on Sep 10, 2024
-
Update
RuntimeVerison
type and usesystem_version
to derive extri……nsics root `StateVersion` instead of `V0` (#4257) This PR - Renames `RuntimeVersion::state_version` to `system_version` - Uses `Runtime::system_version` to derive extrinsics root `StateVersion` instead of default `StateVersion::V0` This PR should not be breaking any existing chains so long as they use same `RuntimeVersion::state_version` for `Runtime::system_version` Using `RuntimeVersion::system_version = 2` will make the extrinsics root to use `StateVersion::V1` instead of `V0` RFC for this change - polkadot-fellows/RFCs#42 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Nazar Mokrynskyi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9930d21 - Browse repository at this point
Copy the full SHA 9930d21View commit details -
Bump the ci_dependencies group with 2 updates (#5637)
Bumps the ci_dependencies group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/checkout` from 2 to 4 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update default runtime to node20 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li> <li>Support fetching without the --progress option by <a href="https://github.com/simonbaird"><code>@simonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li> <li>Release 4.0.0 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/takost"><code>@takost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li> <li><a href="https://github.com/simonbaird"><code>@simonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p> <h2>v3.6.0</h2> <h2>What's Changed</h2> <ul> <li>Mark test scripts with Bash'isms to be run via Bash by <a href="https://github.com/dscho"><code>@dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1377">actions/checkout#1377</a></li> <li>Add option to fetch tags even if fetch-depth > 0 by <a href="https://github.com/RobertWieczoreck"><code>@RobertWieczoreck</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li> <li>Release 3.6.0 by <a href="https://github.com/luketomlinson"><code>@luketomlinson</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/RobertWieczoreck"><code>@RobertWieczoreck</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/579">actions/checkout#579</a></li> <li><a href="https://github.com/luketomlinson"><code>@luketomlinson</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1437">actions/checkout#1437</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0</a></p> <h2>v3.5.3</h2> <h2>What's Changed</h2> <ul> <li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics"><code>@megamanics</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li> <li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>@DimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li> <li>Add support for sparse checkouts by <a href="https://github.com/dscho"><code>@dscho</code></a> and <a href="https://github.com/dfdez"><code>@dfdez</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li> <li>Release v3.5.3 by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/megamanics"><code>@megamanics</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li> <li><a href="https://github.com/DimitriPapadopoulos"><code>@DimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li> <li><a href="https://github.com/dfdez"><code>@dfdez</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p> <h2>v3.5.2</h2> <h2>What's Changed</h2> <ul> <li>Fix: Use correct API url / endpoint in GHES by <a href="https://github.com/fhammerl"><code>@fhammerl</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1289">actions/checkout#1289</a> based on <a href="https://redirect.github.com/actions/checkout/issues/1286">#1286</a> by <a href="https://github.com/1newsr"><code>@1newsr</code></a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3.5.1...v3.5.2">https://github.com/actions/checkout/compare/v3.5.1...v3.5.2</a></p> <h2>v3.5.1</h2> <h2>What's Changed</h2> <ul> <li>Improve checkout performance on Windows runners by upgrading <code>@actions/github</code> dependency by <a href="https://github.com/BrettDong"><code>@BrettDong</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/BrettDong"><code>@BrettDong</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1246">actions/checkout#1246</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/692973e3d937129bcbf40652eb9f2f61becf3332"><code>692973e</code></a> Prepare 4.1.7 release (<a href="https://redirect.github.com/actions/checkout/issues/1775">#1775</a>)</li> <li><a href="https://github.com/actions/checkout/commit/6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6"><code>6ccd57f</code></a> Pin actions/checkout's own workflows to a known, good, stable version. (<a href="https://redirect.github.com/actions/checkout/issues/1776">#1776</a>)</li> <li><a href="https://github.com/actions/checkout/commit/b17fe1e4d59a9d1d95a7aead5e6fcd13e50939a5"><code>b17fe1e</code></a> Handle hidden refs (<a href="https://redirect.github.com/actions/checkout/issues/1774">#1774</a>)</li> <li><a href="https://github.com/actions/checkout/commit/b80ff79f1755d06ba70441c368a6fe801f5f3a62"><code>b80ff79</code></a> Bump actions/checkout from 3 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1697">#1697</a>)</li> <li><a href="https://github.com/actions/checkout/commit/b1ec3021b8fa02164da82ca1557d017d83b0e179"><code>b1ec302</code></a> Bump the minor-npm-dependencies group across 1 directory with 4 updates (<a href="https://redirect.github.com/actions/checkout/issues/1739">#1739</a>)</li> <li><a href="https://github.com/actions/checkout/commit/a5ac7e51b41094c92402da3b24376905380afc29"><code>a5ac7e5</code></a> Update for 4.1.6 release (<a href="https://redirect.github.com/actions/checkout/issues/1733">#1733</a>)</li> <li><a href="https://github.com/actions/checkout/commit/24ed1a352802348c9e4e8d13de9177fb95b537ba"><code>24ed1a3</code></a> Check platform for extension (<a href="https://redirect.github.com/actions/checkout/issues/1732">#1732</a>)</li> <li><a href="https://github.com/actions/checkout/commit/44c2b7a8a4ea60a981eaca3cf939b5f4305c123b"><code>44c2b7a</code></a> README: Suggest <code>user.email</code> to be `41898282+github-actions[bot]<a href="https://github.com/users"><code>@users</code></a>.norepl...</li> <li><a href="https://github.com/actions/checkout/commit/8459bc0c7e3759cdf591f513d9f141a95fef0a8f"><code>8459bc0</code></a> Bump actions/upload-artifact from 2 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1695">#1695</a>)</li> <li><a href="https://github.com/actions/checkout/commit/3f603f6d5e9f40714f97b2f017aa0df2a443192a"><code>3f603f6</code></a> Bump actions/setup-node from 1 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1696">#1696</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/checkout/compare/v2...v4">compare view</a></li> </ul> </details> <br /> Updates `peter-evans/create-pull-request` from 6.1.0 to 7.0.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>Create Pull Request v7.0.1</h2> <p>⚙️ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p> <h2>What's Changed</h2> <ul> <li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283">peter-evans/create-pull-request#3283</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288">peter-evans/create-pull-request#3288</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289">peter-evans/create-pull-request#3289</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3290">peter-evans/create-pull-request#3290</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3291">peter-evans/create-pull-request#3291</a></li> <li>fix: handle ambiguous argument failure on diff stat by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3312">peter-evans/create-pull-request#3312</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1">https://github.com/peter-evans/create-pull-request/compare/v7.0.0...v7.0.1</a></p> <h2>Create Pull Request v7.0.0</h2> <p>:sparkles: Now supports commit signing with bot-generated tokens! See "What's new" below. :writing_hand::robot:</p> <h3>Behaviour changes</h3> <ul> <li>Action input <code>git-token</code> has been renamed <code>branch-token</code>, to be more clear about its purpose. The <code>branch-token</code> is the token that the action will use to create and update the branch.</li> <li>The action now handles requests that have been rate-limited by GitHub. Requests hitting a primary rate limit will retry twice, for a total of three attempts. Requests hitting a secondary rate limit will not be retried.</li> <li>The <code>pull-request-operation</code> output now returns <code>none</code> when no operation was executed.</li> <li>Removed deprecated output environment variable <code>PULL_REQUEST_NUMBER</code>. Please use the <code>pull-request-number</code> action output instead.</li> </ul> <h3>What's new</h3> <ul> <li>The action can now sign commits as <code>github-actions[bot]</code> when using <code>GITHUB_TOKEN</code>, or your own bot when using <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#authenticating-with-github-app-generated-tokens">GitHub App tokens</a>. See <a href="https://github.com/peter-evans/create-pull-request/blob/HEAD/docs/concepts-guidelines.md#commit-signature-verification-for-bots">commit signing</a> for details.</li> <li>Action input <code>draft</code> now accepts a new value <code>always-true</code>. This will set the pull request to draft status when the pull request is updated, as well as on creation.</li> <li>A new action input <code>maintainer-can-modify</code> indicates whether <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork">maintainers can modify</a> the pull request. The default is <code>true</code>, which retains the existing behaviour of the action.</li> <li>A new output <code>pull-request-commits-verified</code> returns <code>true</code> or <code>false</code>, indicating whether GitHub considers the signature of the branch's commits to be verified.</li> </ul> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.36 to 18.19.39 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3000">peter-evans/create-pull-request#3000</a></li> <li>build(deps-dev): bump ts-jest from 29.1.5 to 29.2.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3008">peter-evans/create-pull-request#3008</a></li> <li>build(deps-dev): bump prettier from 3.3.2 to 3.3.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3018">peter-evans/create-pull-request#3018</a></li> <li>build(deps-dev): bump ts-jest from 29.2.0 to 29.2.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3019">peter-evans/create-pull-request#3019</a></li> <li>build(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3035">peter-evans/create-pull-request#3035</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.39 to 18.19.41 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3037">peter-evans/create-pull-request#3037</a></li> <li>build(deps): bump undici from 6.19.2 to 6.19.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3036">peter-evans/create-pull-request#3036</a></li> <li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3038">peter-evans/create-pull-request#3038</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.41 to 18.19.42 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3070">peter-evans/create-pull-request#3070</a></li> <li>build(deps): bump undici from 6.19.4 to 6.19.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3086">peter-evans/create-pull-request#3086</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.42 to 18.19.43 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3087">peter-evans/create-pull-request#3087</a></li> <li>build(deps-dev): bump ts-jest from 29.2.3 to 29.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3088">peter-evans/create-pull-request#3088</a></li> <li>build(deps): bump undici from 6.19.5 to 6.19.7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3145">peter-evans/create-pull-request#3145</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.43 to 18.19.44 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3144">peter-evans/create-pull-request#3144</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3154">peter-evans/create-pull-request#3154</a></li> <li>build(deps): bump undici from 6.19.7 to 6.19.8 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3213">peter-evans/create-pull-request#3213</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.44 to 18.19.45 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3214">peter-evans/create-pull-request#3214</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3221">peter-evans/create-pull-request#3221</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/peter-evans/create-pull-request/commit/8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20"><code>8867c4a</code></a> fix: handle ambiguous argument failure on diff stat (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3312">#3312</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/6073f5434ba635ff2f4390cddac0059ab04d9409"><code>6073f54</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3291">#3291</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/6d01b5601c7aca7ad0eb2f8532106269ac38b584"><code>6d01b56</code></a> build(deps-dev): bump eslint-plugin-import from 2.29.1 to 2.30.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3290">#3290</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/25cf8451c34bbbcbb3ef973b252eb91ec1ad8be9"><code>25cf845</code></a> build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.17.0 to 7.18.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3289">#3289</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/d87b980a0ebf44e8ed8ef733b28171c81ca501af"><code>d87b980</code></a> build(deps-dev): bump <code>@types/node</code> from 18.19.46 to 18.19.48 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3288">#3288</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/119d131ea9fd0db1802246d0098211de13a26406"><code>119d131</code></a> build(deps): bump peter-evans/create-pull-request from 6 to 7 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3283">#3283</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/73e6230af4af8faaeddac4d3f16e25f8a2bd8e4b"><code>73e6230</code></a> docs: update readme</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/c0348e860fc89e6cc1f5b623f7b1140d6ee9a2d5"><code>c0348e8</code></a> ci: add v7 to workflow</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/4320041ed380b20e97d388d56a7fb4f9b8c20e79"><code>4320041</code></a> feat: signed commits (v7) (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3057">#3057</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/0c2a66fe4af462aa0761939bd32efbdd46592737"><code>0c2a66f</code></a> build(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3256">#3256</a>)</li> <li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...8867c4aba1b742c39f8d0ba35429c2dfa4b6cb20">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7c90f51 - Browse repository at this point
Copy the full SHA 7c90f51View commit details -
Fix edge case where state sync is not triggered (#5635)
This PR addresses an issue where state sync may fail to start if the conditions required for its initiation are not met when a finalized block notification is received. `pending_state_sync_attempt` is introduced to trigger the state sync later when the conditions are satisfied. This issue was spotted when I worked on #5406, specifically, `queue_blocks` was not empty when the finalized block notification was received, and then the state sync was stalled. cc @dmitry-markin --------- Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8236718 - Browse repository at this point
Copy the full SHA 8236718View commit details -
[WIP][ci] GHA improvements (#5653)
Changes in PR: - enables `Check Cargo Check Runtimes` (it was accidentally disabled) - reorder jobs in test-misc to make it faster - add `quick-benchmarks-omni` to `check-frame-omni-bencher` (the workflow is currently disabled)
Configuration menu - View commit details
-
Copy full SHA for 9079f36 - Browse repository at this point
Copy the full SHA 9079f36View commit details -
[Bot] Use correct token in backport bot (#5654)
The backport bot does currently not trigger the CI when opening a MR, like here: #5651 Devs need to push an empty commit manually. Now using a token that will also trigger the CI. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d887804 - Browse repository at this point
Copy the full SHA d887804View commit details -
Syncing strategy refactoring (#5469)
This is a step towards #5333 The commits with code moving (but no other changes) and actual changes are separated for easier review. Essentially this results in `SyncingStrategy` trait replacing struct (which is renamed to `PolkadotSyncingStrategy`, open for better name suggestions). Technically it is already possible to replace `PolkadotSyncingStrategy<B, Client>` with `Box<dyn SyncingStrategy<B>` in syncing engine, but I decided to postpone such change until we actually have an ability to customize it. It should also be possible to swap `PolkadotSyncingStrategy` with just `ChainSync` that only supports regular full sync from genesis (it also implements `SyncingStrategy` trait). While extracted trait still has a lot of non-generic stuff in it like exposed knowledge of warp sync and `StrategyKey` with hardcoded set of options, I believe this is a step in the right direction and will address those in upcoming PRs. With #5431 that landed earlier warp sync configuration is more straightforward, but there are still numerous things interleaved that will take some time to abstract away nicely and expose in network config for developers. For now this is an internal change even though data structures are technically public and require major version bump.
Configuration menu - View commit details
-
Copy full SHA for 1f1f20a - Browse repository at this point
Copy the full SHA 1f1f20aView commit details -
Introduce
RpcParams
in sc-cli (#5601)This PR is a pure refactoring by consolidating all the RPC related parameters into a dedicated `RpcParams` struct, allowing us at subcoin to build a custom run cmd without the need to duplicate code. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Niklas Adolfsson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 278d1bf - Browse repository at this point
Copy the full SHA 278d1bfView commit details -
litep2p: Update network backend to v0.7.0 (#5609)
This release introduces several new features, improvements, and fixes to the litep2p library. Key updates include enhanced error handling, configurable connection limits, and a new API for managing public addresses. For a detailed set of changes, see [litep2p changelog](https://github.com/paritytech/litep2p/blob/master/CHANGELOG.md#070---2024-09-05). This PR makes use of: - connection limits to optimize network throughput - better errors that are propagated to substrate metrics - public addresses API to report healthy addresses to the Identify protocol ### Warp sync time improvement Measuring warp sync time is a bit inaccurate since the network is not deterministic and we might end up using faster peers (peers with more resources to handle our requests). However, I did not see warp sync times of 16 minutes, instead, they are roughly stabilized between 8 and 10 minutes. For measuring warp-sync time, I've used [sub-trige-logs](https://github.com/lexnv/sub-triage-logs/?tab=readme-ov-file#warp-time) ### Litep2p Phase | Time -|- Warp | 426.999999919s State | 99.000000555s Total | 526.000000474s ### Libp2p Phase | Time -|- Warp | 731.999999837s State | 71.000000882s Total | 803.000000719s Closes: #4986 ### Low peer count After exposing the `litep2p::public_addresses` interface, we can report to litep2p confirmed external addresses. This should mitigate or at least improve: #4925. Will keep the issue around to confirm this. ### Improved metrics We are one step closer to exposing similar metrics as libp2p: #4681. cc @paritytech/networking ### Next Steps - [x] Use public address interface to confirm addresses to identify protocol --------- Signed-off-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 12eeb5d - Browse repository at this point
Copy the full SHA 12eeb5dView commit details -
Add prdoc command to /cmd (#5661)
Fixes #5647 - [x] create new command (reusing original py module) - [x] add unit-test cases (just the fact of proxy) - [x] update docs
Configuration menu - View commit details
-
Copy full SHA for f0e420a - Browse repository at this point
Copy the full SHA f0e420aView commit details
Commits on Sep 11, 2024
-
Send balance when contract doesn't exist (#5664)
Fixes #5577 I decided to bubble up the error from where we actually try to load the contract info. This helps to make sure that we don't miss some entry point by accident. The draw back is that we have to live with some additional `.expect`. @pgherveou With this logic the proxy and its runtime part should be completely unaware whether something is a contract call or a balance transfer. They should just route everything into pallet_revive. --------- Co-authored-by: Cyrill Leutwiler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea5fb02 - Browse repository at this point
Copy the full SHA ea5fb02View commit details