Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-18632] Sorting stage detail table on orgunit breaks the app #3917

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: [DHIS2-18632] Sorting stage detail table on orgunit breaks the app #3917

wants to merge 5 commits into from

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Dec 20, 2024 •
edited by jira bot
Loading

DHIS2-18632

  • Changed type from TEXT to ORGANISATION_UNIT
  • Org. unit is now converted withinclientToList
  • Reimplemented getCachedOrgUnitName function to handle sorting (removed in DHIS2-17771)

@henrikmv henrikmv marked this pull request as ready for review December 20, 2024 09:41
@henrikmv henrikmv requested a review from a team as a code owner December 20, 2024 09:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3917.capture.netlify.dhis2.org

geethaalwan
geethaalwan approved these changes Jan 7, 2025
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.3,2.40.7,2.39.9 versions

@henrikmv henrikmv added testing and removed testing labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrikmv @simonadomnisoru @geethaalwan