Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-17575] disable create new buttons if no data write access #3751

Merged
merged 6 commits into from
Aug 22, 2024
Merged

feat: [DHIS2-17575] disable create new buttons if no data write access #3751

merged 6 commits into from
Aug 22, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

Summary:

  • Unify logic for create new event buttons in stages&events widget
  • Disable quick actions button if there are no stages with write access
  • Disable ProgramStageSelector-buttons if user does not have write access

@eirikhaugstulen eirikhaugstulen added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing labels Aug 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3751--dhis2-capture.netlify.app

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review August 11, 2024 21:48
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner August 11, 2024 21:48
@eirikhaugstulen
Copy link
Contributor Author

Thanks for the review @simonadomnisoru! I also added some tests using the new trackerAutoTestRestricted 🎉

simonadomnisoru
simonadomnisoru approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eirikhaugstulen eirikhaugstulen added testing and removed testing e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels Aug 13, 2024
geethaalwan
geethaalwan approved these changes Aug 19, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42, 2.41.1,2.40.5,2.39.7 versions

@cooper-joe cooper-joe mentioned this pull request Aug 21, 2024
Merged
@eirikhaugstulen eirikhaugstulen merged commit 5b3cd1c into master Aug 22, 2024
63 of 64 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/feat/DHIS2-17575-disable-create-new-buttons-if-no-access branch August 22, 2024 21:38
dhis2-bot added a commit that referenced this pull request Aug 22, 2024
@dhis2-bot
chore(release): cut 101.2.0 [skip release]
f5902dd 
# [101.2.0](v101.1.3...v101.2.0) (2024-08-22)

### Features

* [DHIS2-17575] disable create new buttons if no data write access ([#3751](#3751)) ([5b3cd1c](5b3cd1c))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @geethaalwan