Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme support #14

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Add dark theme support #14

merged 4 commits into from
Jan 11, 2024

Conversation

luclu7
Copy link
Contributor

@luclu7 luclu7 commented Jan 8, 2024

The old automatic "dark" theme was not awesome, so I tried adding a better support. I'm not a Sass expert,
Old:
old theme

New:
"new" theme

image
image

@dhenry123
Copy link
Owner

dhenry123 commented Jan 9, 2024

Thank you very much for your interest.
Could you set the logo background to the same colour as the header background?

.header .logo {
  margin: 4px;
  cursor: pointer;
  background-color: inherit;
  padding: 6px 6px 0 0;
  opacity: .7;
}

@luclu7
Copy link
Contributor Author

luclu7 commented Jan 9, 2024

The colors of the logo are a bit too dark to contrast correctly in my opinion
image

Inverse is waaaaay too awkward
image

This is filter: brightness(0) invert(1);, it's a bit sad without any color
image

Or maybe, just a "proper" rounded white background?
image

Which one would you prefer?

@dhenry123
Copy link
Owner

dhenry123 commented Jan 10, 2024

I've created a new branch: "logodarkmode".
Could you pull it and add the new file "client/public/assets/MytinyDC_logo-brand-full-darkmode.png" to your branch, then define the darkmode css accordingly...
Thank you so much

@luclu7
Copy link
Contributor Author

luclu7 commented Jan 10, 2024

This logo looks great !
image

@dhenry123 dhenry123 merged commit fef563e into dhenry123:main Jan 11, 2024
1 check passed
@luclu7
Copy link
Contributor Author

luclu7 commented Jan 11, 2024

By the way, beware, the tag of the last release is 1.20 instead of 1.2.0

@dhenry123
Copy link
Owner

Thanks, I'll now avoid publishing a release while having breakfast. :)

luclu7 added a commit to luclu7/utdon that referenced this pull request Jan 18, 2024
* Add dark theme support

* PageLogin: dark theme support

* add logo for dark mode scss

* Dark theme: correct the logo

---------
@luclu7 luclu7 deleted the dark-theme branch January 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants