Modernize the module #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There already are beaker-rspec tests, which is the modern way.
These are all outdated and the modern way is to use beaker-hostgenerator to generate these on the fly.
This allows using modern facts
URI.parse has been removed in Ruby 3. This puts the burden on the caller in Puppet to provide escaped URLs.
In modern Puppet this can result in it trying to interpret the key IDs as numbers
|
GitHub Actions will only run once there is a branch in this repository that adds the same workflow files. A workaround is to once push this branch here and then delete it again. It'll continue running, even on updates. |
|
Stumbled across this while we're looking at upgrading to Puppet 8, and potential issues with legacy facts. Curious if there's been any movement on this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a lot to bring the module up to current standards. See individual commits for details.
Right now the acceptance tests are incomplete and I haven't had time to look into them. I did notice that nobody serves GPG keys over plain HTTP anymore; they all redirect to HTTPS so I wonder if we should keep testing that.