Fix corner case with test file discovery (#301)

* Fix corner case with test file discovery

* 0.16.10

package.json

@@ -2,7 +2,7 @@
     "name": "vscode-motoko",
     "displayName": "Motoko",
     "description": "Motoko language support",
-    "version": "0.16.9",
+    "version": "0.16.10",
     "publisher": "dfinity-foundation",
     "repository": "https://github.com/dfinity/vscode-motoko",
     "engines": {

src/common/watchConfig.ts

@@ -1 +1,6 @@
 export const watchGlob = '**/*.{mo,did,json,dhall,toml}';
+
+export const ignoreGlobPatterns = [
+    '**/node_modules/**/*', // npm packages
+    '**/.vessel/.tmp/**/*', // temporary Vessel files
+];

src/extension.ts

@@ -39,7 +39,7 @@ import {
     TestParams,
     TestResult,
 } from './common/connectionTypes';
-import { watchGlob } from './common/watchConfig';
+import { ignoreGlobPatterns, watchGlob } from './common/watchConfig';
 import { formatDocument } from './formatter';
 
 const config = workspace.getConfiguration('motoko');
@@ -232,14 +232,24 @@ function setupTests(context: ExtensionContext) {
             controller.items.add(item);
             testItemTypeMap.set(item, ItemType.File);
         } catch (err) {
-            console.error(`Error while adding test file: ${uri}\n${err}`);
+            console.error(`Error while adding test file: ${uri}`);
+            console.error(err);
         }
     };
     workspace.workspaceFolders?.forEach((workspaceFolder) => {
-        const directory = workspaceFolder.uri.fsPath;
-        glob.sync(pattern, { cwd: directory }).forEach((file) => {
-            addFile(Uri.file(path.resolve(directory, file)));
-        });
+        try {
+            const directory = workspaceFolder.uri.fsPath;
+            glob.sync(pattern, {
+                cwd: directory,
+                ignore: ignoreGlobPatterns,
+                followSymbolicLinks: false,
+            }).forEach((file) => {
+                addFile(Uri.file(path.resolve(directory, file)));
+            });
+        } catch (err) {
+            console.error('Error while loading test files:');
+            console.error(err);
+        }
     });
     watcher.onDidCreate(addFile, context.subscriptions);
     watcher.onDidChange(addFile, context.subscriptions);

src/server/server.ts

@@ -45,7 +45,10 @@ import {
     TEST_FILE_REQUEST,
     TestResult,
 } from '../common/connectionTypes';
-import { watchGlob as virtualFilePattern } from '../common/watchConfig';
+import {
+    ignoreGlobPatterns,
+    watchGlob as virtualFilePattern,
+} from '../common/watchConfig';
 import icCandid from '../generated/aaaaa-aa.did';
 import { globalASTCache } from './ast';
 import {
@@ -103,11 +106,6 @@ interface MotokoSettings {
     debugHover: boolean;
 }
 
-const ignoreGlobs = [
-    '**/node_modules/**/*', // npm packages
-    '**/.vessel/.tmp/**/*', // temporary Vessel files
-];
-
 const shouldHideWarnings = (uri: string) =>
     uri.includes('/.vessel/') || uri.includes('/.mops/');
 
@@ -246,7 +244,7 @@ function notifyPackageConfigChange(reuseCached = false) {
                     const cwd = resolveFilePath(workspaceFolder.uri);
                     const paths = glob.sync(`**/{${filenames.join(',')}}`, {
                         cwd,
-                        ignore: ignoreGlobs,
+                        ignore: ignoreGlobPatterns,
                         dot: false,
                         followSymbolicLinks: false,
                     });
@@ -686,7 +684,7 @@ function notifyWorkspace() {
         glob.sync(virtualFilePattern, {
             cwd: folderPath,
             dot: true,
-            ignore: ignoreGlobs,
+            ignore: ignoreGlobPatterns,
             followSymbolicLinks: false,
         }).forEach((relativePath) => {
             const path = join(folderPath, relativePath);